| Message ID | 87msnx4ec6.fsf@yahoo.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9d32685a251a754f1823d287df233716aa23bcb9 |
| Headers | show |
| Series | [RESEND] usb: uas: set host status byte on data completion error | expand |
On 07.06.24 05:32, Shantanu Goel wrote: > Set the host status byte when a data completion error is encountered > otherwise the upper layer may end up using the invalid zero'ed data. > The following output was observed from scsi/sd.c prior to this fix. > > [ 11.872824] sd 0:0:0:1: [sdf] tag#9 data cmplt err -75 uas-tag 1 inflight: > [ 11.872826] sd 0:0:0:1: [sdf] tag#9 CDB: Read capacity(16) 9e 10 00 00 00 00 00 00 00 00 00 00 00 20 00 00 > [ 11.872830] sd 0:0:0:1: [sdf] Sector size 0 reported, assuming 512. > > Signed-off-by: Shantanu Goel <sgoel01@yahoo.com> Acked-by: Oliver Neukum <oneukum@suse.com>
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c index 451d9569163a..f794cb39cc31 100644 --- a/drivers/usb/storage/uas.c +++ b/drivers/usb/storage/uas.c @@ -422,6 +422,7 @@ static void uas_data_cmplt(struct urb *urb) uas_log_cmd_state(cmnd, "data cmplt err", status); /* error: no data transfered */ scsi_set_resid(cmnd, sdb->length); + set_host_byte(cmnd, DID_ERROR); } else { scsi_set_resid(cmnd, sdb->length - urb->actual_length); }
Set the host status byte when a data completion error is encountered otherwise the upper layer may end up using the invalid zero'ed data. The following output was observed from scsi/sd.c prior to this fix. [ 11.872824] sd 0:0:0:1: [sdf] tag#9 data cmplt err -75 uas-tag 1 inflight: [ 11.872826] sd 0:0:0:1: [sdf] tag#9 CDB: Read capacity(16) 9e 10 00 00 00 00 00 00 00 00 00 00 00 20 00 00 [ 11.872830] sd 0:0:0:1: [sdf] Sector size 0 reported, assuming 512. Signed-off-by: Shantanu Goel <sgoel01@yahoo.com> --- drivers/usb/storage/uas.c | 1 + 1 file changed, 1 insertion(+)