diff mbox series

Quectel EM05G LTE Modem with new Product ID

Message ID AM0PR04MB5764EE9ECBEC5B8E00BBD84D973EA@AM0PR04MB5764.eurprd04.prod.outlook.com (mailing list archive)
State New, archived
Headers show
Series Quectel EM05G LTE Modem with new Product ID | expand

Commit Message

Martin Kohn July 20, 2023, 12:30 p.m. UTC 
Hello everyone,

Quectel has changed the product ID for EM05G LTE Modem (global variant), here my verified patch for it:

From 7a19d929aa07b3541f6a1205cb0ce3f0f5dc54a6 Mon Sep 17 00:00:00 2001
From: Martin Kohn mailto:m.kohn@welotec.com
Date: Wed, 19 Jul 2023 12:04:21 +0200
Subject: [PATCH] Quectel has changed the Product ID from 030a to 030e for the
EM05G modem. Both versions must be supported in the future.

Signed-off-by: Martin Kohn mailto:m.kohn@welotec.com
---
drivers/usb/serial/option.c | 3 +++
1 file changed, 3 insertions(+)

Comments

gregkh@linuxfoundation.org July 20, 2023, 1:38 p.m. UTC | #1 
On Thu, Jul 20, 2023 at 12:30:53PM +0000, Martin Kohn wrote:
> Hello everyone,
> 
> Quectel has changed the product ID for EM05G LTE Modem (global variant), here my verified patch for it:
> 
> >From 7a19d929aa07b3541f6a1205cb0ce3f0f5dc54a6 Mon Sep 17 00:00:00 2001
> From: Martin Kohn mailto:m.kohn@welotec.com
> Date: Wed, 19 Jul 2023 12:04:21 +0200
> Subject: [PATCH] Quectel has changed the Product ID from 030a to 030e for the
> EM05G modem. Both versions must be supported in the future.
> 
> Signed-off-by: Martin Kohn mailto:m.kohn@welotec.com
> ---
> drivers/usb/serial/option.c | 3 +++
> 1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index 288a96a74266..64b1995b410d 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -256,6 +256,7 @@ static void option_instat_callback(struct urb *urb);
> #define QUECTEL_PRODUCT_BG96                                         0x0296
> #define QUECTEL_PRODUCT_EP06                                         0x0306
> #define QUECTEL_PRODUCT_EM05G                                    0x030a
> +#define QUECTEL_PRODUCT_EM05GV2                              0x030e
> #define QUECTEL_PRODUCT_EM060K                                   0x030b
> #define QUECTEL_PRODUCT_EM05G_CS                             0x030c
> #define QUECTEL_PRODUCT_EM05CN_SG                          0x0310
> @@ -1186,6 +1187,8 @@ static const struct usb_device_id option_ids[] = {
>                  .driver_info = RSVD(6) | ZLP },
>                { USB_DEVICE_INTERFACE_CLASS(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EM05G, 0xff),
>                  .driver_info = RSVD(6) | ZLP },
> +        { USB_DEVICE_INTERFACE_CLASS(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EM05GV2, 0xff),
> +          .driver_info = RSVD(6) | ZLP },
>                { USB_DEVICE_INTERFACE_CLASS(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EM05G_CS, 0xff),
>                  .driver_info = RSVD(6) | ZLP },
>                { USB_DEVICE_INTERFACE_CLASS(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EM05G_GR, 0xff),
> -- 
> 2.25.1
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch is malformed (tabs converted to spaces, linewrapped, etc.)
  and can not be applied.  Please read the file,
  Documentation/process/email-clients.rst in order to fix this.

- Your patch was attached, please place it inline so that it can be
  applied directly from the email message itself.

- You did not specify a description of why the patch is needed, or
  possibly, any description at all, in the email body.  Please read the
  section entitled "The canonical patch format" in the kernel file,
  Documentation/process/submitting-patches.rst for what is needed in
  order to properly describe the change.

- You did not write a descriptive Subject: for the patch, allowing Greg,
  and everyone else, to know what this patch is all about.  Please read
  the section entitled "The canonical patch format" in the kernel file,
  Documentation/process/submitting-patches.rst for what a proper
  Subject: line should look like.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot
Johan Hovold July 20, 2023, 2:09 p.m. UTC | #2 
On Thu, Jul 20, 2023 at 12:30:53PM +0000, Martin Kohn wrote:
> Hello everyone,
> 
> Quectel has changed the product ID for EM05G LTE Modem (global variant), here my verified patch for it:
> 
> From 7a19d929aa07b3541f6a1205cb0ce3f0f5dc54a6 Mon Sep 17 00:00:00 2001
> From: Martin Kohn mailto:m.kohn@welotec.com
> Date: Wed, 19 Jul 2023 12:04:21 +0200
> Subject: [PATCH] Quectel has changed the Product ID from 030a to 030e for the
> EM05G modem. Both versions must be supported in the future.
> 
> Signed-off-by: Martin Kohn mailto:m.kohn@welotec.com
> ---
> drivers/usb/serial/option.c | 3 +++
> 1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index 288a96a74266..64b1995b410d 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -256,6 +256,7 @@ static void option_instat_callback(struct urb *urb);
> #define QUECTEL_PRODUCT_BG96                                         0x0296
> #define QUECTEL_PRODUCT_EP06                                         0x0306
> #define QUECTEL_PRODUCT_EM05G                                    0x030a
> +#define QUECTEL_PRODUCT_EM05GV2                              0x030e
> #define QUECTEL_PRODUCT_EM060K                                   0x030b
> #define QUECTEL_PRODUCT_EM05G_CS                             0x030c
> #define QUECTEL_PRODUCT_EM05CN_SG                          0x0310
> @@ -1186,6 +1187,8 @@ static const struct usb_device_id option_ids[] = {
>                  .driver_info = RSVD(6) | ZLP },
>                { USB_DEVICE_INTERFACE_CLASS(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EM05G, 0xff),
>                  .driver_info = RSVD(6) | ZLP },
> +        { USB_DEVICE_INTERFACE_CLASS(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EM05GV2, 0xff),
> +          .driver_info = RSVD(6) | ZLP },
>                { USB_DEVICE_INTERFACE_CLASS(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EM05G_CS, 0xff),
>                  .driver_info = RSVD(6) | ZLP },
>                { USB_DEVICE_INTERFACE_CLASS(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EM05G_GR, 0xff),

Your patch is corrupt (e.g. tabs replaced by spaces) and cannot be
applied. It also lacks proper commit summary (Subject) and commit
message.

Take a look at

	https://lore.kernel.org/all/20230710075218.8895-1-moh53n@moh53n.ir/

for a recent example of what this should look like.

Also make sure to send the patch to yourself first and run checkpatch on
it to make sure it's not damaged in transport.

Johan
Martin Kohn July 24, 2023, 9:24 a.m. UTC | #3 
Hello Johan,

Could you please point me to what I did exactly wrong, now I tried second time and as I'm new here, I honestly do not know what I did wrong?
I did run checkpatch and applied it back to my repository and everything is fine on my side.

-Martin Kohn

-----Original Message-----
From: Johan Hovold <johan@kernel.org>
Sent: Thursday, July 20, 2023 4:09 PM
To: Martin Kohn <m.kohn@welotec.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] Quectel EM05G LTE Modem with new Product ID

On Thu, Jul 20, 2023 at 12:30:53PM +0000, Martin Kohn wrote:
> Hello everyone,
>
> Quectel has changed the product ID for EM05G LTE Modem (global variant), here my verified patch for it:
>
> From 7a19d929aa07b3541f6a1205cb0ce3f0f5dc54a6 Mon Sep 17 00:00:00 2001
> From: Martin Kohn mailto:m.kohn@welotec.com
> Date: Wed, 19 Jul 2023 12:04:21 +0200
> Subject: [PATCH] Quectel has changed the Product ID from 030a to 030e
> for the EM05G modem. Both versions must be supported in the future.
>
> Signed-off-by: Martin Kohn mailto:m.kohn@welotec.com
> ---
> drivers/usb/serial/option.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index 288a96a74266..64b1995b410d 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -256,6 +256,7 @@ static void option_instat_callback(struct urb
> *urb); #define QUECTEL_PRODUCT_BG96
> 0x0296 #define QUECTEL_PRODUCT_EP06
> 0x0306 #define QUECTEL_PRODUCT_EM05G
> 0x030a
> +#define QUECTEL_PRODUCT_EM05GV2                              0x030e
> #define QUECTEL_PRODUCT_EM060K
> 0x030b #define QUECTEL_PRODUCT_EM05G_CS
> 0x030c #define QUECTEL_PRODUCT_EM05CN_SG
> 0x0310 @@ -1186,6 +1187,8 @@ static const struct usb_device_id
> option_ids[] = {
>                  .driver_info = RSVD(6) | ZLP },
>                { USB_DEVICE_INTERFACE_CLASS(QUECTEL_VENDOR_ID,
> QUECTEL_PRODUCT_EM05G, 0xff),
>                  .driver_info = RSVD(6) | ZLP },
> +        { USB_DEVICE_INTERFACE_CLASS(QUECTEL_VENDOR_ID,
> +QUECTEL_PRODUCT_EM05GV2, 0xff),
> +          .driver_info = RSVD(6) | ZLP },
>                { USB_DEVICE_INTERFACE_CLASS(QUECTEL_VENDOR_ID,
> QUECTEL_PRODUCT_EM05G_CS, 0xff),
>                  .driver_info = RSVD(6) | ZLP },
>                { USB_DEVICE_INTERFACE_CLASS(QUECTEL_VENDOR_ID,
> QUECTEL_PRODUCT_EM05G_GR, 0xff),

Your patch is corrupt (e.g. tabs replaced by spaces) and cannot be applied. It also lacks proper commit summary (Subject) and commit message.

Take a look at

        https://lore.kernel.org/all/20230710075218.8895-1-moh53n@moh53n.ir/

for a recent example of what this should look like.

Also make sure to send the patch to yourself first and run checkpatch on it to make sure it's not damaged in transport.

Johan
Johan Hovold July 24, 2023, 9:58 a.m. UTC | #4 
Hi Marin,

When working upstream you should remember to reply inline (and trim
unneeded context) rather than top posting as you did here.

Also wrap your mails at 72 columns or so (I've added the missing
newlines below).

On Mon, Jul 24, 2023 at 09:24:34AM +0000, Martin Kohn wrote:

> Could you please point me to what I did exactly wrong, now I tried
> second time and as I'm new here, I honestly do not know what I did
> wrong?

It looks your second attempt worked correctly:

	https://lore.kernel.org/all/AM0PR04MB576480684AA0896B32D32975973FA@AM0PR04MB5764.eurprd04.prod.outlook.com/#t

In your previous attempt, tabs had specifically been replaced by spaces.

> I did run checkpatch and applied it back to my repository and
> everything is fine on my side.

As long as you ran checkpatch on the patch (and applied it) *after*
mailing it to yourself, you should be good.

Also remember to include me as a recipient when posting. My filters
should catch it anyway, but it may take some time before I see it.

Johan
diff mbox series

Patch

diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index 288a96a74266..64b1995b410d 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -256,6 +256,7 @@  static void option_instat_callback(struct urb *urb);
#define QUECTEL_PRODUCT_BG96                                         0x0296
#define QUECTEL_PRODUCT_EP06                                         0x0306
#define QUECTEL_PRODUCT_EM05G                                    0x030a
+#define QUECTEL_PRODUCT_EM05GV2                              0x030e
#define QUECTEL_PRODUCT_EM060K                                   0x030b
#define QUECTEL_PRODUCT_EM05G_CS                             0x030c
#define QUECTEL_PRODUCT_EM05CN_SG                          0x0310
@@ -1186,6 +1187,8 @@  static const struct usb_device_id option_ids[] = {
                 .driver_info = RSVD(6) | ZLP },
               { USB_DEVICE_INTERFACE_CLASS(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EM05G, 0xff),
                 .driver_info = RSVD(6) | ZLP },
+        { USB_DEVICE_INTERFACE_CLASS(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EM05GV2, 0xff),
+          .driver_info = RSVD(6) | ZLP },
               { USB_DEVICE_INTERFACE_CLASS(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EM05G_CS, 0xff),
                 .driver_info = RSVD(6) | ZLP },
               { USB_DEVICE_INTERFACE_CLASS(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EM05G_GR, 0xff),