Subject: [PATCH v3 1/2] USB: serial: cp210x: Enable usb generic throttle/unthrottle

Commit Message

Phu Luu June 24, 2020, 4:11 a.m. UTC

Assign the .throttle and .unthrottle functions to be generic function
in the driver structure to prevent data loss that can otherwise occur
if the host does not enable USB throttling.

Signed-off-by: Phu Luu An <[e-mail]>
Signed-off-by: Brant Merryman <[e-mail]>
---
06/09/2020: Patch v3 1/2 Modified based on feedback from Johan Hovold <[e-mail]>
12/18/2019: Patch v2 Broken into two patches and modified based on feedback from Johan Hovold <[e-mail]>
12/09/2019: Initial submission of patch "Proper RTS control when buffers fill"

 drivers/usb/serial/cp210x.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Greg Kroah-Hartman June 24, 2020, 5:03 a.m. UTC | #1

On Wed, Jun 24, 2020 at 04:11:21AM +0000, Phu Luu wrote:
> Assign the .throttle and .unthrottle functions to be generic function
> in the driver structure to prevent data loss that can otherwise occur
> if the host does not enable USB throttling.
> 
> Signed-off-by: Phu Luu An <[e-mail]>
> Signed-off-by: Brant Merryman <[e-mail]>

Why does your Subject: line have "Subject:" in it again?

Can you please fix up and resend these patches?

thanks,

greg k-h

Patch

diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
index f5143eedbc48..bcceb4ad8be0 100644
--- a/drivers/usb/serial/cp210x.c
+++ b/drivers/usb/serial/cp210x.c
@@ -272,6 +272,8 @@  static struct usb_serial_driver cp210x_device = {
 	.break_ctl		= cp210x_break_ctl,
 	.set_termios		= cp210x_set_termios,
 	.tx_empty		= cp210x_tx_empty,
+	.throttle		= usb_serial_generic_throttle,
+	.unthrottle		= usb_serial_generic_unthrottle,
 	.tiocmget		= cp210x_tiocmget,
 	.tiocmset		= cp210x_tiocmset,
 	.attach			= cp210x_attach,