| Message ID | b2846f91-90ba-8ffa-9afe-ab9e719ed780@free.fr (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | usb: dwc3: Allow building USB_DWC3_QCOM without EXTCON | expand |
On 19/04/2019 11:59, Marc Gonzalez wrote: > Keep EXTCON support optional, since some platforms do not need it. > > Fixes: 3def4031b3e3 ("usb: dwc3: add EXTCON dependency for qcom") > Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr> > --- > drivers/usb/dwc3/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig > index 2b1494460d0c..6bd1a28c535f 100644 > --- a/drivers/usb/dwc3/Kconfig > +++ b/drivers/usb/dwc3/Kconfig > @@ -115,7 +115,8 @@ config USB_DWC3_ST > > config USB_DWC3_QCOM > tristate "Qualcomm Platform" > - depends on EXTCON && (ARCH_QCOM || COMPILE_TEST) > + depends on ARCH_QCOM || COMPILE_TEST > + depends on EXTCON || !EXTCON > depends on OF > default USB_DWC3 > help Can I get an amen? :-) Arnd? Greg? Mom?
On Fri, Apr 19, 2019 at 11:59 AM Marc Gonzalez <marc.w.gonzalez@free.fr> wrote: > > Keep EXTCON support optional, since some platforms do not need it. > > Fixes: 3def4031b3e3 ("usb: dwc3: add EXTCON dependency for qcom") > Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr> The patch looks good, but please keep this in sync with the TI driver that does the same thing, so better convert them both in one patch. > --- > drivers/usb/dwc3/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig > index 2b1494460d0c..6bd1a28c535f 100644 > --- a/drivers/usb/dwc3/Kconfig > +++ b/drivers/usb/dwc3/Kconfig > @@ -115,7 +115,8 @@ config USB_DWC3_ST > > config USB_DWC3_QCOM > tristate "Qualcomm Platform" > - depends on EXTCON && (ARCH_QCOM || COMPILE_TEST) > + depends on ARCH_QCOM || COMPILE_TEST > + depends on EXTCON || !EXTCON > depends on OF > default USB_DWC3 > help > -- > 2.17.1
diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig index 2b1494460d0c..6bd1a28c535f 100644 --- a/drivers/usb/dwc3/Kconfig +++ b/drivers/usb/dwc3/Kconfig @@ -115,7 +115,8 @@ config USB_DWC3_ST config USB_DWC3_QCOM tristate "Qualcomm Platform" - depends on EXTCON && (ARCH_QCOM || COMPILE_TEST) + depends on ARCH_QCOM || COMPILE_TEST + depends on EXTCON || !EXTCON depends on OF default USB_DWC3 help
Keep EXTCON support optional, since some platforms do not need it. Fixes: 3def4031b3e3 ("usb: dwc3: add EXTCON dependency for qcom") Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr> --- drivers/usb/dwc3/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)