From patchwork Thu Mar 27 16:10:07 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Stern X-Patchwork-Id: 14031274 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9791D1946C8 for ; Thu, 27 Mar 2025 16:10:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743091814; cv=none; b=Eitzzne1n5Y5CtB7KrPhFgAqP1YUNsPYK9gN4N3DSbVeisJOUMqyvvB92nCohd6x85d+ED9/PLe5ifL9PZu217hWh8SXtuy/aP5P0NzJU4dTr73vb1C5iNUOKi7B64fa5FXZOEQ096tOHgC9ShZpMN+YTwhwVqv8dELHEeU6gIs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743091814; c=relaxed/simple; bh=yRfsWSmO+wFLjQqhVPDHhzJGHPLVualTW3MOKQsQiAg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Lb+9Co3TlruhGjRVQLdFIawoNSwf4WCmVOjCiFjg5pxXO/X7xLGehy2zVhjeCcfmdExGUJJ28rCR44oXmykk3GlSl5PuXcLGh/A+ztAWNJvSrxrfCd00kZDTh699iKTsP3JCEGyq/yA4wwA01Jd/r1kBj/2QiR794WczpoUKIe0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rowland.harvard.edu; spf=fail smtp.mailfrom=g.harvard.edu; dkim=pass (2048-bit key) header.d=rowland.harvard.edu header.i=@rowland.harvard.edu header.b=T8U1s6Uj; arc=none smtp.client-ip=209.85.160.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rowland.harvard.edu Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=g.harvard.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rowland.harvard.edu header.i=@rowland.harvard.edu header.b="T8U1s6Uj" Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-4769aef457bso13258601cf.2 for ; Thu, 27 Mar 2025 09:10:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rowland.harvard.edu; s=google; t=1743091811; x=1743696611; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=n4aGtm3x4RnQEni/5CdY3X2v/FvubHlUYBJ6LerS9tM=; b=T8U1s6Ujtr9zTAwLS5tBTAuFJAyK+XjK+4j9NaXJxDQw8R0uPo4ebOtbOTzHbxR8Nr MDv8ZvPD9ApYenTASg4Z1tULbH/yz9Qal4DB7XUPdx1TIVXeR/OKEiIisgP2FDvTHovS b1BKUmza3sqqWpR0SnjfZvJljYGz2y8/5w7QPUieIdijZGLLTv7y190bKA0grPquPfI5 22ayKJj+iXd+g/XAcx1j1ow5dQLKJiKpmDbZd7tG+5y9rYAcE3vg6NDnPEzDzAAOUYdu hTKHEP+NoeU9WqJ1Jr8jgZLWZAUsc7EhzlERNQ8dAIR4Avla5rUnKYCbW5VBU4rqKcvH 6/SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743091811; x=1743696611; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=n4aGtm3x4RnQEni/5CdY3X2v/FvubHlUYBJ6LerS9tM=; b=GTU/zQ8TBVjChbr3bBuBXR4pC/qh+IUE2tS16Q+fXpGVtQ7qLOEwl1MCB5ktkt4/O0 ViPTW9AEEeE34PnYjWIwswbmUOQ+NM06C9xYjKM+CXuZzRfTP8nZlZS8YmgInBAvpuIj u8HGDc+MMCQyBkt26GFcNtGzcZUwIQXCekIU44LkA+s27qQSnC8mS2GzIu2Ch6YlR6eW vl9JrM/z07MTpYfFqKWEs702TFE3LXKlU8ue4bpymZ09Liz86GQAp8cCXFsUVrmLqV73 8EvMLiiQIYdLOAvL1mVrMN1QhQFWAW1NqtmuhBfFNA4OQwpv9xIm5+SBNTtGar4jDdNA Ozew== X-Forwarded-Encrypted: i=1; AJvYcCWvGzYUfWO0vSm+BmapCW2TAbNMfKJiT7go4Y5GWNN8zB5gAY/h3jUCMqmxHHexs2RYuofmMJyzkVE=@vger.kernel.org X-Gm-Message-State: AOJu0YyzsHUnxe6duxy4UowtoKXMk2fYwUso/CG8voHL1nxlt55mLRH2 pCbAI/O71pdZzc13R8XEOEXgK5Urt734MVbyKRVWRiBKx0Af7L0Pvroh+Si2+w== X-Gm-Gg: ASbGncsshTkTwIokplKGp5/zgyn0c8FBvsloZm5nt3ez6zf/SGuPVEsNi4mZsenblMv 6qdqCu5H7mn211EIPaPCyWLI+rcQzYHQz9ZJbfoHuEzUjKwTgXw4YqzulxjR5AUsQNRGS1NXbDD taGNq+nANOTWGHJ/Hp2Skq4mzXhLUx4foIjWBFypFeeKWitOnwL/vbLwAj0L3GZCZMW/QK73+e4 BEJ9R//OkNLDGXkbCyAvqJzKDRVyUAkMJsGaE5iqC09kcRU4DdqNMnzrnIYaYflauvoMkI4dyOR T//r+lU9DjVNRzO+3FBVg8g8AUIIVat2ZfYFyTymHekQvGNfxtr1KwkMPs+yJNyip9S0EZWVrX7 ZQza27rwMUe9qnXIJjgYaLCtG7BY054Up0aVVew== X-Google-Smtp-Source: AGHT+IHrXdhBKku0JlAnw5aFNc3noz3BV8vld9892T4Ikm1iTuBSdMQGuKLfD+Saf5C2J0tikiUE8A== X-Received: by 2002:a05:622a:2596:b0:476:9001:7898 with SMTP id d75a77b69052e-4776e116edcmr67799011cf.25.1743091810281; Thu, 27 Mar 2025 09:10:10 -0700 (PDT) Received: from rowland.harvard.edu (nat-65-112-8-24.harvard-secure.wrls.harvard.edu. [65.112.8.24]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4771d52010fsm85628191cf.61.2025.03.27.09.10.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Mar 2025 09:10:09 -0700 (PDT) Date: Thu, 27 Mar 2025 12:10:07 -0400 From: Alan Stern To: Mauro Carvalho Chehab Cc: Wolfram Sang , syzbot , gregkh@linuxfoundation.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: [PATCH v2 resend] media: dvb: usb: Fix WARNING in dib0700_i2c_xfer/usb_submit_urb Message-ID: References: <6bb3b80b-a808-4992-8666-535ed9a5c980@rowland.harvard.edu> <67e2fed5.050a0220.a7ebc.0053.GAE@google.com> <29db5fdc-13c9-45f0-9183-c80d637725c6@rowland.harvard.edu> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: The syzbot fuzzer reported a WARNING related to the dib0700 dvb-usb driver: usb 1-1: BOGUS control dir, pipe 80000f80 doesn't match bRequestType c0 WARNING: CPU: 1 PID: 5901 at drivers/usb/core/urb.c:413 usb_submit_urb+0x11d9/0x18c0 drivers/usb/core/urb.c:411 ... Call Trace: usb_start_wait_urb+0x113/0x520 drivers/usb/core/message.c:59 usb_internal_control_msg drivers/usb/core/message.c:103 [inline] usb_control_msg+0x2b1/0x4c0 drivers/usb/core/message.c:154 dib0700_ctrl_rd drivers/media/usb/dvb-usb/dib0700_core.c:95 [inline] dib0700_i2c_xfer_legacy drivers/media/usb/dvb-usb/dib0700_core.c:315 [inline] dib0700_i2c_xfer+0xc53/0x1060 drivers/media/usb/dvb-usb/dib0700_core.c:361 __i2c_transfer+0x866/0x2220 i2c_transfer+0x271/0x3b0 drivers/i2c/i2c-core-base.c:2315 i2cdev_ioctl_rdwr+0x452/0x710 drivers/i2c/i2c-dev.c:306 i2cdev_ioctl+0x759/0x9f0 drivers/i2c/i2c-dev.c:467 vfs_ioctl fs/ioctl.c:51 [inline] Evidently the fuzzer submitted an I2C transfer containing a length-0 read message. The dib0700 driver translated this more or less literally into a length-0 USB read request. But the USB protocol does not allow reads to have length 0; all length-0 transfers are considered to be writes. Hence the WARNING above. Fix the problem by adding the I2C_AQ_NO_ZERO_LEN_READ adapter quirk flag to all the USB I2C adapter devices managed by dvb-usb-i2c.c, following Wolfram Sang's suggestion. This tells the I2C core not to allow length-0 read messages. Reported-by: syzbot+c38e5e60d0041a99dbf5@syzkaller.appspotmail.com Tested-by: syzbot+c38e5e60d0041a99dbf5@syzkaller.appspotmail.com Suggested-by: Wolfram Sang Signed-off-by: Alan Stern Reviewed-by: Wolfram Sang Link: https://lore.kernel.org/linux-usb/67e1a1f5.050a0220.a7ebc.0029.GAE@google.com/ --- Resend to the media maintainer. v2: Move the static definition of the i2c_usb_quirks structure outside the dvb_usb_i2c_init() function. drivers/media/usb/dvb-usb/dvb-usb-i2c.c | 5 +++++ 1 file changed, 5 insertions(+) Index: usb-devel/drivers/media/usb/dvb-usb/dvb-usb-i2c.c =================================================================== --- usb-devel.orig/drivers/media/usb/dvb-usb/dvb-usb-i2c.c +++ usb-devel/drivers/media/usb/dvb-usb/dvb-usb-i2c.c @@ -8,6 +8,10 @@ */ #include "dvb-usb-common.h" +static const struct i2c_adapter_quirks i2c_usb_quirks = { + .flags = I2C_AQ_NO_ZERO_LEN_READ, +}; + int dvb_usb_i2c_init(struct dvb_usb_device *d) { int ret = 0; @@ -24,6 +28,7 @@ int dvb_usb_i2c_init(struct dvb_usb_devi strscpy(d->i2c_adap.name, d->desc->name, sizeof(d->i2c_adap.name)); d->i2c_adap.algo = d->props.i2c_algo; d->i2c_adap.algo_data = NULL; + d->i2c_adap.quirks = &i2c_usb_quirks; d->i2c_adap.dev.parent = &d->udev->dev; i2c_set_adapdata(&d->i2c_adap, d);