| Message ID | d0c5a04f-deee-4ebe-9b0b-dc5492564519@kili.mountain (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8018018d9c56473067e5358986ce0ee9ce56949f |
| Headers | show |
| Series | usb: dwc3: fix a test for error in dwc3_core_init() | expand |
On Thu, May 04, 2023 at 05:59:24PM +0300, Dan Carpenter wrote: > This was refactored recently and the "ret = " was accidentally deleted > so the errors aren't checked. > > Fixes: 1d72fab47656 ("USB: dwc3: refactor phy handling") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Thanks for catching this! Reviewed-by: Johan Hovold <johan+linaro@kernel.org> > --- > drivers/usb/dwc3/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > index 0beaab932e7d..7b2ce013cc5b 100644 > --- a/drivers/usb/dwc3/core.c > +++ b/drivers/usb/dwc3/core.c > @@ -1137,7 +1137,7 @@ static int dwc3_core_init(struct dwc3 *dwc) > > dwc3_set_incr_burst_type(dwc); > > - dwc3_phy_power_on(dwc); > + ret = dwc3_phy_power_on(dwc); > if (ret) > goto err_exit_phy; Johan
On Thu, May 04, 2023, Dan Carpenter wrote: > This was refactored recently and the "ret = " was accidentally deleted > so the errors aren't checked. > > Fixes: 1d72fab47656 ("USB: dwc3: refactor phy handling") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> > --- > drivers/usb/dwc3/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > index 0beaab932e7d..7b2ce013cc5b 100644 > --- a/drivers/usb/dwc3/core.c > +++ b/drivers/usb/dwc3/core.c > @@ -1137,7 +1137,7 @@ static int dwc3_core_init(struct dwc3 *dwc) > > dwc3_set_incr_burst_type(dwc); > > - dwc3_phy_power_on(dwc); > + ret = dwc3_phy_power_on(dwc); > if (ret) > goto err_exit_phy; > > -- > 2.39.2 > Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com> Thanks, Thinh
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index 0beaab932e7d..7b2ce013cc5b 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c @@ -1137,7 +1137,7 @@ static int dwc3_core_init(struct dwc3 *dwc) dwc3_set_incr_burst_type(dwc); - dwc3_phy_power_on(dwc); + ret = dwc3_phy_power_on(dwc); if (ret) goto err_exit_phy;
This was refactored recently and the "ret = " was accidentally deleted so the errors aren't checked. Fixes: 1d72fab47656 ("USB: dwc3: refactor phy handling") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- drivers/usb/dwc3/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)