diff mbox series

[1/2] usb: dwc2: gadget: Fix WkupAlert interrupt handler.

Message ID d1ac0cb745c83e9b1e698af63d4fc09e02061181.1540902331.git.arturp@synopsys.com (mailing list archive)
State New, archived
Headers show
Series usb: dwc2: gadget: Fix Service Interval support. | expand

Commit Message

Artur Petrosyan Oct. 30, 2018, 12:26 p.m. UTC 
According to the databook DCTL_RMTWKUPSIG bit
is defined in DCTL register not in DCFG.

Updated setting DCTL_RMTWKUPSIG bit to DCTL
register.

Signed-off-by: Artur Petrosyan <arturp@synopsys.com>
Signed-off-by: Minas Harutyunyan <hminas@synopsys.com>
---
 drivers/usb/dwc2/gadget.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Felipe Balbi Oct. 30, 2018, 12:33 p.m. UTC | #1 
Hi,

Artur Petrosyan <arthur.petrosyan@synopsys.com> writes:
> According to the databook DCTL_RMTWKUPSIG bit
> is defined in DCTL register not in DCFG.
>
> Updated setting DCTL_RMTWKUPSIG bit to DCTL
> register.
>

looks like this needs a Cc stable and Fixes tag. Care to add?
Artur Petrosyan Oct. 30, 2018, 2:13 p.m. UTC | #2 
Hi Balbi,

On 10/30/2018 16:34, Felipe Balbi wrote:
> 
> Hi,
> 
> Artur Petrosyan <arthur.petrosyan@synopsys.com> writes:
>> According to the databook DCTL_RMTWKUPSIG bit
>> is defined in DCTL register not in DCFG.
>>
>> Updated setting DCTL_RMTWKUPSIG bit to DCTL
>> register.
>>
> 
> looks like this needs a Cc stable and Fixes tag. Care to add?
> 
> 

I think, we don't need to add this patch to stable as this code is not 
included in any stable version. According Greg's mail ([GIT PULL] USB 
driver patches for 4.20-rc1) this code first appeared in 4.20-rc1.

I will add the Fixes tag to the patch and send it with version 2.

Regards,
Artur
diff mbox series

Patch

diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
index 2d6d2c8244de..6bd4054e894d 100644
--- a/drivers/usb/dwc2/gadget.c
+++ b/drivers/usb/dwc2/gadget.c
@@ -262,7 +262,7 @@  static void dwc2_gadget_wkup_alert_handler(struct dwc2_hsotg *hsotg)
 	if (gintsts2 & GINTSTS2_WKUP_ALERT_INT) {
 		dev_dbg(hsotg->dev, "%s: Wkup_Alert_Int\n", __func__);
 		dwc2_clear_bit(hsotg, GINTSTS2, GINTSTS2_WKUP_ALERT_INT);
-		dwc2_set_bit(hsotg, DCFG, DCTL_RMTWKUPSIG);
+		dwc2_set_bit(hsotg, DCTL, DCTL_RMTWKUPSIG);
 	}
 }