From patchwork Tue Apr 17 05:14:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 10344373 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5CABE601D7 for ; Tue, 17 Apr 2018 05:14:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5033D2899D for ; Tue, 17 Apr 2018 05:14:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 44CA7289A2; Tue, 17 Apr 2018 05:14:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D88782899D for ; Tue, 17 Apr 2018 05:14:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750988AbeDQFOa (ORCPT ); Tue, 17 Apr 2018 01:14:30 -0400 Received: from merlin.infradead.org ([205.233.59.134]:60920 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750738AbeDQFO3 (ORCPT ); Tue, 17 Apr 2018 01:14:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Date:Message-ID:Subject:From:Cc:To:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=HBMG5U0fvRXjgUzS//GVay+ZlFyGvfir73kKZd2xDLs=; b=E+uKnDgBfyA3+bvTNaQxMiYuWt houhH0HoeAMlcyMBwA9aV3cW9dL2M7LIwNnLLt5xl8Jry4l/+UgwXZdM+zj18Syd7ZSnMokg3dbBZ wx5WoXhZjB88VtBeQZzbwVjWag+kzHmeIu6OiOyarzp1QhdhbLWaGqsiNZz7aD1PA/v7vkJRLCbAN FP4XFsi38eXe1ZGPC9/JJ13A5rhpUAReP+3Vtp/caADvaRKK9KszGRCeexTKWGHRgtyFWhslC0GEg xiwuUA8WPvdEmBb44OKJolyGQorIH+7c+wOMFx1bZfaTg2tAEo3NNe1HO1rExrjTIPfvawG38WvjH 2k94oWcA==; Received: from static-50-53-52-16.bvtn.or.frontiernet.net ([50.53.52.16] helo=midway.dunlab) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1f8IwV-0007kf-NJ; Tue, 17 Apr 2018 05:14:12 +0000 To: USB list , LKML Cc: Fengguang Wu , MyungJoo Ham , Chanwoo Choi , Hans de Goede , Greg Kroah-Hartman , Andy Shevchenko , Heikki Krogerus From: Randy Dunlap Subject: [PATCH] usb: always build usb/common/ targets; fixes extcon-axp288 build error Message-ID: Date: Mon, 16 Apr 2018 22:14:07 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 Content-Language: en-US Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Randy Dunlap The extcon-axp288 driver selects USB_ROLE_SWITCH, but the USB Makefile does not currently build drivers/usb/common/ (where USB_ROLE_SWITCH code is) unless USB_COMMON is set, so modify the USB Makefile to always descend into drivers/usb/common/ to build its configured targets. Fixes these build errors: ERROR: "usb_role_switch_get" [drivers/extcon/extcon-axp288.ko] undefined! ERROR: "usb_role_switch_set_role" [drivers/extcon/extcon-axp288.ko] undefined! ERROR: "usb_role_switch_get_role" [drivers/extcon/extcon-axp288.ko] undefined! ERROR: "usb_role_switch_put" [drivers/extcon/extcon-axp288.ko] undefined! An alternative patch would be to select USB_COMMON in the EXTCON_AXP288 driver Kconfig entry, but this would build more code in drivers/usb/common/ than is necessary. Reported-by: Fengguang Wu Signed-off-by: Randy Dunlap Cc: MyungJoo Ham Cc: Chanwoo Choi Cc: Hans de Goede Cc: Greg Kroah-Hartman Cc: Andy Shevchenko Cc: Heikki Krogerus Cc: linux-usb@vger.kernel.org --- drivers/usb/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- lnx-417-rc1.orig/drivers/usb/Makefile +++ lnx-417-rc1/drivers/usb/Makefile @@ -60,7 +60,7 @@ obj-$(CONFIG_USB_CHIPIDEA) += chipidea/ obj-$(CONFIG_USB_RENESAS_USBHS) += renesas_usbhs/ obj-$(CONFIG_USB_GADGET) += gadget/ -obj-$(CONFIG_USB_COMMON) += common/ +obj-y += common/ obj-$(CONFIG_USBIP_CORE) += usbip/