| Message ID | deab9696fc4000499470e7ccbca7c36fca17bd4e.1668458274.git.christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 202f785b1863d8feef53f6489afd9abcb744e7bf |
| Headers | show |
| Series | usb: fotg210-udc: Remove a useless assignment | expand |
On Mon, Nov 14, 2022 at 9:38 PM Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote: > There is no need to use an intermediate array for these memory allocations, > so, axe it. > > While at it, turn a '== NULL' into a shorter '!' when testing memory > allocation failure. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Fair enough! Reviewed-by: Linus Walleij <linus.walleij@linaro.org> I have sent some other cleanups to this code only yesterday, so they might collide and they you might have to rebase. Yours, Linus Walleij
On Tue, Nov 15, 2022 at 10:42:02PM +0100, Linus Walleij wrote: > On Mon, Nov 14, 2022 at 9:38 PM Christophe JAILLET > <christophe.jaillet@wanadoo.fr> wrote: > > > There is no need to use an intermediate array for these memory allocations, > > so, axe it. > > > > While at it, turn a '== NULL' into a shorter '!' when testing memory > > allocation failure. > > > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > > Fair enough! > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > I have sent some other cleanups to this code only > yesterday, so they might collide and they you might have > to rebase. I fixed it up, no need to resend. thanks, greg k-h
diff --git a/drivers/usb/fotg210/fotg210-udc.c b/drivers/usb/fotg210/fotg210-udc.c index 3c357ce42d3b..52b1d69843dd 100644 --- a/drivers/usb/fotg210/fotg210-udc.c +++ b/drivers/usb/fotg210/fotg210-udc.c @@ -1090,7 +1090,6 @@ int fotg210_udc_probe(struct platform_device *pdev) { struct resource *res, *ires; struct fotg210_udc *fotg210 = NULL; - struct fotg210_ep *_ep[FOTG210_MAX_NUM_EP]; int ret = 0; int i; @@ -1114,10 +1113,9 @@ int fotg210_udc_probe(struct platform_device *pdev) goto err; for (i = 0; i < FOTG210_MAX_NUM_EP; i++) { - _ep[i] = kzalloc(sizeof(struct fotg210_ep), GFP_KERNEL); - if (_ep[i] == NULL) + fotg210->ep[i] = kzalloc(sizeof(struct fotg210_ep), GFP_KERNEL); + if (!fotg210->ep[i]) goto err_alloc; - fotg210->ep[i] = _ep[i]; } fotg210->reg = ioremap(res->start, resource_size(res));
There is no need to use an intermediate array for these memory allocations, so, axe it. While at it, turn a '== NULL' into a shorter '!' when testing memory allocation failure. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/usb/fotg210/fotg210-udc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)