diff mbox series

[v6,2/3] usb: dwc3: Add disabling of start_transfer failure quirk

Message ID ead428b935b52df74dbe386185e1b8298b0135b4.1541707248.git.thinhn@synopsys.com (mailing list archive)
State Superseded
Headers show
Series usb: dwc3: Workaround isoc start_transfer failure | expand

Commit Message

Thinh Nguyen Nov. 8, 2018, 8:06 p.m. UTC
DWC_usb31 peripheral v1.70a-ea06 and prior needs a SW workaround for
isoc START TRANSFER command failure. However, some affected versions may
have RTL patches to fix this without a SW workaround. Add this quirk to
disable the SW workaround when it is not needed.

Synopsys STAR 9001202023: Wrong microframe number for isochronous IN
endpoints.

Signed-off-by: Thinh Nguyen <thinhn@synopsys.com>
---
 Documentation/devicetree/bindings/usb/dwc3.txt | 3 +++
 1 file changed, 3 insertions(+)

Comments

Rob Herring (Arm) Nov. 11, 2018, 10:32 p.m. UTC | #1
On Thu, Nov 08, 2018 at 12:06:57PM -0800, Thinh Nguyen wrote:
> DWC_usb31 peripheral v1.70a-ea06 and prior needs a SW workaround for
> isoc START TRANSFER command failure. However, some affected versions may
> have RTL patches to fix this without a SW workaround. Add this quirk to
> disable the SW workaround when it is not needed.
> 
> Synopsys STAR 9001202023: Wrong microframe number for isochronous IN
> endpoints.
> 
> Signed-off-by: Thinh Nguyen <thinhn@synopsys.com>
> ---
>  Documentation/devicetree/bindings/usb/dwc3.txt | 3 +++
>  1 file changed, 3 insertions(+)

Acked-by: Rob Herring <robh@kernel.org>
Felipe Balbi Nov. 14, 2018, 11:41 a.m. UTC | #2
Thinh Nguyen <thinh.nguyen@synopsys.com> writes:

> DWC_usb31 peripheral v1.70a-ea06 and prior needs a SW workaround for
> isoc START TRANSFER command failure. However, some affected versions may
> have RTL patches to fix this without a SW workaround. Add this quirk to
> disable the SW workaround when it is not needed.
>
> Synopsys STAR 9001202023: Wrong microframe number for isochronous IN
> endpoints.
>
> Signed-off-by: Thinh Nguyen <thinhn@synopsys.com>

unfortunately, does't apply to testing/next. Could you rebase??

checking file Documentation/devicetree/bindings/usb/dwc3.txt
Hunk #1 FAILED at 37.
1 out of 1 hunk FAILED

(patch 1/3 is applied, though)
Thinh Nguyen Nov. 15, 2018, 7 a.m. UTC | #3
Hi,

On 11/14/2018 3:41 AM, Felipe Balbi wrote:
> Thinh Nguyen <thinh.nguyen@synopsys.com> writes:
>
>> DWC_usb31 peripheral v1.70a-ea06 and prior needs a SW workaround for
>> isoc START TRANSFER command failure. However, some affected versions may
>> have RTL patches to fix this without a SW workaround. Add this quirk to
>> disable the SW workaround when it is not needed.
>>
>> Synopsys STAR 9001202023: Wrong microframe number for isochronous IN
>> endpoints.
>>
>> Signed-off-by: Thinh Nguyen <thinhn@synopsys.com>
> unfortunately, does't apply to testing/next. Could you rebase??
>
Done.

Thanks,
Thinh
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt
index 636630fb92d7..fc64db0a7a0a 100644
--- a/Documentation/devicetree/bindings/usb/dwc3.txt
+++ b/Documentation/devicetree/bindings/usb/dwc3.txt
@@ -37,6 +37,9 @@  Optional properties:
  - phy-names: from the *Generic PHY* bindings; supported names are "usb2-phy"
 	or "usb3-phy".
  - resets: a single pair of phandle and reset specifier
+ - snps,dis-start-transfer-quirk: when set, disable isoc START TRANSFER command
+			failure SW work-around for DWC_usb31 version 1.70a-ea06
+			and prior.
  - snps,usb3_lpm_capable: determines if platform is USB3 LPM capable
  - snps,disable_scramble_quirk: true when SW should disable data scrambling.
 	Only really useful for FPGA builds.