diff mbox series

Re[2]: [PATCH v2] fix: add XHCI_SPURIOUS_SUCCESS to ASM1042 despite being a V0.96 controller

Message ID emf600f901-91ef-4aea-931e-9f6fc5f42c86@689b6561.com (mailing list archive)
State Superseded
Headers show
Series Re[2]: [PATCH v2] fix: add XHCI_SPURIOUS_SUCCESS to ASM1042 despite being a V0.96 controller | expand

Commit Message

Jens Glathe Sept. 25, 2022, 10:02 a.m. UTC 
Yep, found it. Them pesky editors...

thanks,

Jens Glathe

---

From 8d6e467569118b83a4622edf09768ba20aef5086 Mon Sep 17 00:00:00 2001
From: Jens Glathe <jens.glathe@oldschoolsolutions.biz>
Date: Sun, 28 Aug 2022 16:23:41 +0200
Subject: [PATCH] fix: add XHCI_SPURIOUS_SUCCESS to ASM1042 despite being 
a
  V0.96 controller

only if it reports as a V0.96 XHCI controller. Appears to fix the errors
"xhci_hcd <address>; ERROR Transfer event TRB DMA ptr not part of
current TD ep_index 2 comp_code 13" that appear spuriously (or pretty
often) when using a r8152 USB3 ethernet adapter with integrated hub.

Signed-off-by: Jens Glathe <jens.glathe@oldschoolsolutions.biz>
---
  drivers/usb/host/xhci-pci.c | 6 +++++-
  1 file changed, 5 insertions(+), 1 deletion(-)

          xhci->quirks |= XHCI_TRUST_TX_LENGTH;
--
2.25.1

---

replaced spaces with tabs


------ Originalnachricht ------
Von "Greg KH" <gregkh@linuxfoundation.org>
An "Jens Glathe" <jens.glathe@oldschoolsolutions.biz>
Cc mathias.nyman@intel.com; linux-usb@vger.kernel.org; 
linux-kernel@vger.kernel.org
Datum 25.09.2022 10:07:32
Betreff Re: [PATCH v2] fix: add XHCI_SPURIOUS_SUCCESS to ASM1042 despite 
being a V0.96 controller

>On Sun, Sep 25, 2022 at 07:50:48AM +0000, Jens Glathe wrote:
>>Hi there,
>>
>>I'm a bit at a loss here. This is a three-line change, and I get loads of
>>warnings regarding "please, no spaces at beginning of lines".
>
>Yes, that's not allowed, kernel development uses tabs, not spaces.  Fix
>that up and resend and all should be good.
>
>thanks,
>
>greg k-h

Comments

Greg KH Sept. 25, 2022, 10:07 a.m. UTC | #1 
On Sun, Sep 25, 2022 at 10:02:53AM +0000, Jens Glathe wrote:
> Yep, found it. Them pesky editors...
> 
> thanks,
> 
> Jens Glathe
> 
> ---
> 
> > From 8d6e467569118b83a4622edf09768ba20aef5086 Mon Sep 17 00:00:00 2001
> From: Jens Glathe <jens.glathe@oldschoolsolutions.biz>
> Date: Sun, 28 Aug 2022 16:23:41 +0200
> Subject: [PATCH] fix: add XHCI_SPURIOUS_SUCCESS to ASM1042 despite being a
>  V0.96 controller
> 
> only if it reports as a V0.96 XHCI controller. Appears to fix the errors
> "xhci_hcd <address>; ERROR Transfer event TRB DMA ptr not part of
> current TD ep_index 2 comp_code 13" that appear spuriously (or pretty
> often) when using a r8152 USB3 ethernet adapter with integrated hub.
> 
> Signed-off-by: Jens Glathe <jens.glathe@oldschoolsolutions.biz>
> ---
>  drivers/usb/host/xhci-pci.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> index dce6c0ec8d34..d1b8e7148dd1 100644
> --- a/drivers/usb/host/xhci-pci.c
> +++ b/drivers/usb/host/xhci-pci.c
> @@ -306,8 +306,12 @@ static void xhci_pci_quirks(struct device *dev, struct
> xhci_hcd *xhci)
>      }
> 
>      if (pdev->vendor == PCI_VENDOR_ID_ASMEDIA &&
> -        pdev->device == PCI_DEVICE_ID_ASMEDIA_1042_XHCI)
> +        pdev->device == PCI_DEVICE_ID_ASMEDIA_1042_XHCI) {
> +        /* try to tame the ASMedia 1042 controller which is 0.96 */
> +        if (xhci->hci_version == 0x96)
> +            xhci->quirks |= XHCI_SPURIOUS_SUCCESS;
>          xhci->quirks |= XHCI_BROKEN_STREAMS;
> +    }
>      if (pdev->vendor == PCI_VENDOR_ID_ASMEDIA &&
>          pdev->device == PCI_DEVICE_ID_ASMEDIA_1042A_XHCI) {
>          xhci->quirks |= XHCI_TRUST_TX_LENGTH;
> --
> 2.25.1
> 
> ---
> 
> replaced spaces with tabs


Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch is malformed (tabs converted to spaces, linewrapped, etc.)
  and can not be applied.  Please read the file,
  Documentation/email-clients.txt in order to fix this.

- Your patch was attached, please place it inline so that it can be
  applied directly from the email message itself.

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/SubmittingPatches for what needs to be done
  here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot
diff mbox series

Patch

diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index dce6c0ec8d34..d1b8e7148dd1 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -306,8 +306,12 @@  static void xhci_pci_quirks(struct device *dev, 
struct xhci_hcd *xhci)
      }

      if (pdev->vendor == PCI_VENDOR_ID_ASMEDIA &&
-        pdev->device == PCI_DEVICE_ID_ASMEDIA_1042_XHCI)
+        pdev->device == PCI_DEVICE_ID_ASMEDIA_1042_XHCI) {
+        /* try to tame the ASMedia 1042 controller which is 0.96 */
+        if (xhci->hci_version == 0x96)
+            xhci->quirks |= XHCI_SPURIOUS_SUCCESS;
          xhci->quirks |= XHCI_BROKEN_STREAMS;
+    }
      if (pdev->vendor == PCI_VENDOR_ID_ASMEDIA &&
          pdev->device == PCI_DEVICE_ID_ASMEDIA_1042A_XHCI) {