| Message ID | fc692345c08a0c42e7246312d1d5fc54a8d5d524.1544618606.git.hminas@synopsys.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 87b6d2c56825c3119a0e64cc208ae6d795810a2e |
| Headers | show |
| Series | usb: dwc2: gadget: Fix Remote Wakeup interrupt bit clearing | expand |
Hi Greg, Filipe, On 12/12/2018 4:44 PM, Minas Harutyunyan wrote: > To clear GINTSTS2_WKUP_ALERT_INT bit in GINTSTS2 register > require to write 1. This bit is implemented as "Write to clear". > > Fixes: 187c5298a122 ("usb: dwc2: gadget: Add handler for WkupAlert > interrupt") > > Signed-off-by: Minas Harutyunyan <hminas@synopsys.com> > --- > drivers/usb/dwc2/gadget.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c > index 68ad75a7460d..55ef3cc2701b 100644 > --- a/drivers/usb/dwc2/gadget.c > +++ b/drivers/usb/dwc2/gadget.c > @@ -261,7 +261,7 @@ static void dwc2_gadget_wkup_alert_handler(struct dwc2_hsotg *hsotg) > > if (gintsts2 & GINTSTS2_WKUP_ALERT_INT) { > dev_dbg(hsotg->dev, "%s: Wkup_Alert_Int\n", __func__); > - dwc2_clear_bit(hsotg, GINTSTS2, GINTSTS2_WKUP_ALERT_INT); > + dwc2_set_bit(hsotg, GINTSTS2, GINTSTS2_WKUP_ALERT_INT); > dwc2_set_bit(hsotg, DCTL, DCTL_RMTWKUPSIG); > } > } > Sorry for last minute fix of this stupid bug. Please get this commit together with "usb: dwc2: gadget: Fix WkupAlert interrupt handler." Thanks, Minas
Hi, Minas Harutyunyan <minas.harutyunyan@synopsys.com> writes: > Hi Greg, Filipe, > > On 12/12/2018 4:44 PM, Minas Harutyunyan wrote: >> To clear GINTSTS2_WKUP_ALERT_INT bit in GINTSTS2 register >> require to write 1. This bit is implemented as "Write to clear". >> >> Fixes: 187c5298a122 ("usb: dwc2: gadget: Add handler for WkupAlert >> interrupt") >> >> Signed-off-by: Minas Harutyunyan <hminas@synopsys.com> >> --- >> drivers/usb/dwc2/gadget.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c >> index 68ad75a7460d..55ef3cc2701b 100644 >> --- a/drivers/usb/dwc2/gadget.c >> +++ b/drivers/usb/dwc2/gadget.c >> @@ -261,7 +261,7 @@ static void dwc2_gadget_wkup_alert_handler(struct dwc2_hsotg *hsotg) >> >> if (gintsts2 & GINTSTS2_WKUP_ALERT_INT) { >> dev_dbg(hsotg->dev, "%s: Wkup_Alert_Int\n", __func__); >> - dwc2_clear_bit(hsotg, GINTSTS2, GINTSTS2_WKUP_ALERT_INT); >> + dwc2_set_bit(hsotg, GINTSTS2, GINTSTS2_WKUP_ALERT_INT); >> dwc2_set_bit(hsotg, DCTL, DCTL_RMTWKUPSIG); >> } >> } >> > > Sorry for last minute fix of this stupid bug. > Please get this commit together with "usb: dwc2: gadget: Fix WkupAlert > interrupt handler." And where is that?
Hi Filipe, On 1/14/2019 12:15 PM, Felipe Balbi wrote: > > Hi, > > Minas Harutyunyan <minas.harutyunyan@synopsys.com> writes: >> Hi Greg, Filipe, >> >> On 12/12/2018 4:44 PM, Minas Harutyunyan wrote: >>> To clear GINTSTS2_WKUP_ALERT_INT bit in GINTSTS2 register >>> require to write 1. This bit is implemented as "Write to clear". >>> >>> Fixes: 187c5298a122 ("usb: dwc2: gadget: Add handler for WkupAlert >>> interrupt") >>> >>> Signed-off-by: Minas Harutyunyan <hminas@synopsys.com> >>> --- >>> drivers/usb/dwc2/gadget.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c >>> index 68ad75a7460d..55ef3cc2701b 100644 >>> --- a/drivers/usb/dwc2/gadget.c >>> +++ b/drivers/usb/dwc2/gadget.c >>> @@ -261,7 +261,7 @@ static void dwc2_gadget_wkup_alert_handler(struct dwc2_hsotg *hsotg) >>> >>> if (gintsts2 & GINTSTS2_WKUP_ALERT_INT) { >>> dev_dbg(hsotg->dev, "%s: Wkup_Alert_Int\n", __func__); >>> - dwc2_clear_bit(hsotg, GINTSTS2, GINTSTS2_WKUP_ALERT_INT); >>> + dwc2_set_bit(hsotg, GINTSTS2, GINTSTS2_WKUP_ALERT_INT); >>> dwc2_set_bit(hsotg, DCTL, DCTL_RMTWKUPSIG); >>> } >>> } >>> >> >> Sorry for last minute fix of this stupid bug. >> Please get this commit together with "usb: dwc2: gadget: Fix WkupAlert >> interrupt handler." > > And where is that? > You mean where is "usb: dwc2: gadget: Fix WkupAlert interrupt handler." commit? If yes, then that commit id is d64bc8ee92856e39b3150d93e244ca8239ae6ada Thanks, Minas
Hi, Minas Harutyunyan <minas.harutyunyan@synopsys.com> writes: >>>> diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c >>>> index 68ad75a7460d..55ef3cc2701b 100644 >>>> --- a/drivers/usb/dwc2/gadget.c >>>> +++ b/drivers/usb/dwc2/gadget.c >>>> @@ -261,7 +261,7 @@ static void dwc2_gadget_wkup_alert_handler(struct dwc2_hsotg *hsotg) >>>> >>>> if (gintsts2 & GINTSTS2_WKUP_ALERT_INT) { >>>> dev_dbg(hsotg->dev, "%s: Wkup_Alert_Int\n", __func__); >>>> - dwc2_clear_bit(hsotg, GINTSTS2, GINTSTS2_WKUP_ALERT_INT); >>>> + dwc2_set_bit(hsotg, GINTSTS2, GINTSTS2_WKUP_ALERT_INT); >>>> dwc2_set_bit(hsotg, DCTL, DCTL_RMTWKUPSIG); >>>> } >>>> } >>>> >>> >>> Sorry for last minute fix of this stupid bug. >>> Please get this commit together with "usb: dwc2: gadget: Fix WkupAlert >>> interrupt handler." >> >> And where is that? >> > You mean where is "usb: dwc2: gadget: Fix WkupAlert interrupt handler." > commit? If yes, then that commit id is > d64bc8ee92856e39b3150d93e244ca8239ae6ada oh, already upstream. Good. Thanks
diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index 68ad75a7460d..55ef3cc2701b 100644 --- a/drivers/usb/dwc2/gadget.c +++ b/drivers/usb/dwc2/gadget.c @@ -261,7 +261,7 @@ static void dwc2_gadget_wkup_alert_handler(struct dwc2_hsotg *hsotg) if (gintsts2 & GINTSTS2_WKUP_ALERT_INT) { dev_dbg(hsotg->dev, "%s: Wkup_Alert_Int\n", __func__); - dwc2_clear_bit(hsotg, GINTSTS2, GINTSTS2_WKUP_ALERT_INT); + dwc2_set_bit(hsotg, GINTSTS2, GINTSTS2_WKUP_ALERT_INT); dwc2_set_bit(hsotg, DCTL, DCTL_RMTWKUPSIG); } }
To clear GINTSTS2_WKUP_ALERT_INT bit in GINTSTS2 register require to write 1. This bit is implemented as "Write to clear". Fixes: 187c5298a122 ("usb: dwc2: gadget: Add handler for WkupAlert interrupt") Signed-off-by: Minas Harutyunyan <hminas@synopsys.com> --- drivers/usb/dwc2/gadget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)