diff mbox

[v3] storage: Widen bcdDevice range for SanDisk SDDR-31 quirk

Message ID trinity-016d8d91-9827-4c7d-8fb0-035cba2a453b-1528656849538@3c-app-mailcom-lxa07 (mailing list archive)
State New, archived
Headers show

Commit Message

Mark Knibbs June 10, 2018, 6:54 p.m. UTC
When I re-sent the patch with tabs I accidentally left the new maximum
bcdDevice at 0x00ff. Sorry! Hopefully this is finally OK.


The SanDisk SDDR-31 needs the US_FL_FIX_CAPACITY quirk. Previously that
was only applied for bcdDevice 0x0009, but later firmware which reports
bcdDevice 0x0022 needs it too.

Signed-off-by: Mark Knibbs <mark_k@iname.com>
---
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Greg KH June 11, 2018, 7:08 a.m. UTC | #1
On Sun, Jun 10, 2018 at 08:54:09PM +0200, Mark Knibbs wrote:
> When I re-sent the patch with tabs I accidentally left the new maximum
> bcdDevice at 0x00ff. Sorry! Hopefully this is finally OK.

This should not be in the change log text, please remove it.

> 
> 
> The SanDisk SDDR-31 needs the US_FL_FIX_CAPACITY quirk. Previously that
> was only applied for bcdDevice 0x0009, but later firmware which reports
> bcdDevice 0x0022 needs it too.
> 
> Signed-off-by: Mark Knibbs <mark_k@iname.com>
> ---
> diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
> index 747d3a9..dfcceaf 100644

Below the --- line you should put what changed for each version of the
patch, so we have an idea of what to look for when reviewing it.

> --- a/drivers/usb/storage/unusual_devs.h
> +++ b/drivers/usb/storage/unusual_devs.h
> @@ -1044,7 +1044,7 @@ UNUSUAL_DEV(  0x0781, 0x0001, 0x0200, 0x0200,
>  		USB_SC_SCSI, USB_PR_CB, NULL,
>  		US_FL_SINGLE_LUN ),

Tabs all worked fine here.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
index 747d3a9..dfcceaf 100644
--- a/drivers/usb/storage/unusual_devs.h
+++ b/drivers/usb/storage/unusual_devs.h
@@ -1044,7 +1044,7 @@  UNUSUAL_DEV(  0x0781, 0x0001, 0x0200, 0x0200,
 		USB_SC_SCSI, USB_PR_CB, NULL,
 		US_FL_SINGLE_LUN ),
 
-UNUSUAL_DEV(  0x0781, 0x0002, 0x0009, 0x0009,
+UNUSUAL_DEV(  0x0781, 0x0002, 0x0000, 0x0022,
 		"SanDisk Corporation",
 		"ImageMate CompactFlash USB",
 		USB_SC_DEVICE, USB_PR_DEVICE, NULL,