diff mbox

[v2] storage: Widen bcdDevice range for SanDisk SDDR-31 quirk

Message ID trinity-bda6e5c1-a004-4718-806b-f2cb43637291-1528401285812@3c-app-mailcom-lxa16 (mailing list archive)
State New, archived
Headers show

Commit Message

Mark Knibbs June 7, 2018, 7:54 p.m. UTC
The SanDisk SDDR-31 needs the US_FL_FIX_CAPACITY quirk. Previously that
was only applied for bcdDevice 0x0009, but later firmware which reports
bcdDevice 0x0022 needs it too.

Signed-off-by: Mark Knibbs <mark_k@iname.com>
---
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Greg Kroah-Hartman June 7, 2018, 8:23 p.m. UTC | #1
On Thu, Jun 07, 2018 at 09:54:45PM +0200, Mark Knibbs wrote:
> The SanDisk SDDR-31 needs the US_FL_FIX_CAPACITY quirk. Previously that
> was only applied for bcdDevice 0x0009, but later firmware which reports
> bcdDevice 0x0022 needs it too.
> 
> Signed-off-by: Mark Knibbs <mark_k@iname.com>
> ---
> diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
> index 747d3a9..dfcceaf 100644
> --- a/drivers/usb/storage/unusual_devs.h
> +++ b/drivers/usb/storage/unusual_devs.h
> @@ -1044,7 +1044,7 @@ UNUSUAL_DEV(  0x0781, 0x0001, 0x0200, 0x0200,
>                 USB_SC_SCSI, USB_PR_CB, NULL,
>                 US_FL_SINGLE_LUN ),
>  
> -UNUSUAL_DEV(  0x0781, 0x0002, 0x0009, 0x0009,
> +UNUSUAL_DEV(  0x0781, 0x0002, 0x0000, 0x0022,
>                 "SanDisk Corporation",
>                 "ImageMate CompactFlash USB",
>                 USB_SC_DEVICE, USB_PR_DEVICE, NULL,

The tabs all got converted to spaces so this patch can not be applied :(

Please fix up and resend.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Alan Stern June 7, 2018, 8:23 p.m. UTC | #2
On Thu, 7 Jun 2018, Mark Knibbs wrote:

> The SanDisk SDDR-31 needs the US_FL_FIX_CAPACITY quirk. Previously that
> was only applied for bcdDevice 0x0009, but later firmware which reports
> bcdDevice 0x0022 needs it too.
> 
> Signed-off-by: Mark Knibbs <mark_k@iname.com>
> ---
> diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
> index 747d3a9..dfcceaf 100644
> --- a/drivers/usb/storage/unusual_devs.h
> +++ b/drivers/usb/storage/unusual_devs.h
> @@ -1044,7 +1044,7 @@ UNUSUAL_DEV(  0x0781, 0x0001, 0x0200, 0x0200,
>                 USB_SC_SCSI, USB_PR_CB, NULL,
>                 US_FL_SINGLE_LUN ),
>  
> -UNUSUAL_DEV(  0x0781, 0x0002, 0x0009, 0x0009,
> +UNUSUAL_DEV(  0x0781, 0x0002, 0x0000, 0x0022,
>                 "SanDisk Corporation",
>                 "ImageMate CompactFlash USB",
>                 USB_SC_DEVICE, USB_PR_DEVICE, NULL,

Acked-by: Alan Stern <stern@rowland.harvard.edu>

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
index 747d3a9..dfcceaf 100644
--- a/drivers/usb/storage/unusual_devs.h
+++ b/drivers/usb/storage/unusual_devs.h
@@ -1044,7 +1044,7 @@  UNUSUAL_DEV(  0x0781, 0x0001, 0x0200, 0x0200,
                USB_SC_SCSI, USB_PR_CB, NULL,
                US_FL_SINGLE_LUN ),
 
-UNUSUAL_DEV(  0x0781, 0x0002, 0x0009, 0x0009,
+UNUSUAL_DEV(  0x0781, 0x0002, 0x0000, 0x0022,
                "SanDisk Corporation",
                "ImageMate CompactFlash USB",
                USB_SC_DEVICE, USB_PR_DEVICE, NULL,