From patchwork Sun Apr 14 10:26:11 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10899731 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 64A1017E1 for ; Sun, 14 Apr 2019 10:26:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4AD0B2857D for ; Sun, 14 Apr 2019 10:26:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3F10728B35; Sun, 14 Apr 2019 10:26:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2039B28554 for ; Sun, 14 Apr 2019 10:26:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726621AbfDNK0f (ORCPT ); Sun, 14 Apr 2019 06:26:35 -0400 Received: from sauhun.de ([88.99.104.3]:32872 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725730AbfDNK0f (ORCPT ); Sun, 14 Apr 2019 06:26:35 -0400 Received: from localhost (p5486CDCF.dip0.t-ipconnect.de [84.134.205.207]) by pokefinder.org (Postfix) with ESMTPSA id B91A32CF687; Sun, 14 Apr 2019 12:26:32 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, Wolfram Sang Subject: [PATCH 00/16] watchdog: refactor init_timeout and update users Date: Sun, 14 Apr 2019 12:26:11 +0200 Message-Id: <20190414102627.5564-1-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.11.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When trying to add DT support to the DA9063 WDT, I didn't want to add yet another error message when watchdog_init_timeout fails. The core could do this with more detail, and also much more consistent. So, I refactored this routine and removed error strings from its callers. Note that DA9063 support is not added here because I still need to think about another issue. But this series has been tested using the renesas_wdt driver on a Renesas Salvator-XS board (R-Car M3N) and build bot is happy, too. Looking forward to comments. Thanks, Wolfram Wolfram Sang (16): watchdog: refactor watchdog_init_timeout watchdog: add error messages when initializing timeout fails watchdog: cadence_wdt: drop warning after calling watchdog_init_timeout watchdog: cadence_wdt: still probe if user supplied timeout is invalid watchdog: ebc-c384_wdt: drop warning after calling watchdog_init_timeout watchdog: hpwdt: drop warning after calling watchdog_init_timeout watchdog: i6300esb: drop warning after calling watchdog_init_timeout watchdog: imx_sc_wdt: drop warning after calling watchdog_init_timeout watchdog: ni903x_wdt: drop warning after calling watchdog_init_timeout watchdog: nic7018_wdt: drop warning after calling watchdog_init_timeout watchdog: renesas_wdt: drop warning after calling watchdog_init_timeout watchdog: sp5100_tco: drop warning after calling watchdog_init_timeout watchdog: st_lpc_wdt: drop warning after calling watchdog_init_timeout watchdog: stm32_iwdg: drop warning after calling watchdog_init_timeout watchdog: xen_wdt: drop warning after calling watchdog_init_timeout watchdog: ziirave_wdt: drop warning after calling watchdog_init_timeout drivers/watchdog/cadence_wdt.c | 7 +------ drivers/watchdog/ebc-c384_wdt.c | 5 +---- drivers/watchdog/hpwdt.c | 3 +-- drivers/watchdog/i6300esb.c | 5 +---- drivers/watchdog/imx_sc_wdt.c | 5 +---- drivers/watchdog/ni903x_wdt.c | 4 +--- drivers/watchdog/nic7018_wdt.c | 5 +---- drivers/watchdog/renesas_wdt.c | 4 +--- drivers/watchdog/sp5100_tco.c | 4 +--- drivers/watchdog/st_lpc_wdt.c | 4 +--- drivers/watchdog/stm32_iwdg.c | 6 +----- drivers/watchdog/watchdog_core.c | 39 ++++++++++++++++++++++++--------------- drivers/watchdog/xen_wdt.c | 4 +--- drivers/watchdog/ziirave_wdt.c | 6 +----- 14 files changed, 37 insertions(+), 64 deletions(-) Reviewed-by: Guenter Roeck