mbox series

[v4,0/4] support watchdog with longer timeout period

Message ID 20200504141427.17685-1-michaelsh@mellanox.com (mailing list archive)
Headers show
Series support watchdog with longer timeout period | expand

Message

Michael Shych May 4, 2020, 2:14 p.m. UTC
From: Michael Shych <michaelsh@mellanox.com>

This patchset adds support of extended new watchdog type 3 of Mellanox
Ethernet and Infiniband switch systems.
This type of watchdog can have a timeout period longer than 255 or 32 sec.
as it was before.

Michael Shych (4):
  platform_data/mlxreg: support new watchdog type with longer timeout
    period
  platform/x86: mlx-platform: support new watchdog type with longer
    timeout
  watchdog: mlx-wdt: support new watchdog type with longer timeout
    period
  docs: watchdog: mlx-wdt: Add description of new watchdog type 3

 Documentation/watchdog/mlx-wdt.rst   |  10 ++++
 drivers/platform/x86/mlx-platform.c  | 106 ++++++++++++++++++++++++++++++
 drivers/watchdog/mlx_wdt.c           |  73 ++++++++++++++++++++----
 include/linux/platform_data/mlxreg.h |   5 +-
 4 files changed, 182 insertions(+), 12 deletions(-)

Comments

Guenter Roeck May 5, 2020, 4:09 p.m. UTC | #1
On 5/4/20 7:14 AM, michaelsh@mellanox.com wrote:
> From: Michael Shych <michaelsh@mellanox.com>
> 
> This patchset adds support of extended new watchdog type 3 of Mellanox
> Ethernet and Infiniband switch systems.
> This type of watchdog can have a timeout period longer than 255 or 32 sec.
> as it was before.
> 
> Michael Shych (4):
>   platform_data/mlxreg: support new watchdog type with longer timeout
>     period
>   platform/x86: mlx-platform: support new watchdog type with longer
>     timeout
>   watchdog: mlx-wdt: support new watchdog type with longer timeout
>     period
>   docs: watchdog: mlx-wdt: Add description of new watchdog type 3
> 
>  Documentation/watchdog/mlx-wdt.rst   |  10 ++++
>  drivers/platform/x86/mlx-platform.c  | 106 ++++++++++++++++++++++++++++++
>  drivers/watchdog/mlx_wdt.c           |  73 ++++++++++++++++++++----
>  include/linux/platform_data/mlxreg.h |   5 +-
>  4 files changed, 182 insertions(+), 12 deletions(-)
> 
Guess the big question is now which branch to use to take this series.
Thoughts, anyone ?

Guenter
Andy Shevchenko May 5, 2020, 4:14 p.m. UTC | #2
On Tue, May 5, 2020 at 7:09 PM Guenter Roeck <linux@roeck-us.net> wrote:
> On 5/4/20 7:14 AM, michaelsh@mellanox.com wrote:
> > From: Michael Shych <michaelsh@mellanox.com>

> > Michael Shych (4):
> >   platform_data/mlxreg: support new watchdog type with longer timeout
> >     period
> >   platform/x86: mlx-platform: support new watchdog type with longer
> >     timeout
> >   watchdog: mlx-wdt: support new watchdog type with longer timeout
> >     period
> >   docs: watchdog: mlx-wdt: Add description of new watchdog type 3
> >
> >  Documentation/watchdog/mlx-wdt.rst   |  10 ++++
> >  drivers/platform/x86/mlx-platform.c  | 106 ++++++++++++++++++++++++++++++
> >  drivers/watchdog/mlx_wdt.c           |  73 ++++++++++++++++++++----
> >  include/linux/platform_data/mlxreg.h |   5 +-

> Guess the big question is now which branch to use to take this series.
> Thoughts, anyone ?

count(watchdog) = 8
count(platform) = 6

Thoughts?
Vadim Pasternak May 5, 2020, 6:39 p.m. UTC | #3
> -----Original Message-----
> From: Andy Shevchenko <andy.shevchenko@gmail.com>
> Sent: Tuesday, May 05, 2020 7:14 PM
> To: Guenter Roeck <linux@roeck-us.net>
> Cc: Michael Shych <michaelsh@mellanox.com>; Wim Van Sebroeck
> <wim@linux-watchdog.org>; Andy Shevchenko <andy@infradead.org>; Darren
> Hart <dvhart@infradead.org>; linux-watchdog@vger.kernel.org; Platform Driver
> <platform-driver-x86@vger.kernel.org>; Vadim Pasternak
> <vadimp@mellanox.com>
> Subject: Re: [PATCH v4 0/4] support watchdog with longer timeout period
> 
> On Tue, May 5, 2020 at 7:09 PM Guenter Roeck <linux@roeck-us.net> wrote:
> > On 5/4/20 7:14 AM, michaelsh@mellanox.com wrote:
> > > From: Michael Shych <michaelsh@mellanox.com>
> 
> > > Michael Shych (4):
> > >   platform_data/mlxreg: support new watchdog type with longer timeout
> > >     period
> > >   platform/x86: mlx-platform: support new watchdog type with longer
> > >     timeout
> > >   watchdog: mlx-wdt: support new watchdog type with longer timeout
> > >     period
> > >   docs: watchdog: mlx-wdt: Add description of new watchdog type 3
> > >
> > >  Documentation/watchdog/mlx-wdt.rst   |  10 ++++
> > >  drivers/platform/x86/mlx-platform.c  | 106
> ++++++++++++++++++++++++++++++
> > >  drivers/watchdog/mlx_wdt.c           |  73 ++++++++++++++++++++----
> > >  include/linux/platform_data/mlxreg.h |   5 +-
> 
> > Guess the big question is now which branch to use to take this series.
> > Thoughts, anyone ?
> 
> count(watchdog) = 8
> count(platform) = 6
> 
> Thoughts?

Hi Andy,

We have some more patches we are going to send for platform
drivers.
Maybe it's better to take it to platform branch to make further
merging easier?

Thanks,
Vadim.
> 
> --
> With Best Regards,
> Andy Shevchenko
Andy Shevchenko May 5, 2020, 8:24 p.m. UTC | #4
On Tue, May 5, 2020 at 9:39 PM Vadim Pasternak <vadimp@mellanox.com> wrote:

> > > Guess the big question is now which branch to use to take this series.
> > > Thoughts, anyone ?
> >
> > count(watchdog) = 8
> > count(platform) = 6
> >
> > Thoughts?
>
> Hi Andy,
>
> We have some more patches we are going to send for platform
> drivers.
> Maybe it's better to take it to platform branch to make further
> merging easier?

It doesn't really matter. Cross subsystem pushes imply immutable branches.
Michael Shych May 21, 2020, 2:25 p.m. UTC | #5
Hi Andy, Guenter,

Did you understand to which branch it will be better to take this patchset?

Thanks,
   Michael.

> -----Original Message-----
> From: Andy Shevchenko <andy.shevchenko@gmail.com>
> Sent: Tuesday, May 5, 2020 7:14 PM
> To: Guenter Roeck <linux@roeck-us.net>
> Cc: Michael Shych <michaelsh@mellanox.com>; Wim Van Sebroeck <wim@linux-
> watchdog.org>; Andy Shevchenko <andy@infradead.org>; Darren Hart
> <dvhart@infradead.org>; linux-watchdog@vger.kernel.org; Platform Driver
> <platform-driver-x86@vger.kernel.org>; Vadim Pasternak
> <vadimp@mellanox.com>
> Subject: Re: [PATCH v4 0/4] support watchdog with longer timeout period
> 
> On Tue, May 5, 2020 at 7:09 PM Guenter Roeck <linux@roeck-us.net> wrote:
> > On 5/4/20 7:14 AM, michaelsh@mellanox.com wrote:
> > > From: Michael Shych <michaelsh@mellanox.com>
> 
> > > Michael Shych (4):
> > >   platform_data/mlxreg: support new watchdog type with longer timeout
> > >     period
> > >   platform/x86: mlx-platform: support new watchdog type with longer
> > >     timeout
> > >   watchdog: mlx-wdt: support new watchdog type with longer timeout
> > >     period
> > >   docs: watchdog: mlx-wdt: Add description of new watchdog type 3
> > >
> > >  Documentation/watchdog/mlx-wdt.rst   |  10 ++++
> > >  drivers/platform/x86/mlx-platform.c  | 106
> ++++++++++++++++++++++++++++++
> > >  drivers/watchdog/mlx_wdt.c           |  73 ++++++++++++++++++++----
> > >  include/linux/platform_data/mlxreg.h |   5 +-
> 
> > Guess the big question is now which branch to use to take this series.
> > Thoughts, anyone ?
> 
> count(watchdog) = 8
> count(platform) = 6
> 
> Thoughts?
> 
> --
> With Best Regards,
> Andy Shevchenko
Guenter Roeck May 29, 2020, 11:12 p.m. UTC | #6
On 5/21/20 7:25 AM, Michael Shych wrote:
> Hi Andy, Guenter,
> 
> Did you understand to which branch it will be better to take this patchset?
> 

I created an immutable branch at
    git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git watchdog-mlx-immutable

Guenter

> Thanks,
>    Michael.
> 
>> -----Original Message-----
>> From: Andy Shevchenko <andy.shevchenko@gmail.com>
>> Sent: Tuesday, May 5, 2020 7:14 PM
>> To: Guenter Roeck <linux@roeck-us.net>
>> Cc: Michael Shych <michaelsh@mellanox.com>; Wim Van Sebroeck <wim@linux-
>> watchdog.org>; Andy Shevchenko <andy@infradead.org>; Darren Hart
>> <dvhart@infradead.org>; linux-watchdog@vger.kernel.org; Platform Driver
>> <platform-driver-x86@vger.kernel.org>; Vadim Pasternak
>> <vadimp@mellanox.com>
>> Subject: Re: [PATCH v4 0/4] support watchdog with longer timeout period
>>
>> On Tue, May 5, 2020 at 7:09 PM Guenter Roeck <linux@roeck-us.net> wrote:
>>> On 5/4/20 7:14 AM, michaelsh@mellanox.com wrote:
>>>> From: Michael Shych <michaelsh@mellanox.com>
>>
>>>> Michael Shych (4):
>>>>   platform_data/mlxreg: support new watchdog type with longer timeout
>>>>     period
>>>>   platform/x86: mlx-platform: support new watchdog type with longer
>>>>     timeout
>>>>   watchdog: mlx-wdt: support new watchdog type with longer timeout
>>>>     period
>>>>   docs: watchdog: mlx-wdt: Add description of new watchdog type 3
>>>>
>>>>  Documentation/watchdog/mlx-wdt.rst   |  10 ++++
>>>>  drivers/platform/x86/mlx-platform.c  | 106
>> ++++++++++++++++++++++++++++++
>>>>  drivers/watchdog/mlx_wdt.c           |  73 ++++++++++++++++++++----
>>>>  include/linux/platform_data/mlxreg.h |   5 +-
>>
>>> Guess the big question is now which branch to use to take this series.
>>> Thoughts, anyone ?
>>
>> count(watchdog) = 8
>> count(platform) = 6
>>
>> Thoughts?
>>
>> --
>> With Best Regards,
>> Andy Shevchenko