From patchwork Tue Mar 14 13:24:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xingyu Wu X-Patchwork-Id: 13174431 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50393C6FD1C for ; Tue, 14 Mar 2023 13:27:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232483AbjCNN1m convert rfc822-to-8bit (ORCPT ); Tue, 14 Mar 2023 09:27:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232024AbjCNN1W (ORCPT ); Tue, 14 Mar 2023 09:27:22 -0400 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D66A18B3F; Tue, 14 Mar 2023 06:24:41 -0700 (PDT) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 5A1B424E20D; Tue, 14 Mar 2023 21:24:39 +0800 (CST) Received: from EXMBX061.cuchost.com (172.16.6.61) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 14 Mar 2023 21:24:39 +0800 Received: from localhost.localdomain (113.72.145.194) by EXMBX061.cuchost.com (172.16.6.61) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 14 Mar 2023 21:24:37 +0800 From: Xingyu Wu To: , , , Wim Van Sebroeck , Guenter Roeck , Krzysztof Kozlowski , Emil Renner Berthing , Conor Dooley CC: Rob Herring , Paul Walmsley , Palmer Dabbelt , Albert Ou , Philipp Zabel , Xingyu Wu , Samin Guo , Subject: [PATCH v5 0/3] Add watchdog driver for StarFive JH7100/JH7110 RISC-V SoCs Date: Tue, 14 Mar 2023 21:24:34 +0800 Message-ID: <20230314132437.121534-1-xingyu.wu@starfivetech.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [113.72.145.194] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX061.cuchost.com (172.16.6.61) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org This patch serises are to add watchdog driver for the StarFive JH7100 and JH7110 RISC-V SoCs. The first patch adds docunmentation to describe device tree bindings. The subsequent patch adds watchdog driver and support JH7100/JH7110 SoCs. And the last patch adds watchdog node in the JH7100 dts. And the addition of JH7110 device tree node will be submitted after the JH7110 dts merge. This patchset is based on 6.3-rc1. The watchdog driver has been tested on the VisionFive 1 and VisionFive 2 boards which equip with JH7100 and JH7110 SoCs respectively and both works normally. Changes since v4: Patch 2: - Dropped the struct device. - Renamed the struct watchdog_device. - Modified the struct reset_control to be local variable. - Fixed the exit error with spinlock. - Dropped the function of starfive_wdt_is_locked(). - Changed the macro name of 'OPTIONS'. - Changed the order in probe to do less work if return '-EPROBE_DEFER'. - Fixed some function that ignored return value. Patch 3: - Dropped the label of watchdog node. Changes since v3: - Modified the dt-binding, driver and dts to support JH7100 watchdog. - Modified the register comments. - Changed the return value and order when getting clock rate. - Used dev_err_probe() when getting clocks and resets. - Improved the codes of setting default timeout. - Moved the watchdog_register_device() after setting WDOG_HW_RUNNING. - Changed 'SOC_STARFIVE' to 'ARCH_STARFIVE' in Kconfig file. - Dropped the struct of platform_device_id. - Used new functions to enable or disable clock. Changes since v2: - Added watchdog.yaml and unevaluatedProperties in the dt-binding. - Removed some unnecessary include files. - Changed the 'module_param' name and dropped 'soft_noboot'. - Rrmoved 'CONFIG_OF'. - Added a check if clock rate is 0. - Modified the max_timeout calculation formula. - Removed restart function. - Removed duplicate checks on the upper and lower bounds of 'count'. - Removed 'started' variable. - Added pm_runtime_get_sync() and pm_runtime_put_sync(). - Removed 'firmware_version = 0' variable. - Drop the device tree node commit. Changes since v1: - Renamed the dt-binding 'starfive,wdt.yaml' to 'starfive,jh7110-wdt.yaml'. - Dropped the '_clk' and 'rst_' about the 'clock-names' and 'reset-names' in the dt-binding. - Updated the example context in the dt-binding 'starfive,jh7110-wdt.yaml' to be independent of other patchset. - Deleted unused macros like 'JH7110_WDOG_INT_EN'. - Changed the type of 'freq' in the struct from u64 to u32. - Used 'devm_clk_get_enabled()' instead of 'devm_clk_get()' and 'clk_prepare_enable()'. - Removed the operation to get the frequency from the device tree. - Added watchdog_stop_on_unregister() and watchdog_stop_on_reboot(). - Removed any operations about interrupt. v4: --- https://lore.kernel.org/all/20230308034036.99213-1-xingyu.wu@starfivetech.com/ v3: --- https://lore.kernel.org/all/20230220081926.267695-1-xingyu.wu@starfivetech.com/ v2: --- https://lore.kernel.org/all/20221219094233.179153-1-xingyu.wu@starfivetech.com/ v1: --- https://lore.kernel.org/all/20221202093943.149674-1-xingyu.wu@starfivetech.com/ Xingyu Wu (3): dt-bindings: watchdog: Add watchdog for StarFive JH7100 and JH7110 drivers: watchdog: Add StarFive Watchdog driver riscv: dts: starfive: jh7100: Add watchdog node .../watchdog/starfive,jh7100-wdt.yaml | 71 ++ MAINTAINERS | 7 + arch/riscv/boot/dts/starfive/jh7100.dtsi | 10 + drivers/watchdog/Kconfig | 11 + drivers/watchdog/Makefile | 3 + drivers/watchdog/starfive-wdt.c | 606 ++++++++++++++++++ 6 files changed, 708 insertions(+) create mode 100644 Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml create mode 100644 drivers/watchdog/starfive-wdt.c base-commit: 8ca09d5fa3549d142c2080a72a4c70ce389163cd prerequisite-patch-id: 558a5b43260d13a6f5229b139ccd45f737a4f686