| Message ID | 20231005155618.700312-1-peter.griffin@linaro.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add minimal Tensor/GS101 SoC support and Oriole/Pixel6 board | expand |
On 05/10/2023 17:55, Peter Griffin wrote: > Hi folks, > > This series adds initial SoC support for the GS101 SoC and also initial board > support for Pixel 6 phone (Oriole). > > The gs101 / Tensor SoC is also used in Pixel6a (bluejay) and Pixel 6 Pro (raven). > Currently DT is just added for the gs101 SoC and Oriole. Thanks for submitting the patches. Nice work! This is basically a custom-made variant of Exynos made by Samsung for Google. Something similar what is with Tesla FSD (and Axis Artpec-8 which was not upstreamed, AFAIR). Many, many drivers and bindings will be re-used. I want to be sure that GS101 fits into existing Samsung Exynos support, re-uses it as much as possible and extend when necessary without breaking anything. Therefore, when the patches are ready, I would like to be the one applying entire set and future submissions through Samsung SoC tree, just like I am doing it with Tesla FSD, so I keep entire Samsung-ecosystem in shape. This also means that you are lucky to be selected to: https://elixir.bootlin.com/linux/v6.6-rc4/source/Documentation/process/maintainer-soc-clean-dts.rst joining there Tesla FSD and entire Samsung Exynos family :) I hope that's ok. Best regards, Krzysztof
On 05/10/2023 17:55, Peter Griffin wrote: > Hi folks, > > This series adds initial SoC support for the GS101 SoC and also initial board > support for Pixel 6 phone (Oriole). > > The gs101 / Tensor SoC is also used in Pixel6a (bluejay) and Pixel 6 Pro (raven). > Currently DT is just added for the gs101 SoC and Oriole. > > The support added in this series consists of: > * cpus > * pinctrl > * some CCF clock implementation > * watchdog > * uart > * gpio Hi Peter, Heads up, in case you are not aware Arm SoC timeframes: we are at rc5, so it means that anything targeting v6.7 should be applied this working week, before rc6. At least as ARM SoC is concerned. Best regards, Krzysztof
Hi Krzysztof, On Thu, 5 Oct 2023 at 17:32, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 05/10/2023 17:55, Peter Griffin wrote: > > Hi folks, > > > > This series adds initial SoC support for the GS101 SoC and also initial board > > support for Pixel 6 phone (Oriole). > > > > The gs101 / Tensor SoC is also used in Pixel6a (bluejay) and Pixel 6 Pro (raven). > > Currently DT is just added for the gs101 SoC and Oriole. > > Thanks for submitting the patches. Nice work! Thanks, and thankyou for reviewing the series so promptly. > > This is basically a custom-made variant of Exynos made by Samsung for > Google. Something similar what is with Tesla FSD (and Axis Artpec-8 > which was not upstreamed, AFAIR). Many, many drivers and bindings will > be re-used. I want to be sure that GS101 fits into existing Samsung > Exynos support, re-uses it as much as possible and extend when necessary > without breaking anything. Therefore, when the patches are ready, I > would like to be the one applying entire set and future submissions > through Samsung SoC tree, just like I am doing it with Tesla FSD, so I > keep entire Samsung-ecosystem in shape. > > This also means that you are lucky to be selected to: > https://elixir.bootlin.com/linux/v6.6-rc4/source/Documentation/process/maintainer-soc-clean-dts.rst > joining there Tesla FSD and entire Samsung Exynos family :) > > I hope that's ok. That's all fine, it makes sense and it was what I was expecting. Maybe we can try and get you some Pixel 6 hardware as well. The only other Exynos hardware I have for testing unfortunately is the e850 board Sam has been working on. Coincidentally https://www.crowdsupply.com/0xda/usb-cereal just started shipping. Which is quite nice (albeit coincidental) timing, as anyone who has a Pixel 6 device can order one so they can run upstream kernels on their phone and have the debug UART available (which currently is the only way to really interact with the system until we bring up more IO). regards, Peter
Hi Krzysztof, On Mon, 9 Oct 2023 at 12:10, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 05/10/2023 17:55, Peter Griffin wrote: > > Hi folks, > > > > This series adds initial SoC support for the GS101 SoC and also initial board > > support for Pixel 6 phone (Oriole). > > > > The gs101 / Tensor SoC is also used in Pixel6a (bluejay) and Pixel 6 Pro (raven). > > Currently DT is just added for the gs101 SoC and Oriole. > > > > The support added in this series consists of: > > * cpus > > * pinctrl > > * some CCF clock implementation > > * watchdog > > * uart > > * gpio > > Hi Peter, > > Heads up, in case you are not aware Arm SoC timeframes: we are at rc5, > so it means that anything targeting v6.7 should be applied this working > week, before rc6. At least as ARM SoC is concerned. Thanks for the heads up! I'm just working on v2 now incorporating all the review feedback. I'm hoping to have that sent out by the end of today or early tomorrow. Thanks, Peter.
Hi folks, This series adds initial SoC support for the GS101 SoC and also initial board support for Pixel 6 phone (Oriole). The gs101 / Tensor SoC is also used in Pixel6a (bluejay) and Pixel 6 Pro (raven). Currently DT is just added for the gs101 SoC and Oriole. The support added in this series consists of: * cpus * pinctrl * some CCF clock implementation * watchdog * uart * gpio This is enough to boot through to a busybox initramfs and shell using an upstream kernel though :) More platform support will be added over the following weeks and months. Currently we boot with clk_ignore_unused parameter but this will be updated as more clocks and platform support lands. For further information on how to build and flash the upstream kernel on your Pixel 6, with a prebuilt busybox initramfs please refer to the script and README.md here: https://git.codelinaro.org/linaro/googlelt/pixelscripts I've also included the dtbo overlay containing board_id and board_rev in this series as otherwise the LK bootloader will bootloop if this is not present in the dtbo partition. It seems like it would be nicer for the upstream kernel to build all the DT required to boot upstream kernel on a production phone rather than having to obtain this dtbo from some other place, but if it is a pain point then I can remove it. Many thanks, Peter. Peter Griffin (21): dt-bindings: interrupt-controller: Add gs101 interrupt controller dt-bindings: soc: samsung: exynos-pmu: Add gs101 compatible dt-bindings: clock: Add Google gs101 clock management unit bindings dt-bindings: soc: google: exynos-sysreg: add dedicated SYSREG compatibles to GS101 dt-bindings: watchdog: Document Google gs101 & gs201 watchdog bindings dt-bindings: arm: google: Add bindings for Google ARM platforms dt-bindings: pinctrl: samsung: add google,gs101-pinctrl compatible dt-bindings: pinctrl: samsung: add gs101-wakeup-eint compatible dt-bindings: clock: gs101: Add cmu_top clock indices dt-bindings: clock: gs101: Add cmu_apm clock indices dt-bindings: clock: gs101: Add cmu_misc clock indices clk: samsung: clk-pll: Add support for pll_{0516,0517,518} clk: samsung: clk-gs101: Add cmu_top registers, plls, mux and gates clk: samsung: clk-gs101: add CMU_APM support clk: google: gs101: Add support for CMU_MISC clock unit pinctrl: samsung: Add gs101 SoC pinctrl configuration watchdog: s3c2410_wdt: Add support for Google tensor SoCs arm64: dts: google: Add initial Google gs101 SoC support google/gs101: Add dt overlay for oriole board arm64: defconfig: Enable Google Tensor SoC MAINTAINERS: add entry for Google Tensor SoC .../devicetree/bindings/arm/google.yaml | 46 + .../bindings/clock/google,gs101-clock.yaml | 109 + .../samsung,pinctrl-wakeup-interrupt.yaml | 2 + .../bindings/pinctrl/samsung,pinctrl.yaml | 4 +- .../bindings/soc/samsung/exynos-pmu.yaml | 2 + .../soc/samsung/samsung,exynos-sysreg.yaml | 7 + .../bindings/watchdog/samsung-wdt.yaml | 10 +- MAINTAINERS | 11 + arch/arm64/Kconfig.platforms | 6 + arch/arm64/boot/dts/Makefile | 1 + arch/arm64/boot/dts/google/Makefile | 7 + arch/arm64/boot/dts/google/gs101-oriole.dts | 68 + arch/arm64/boot/dts/google/gs101-oriole.dtso | 21 + arch/arm64/boot/dts/google/gs101-pinctrl.dtsi | 1134 +++++++++ arch/arm64/boot/dts/google/gs101-pinctrl.h | 17 + arch/arm64/boot/dts/google/gs101.dtsi | 501 ++++ arch/arm64/configs/defconfig | 1 + drivers/clk/samsung/Kconfig | 9 + drivers/clk/samsung/Makefile | 1 + drivers/clk/samsung/clk-gs101.c | 2171 +++++++++++++++++ drivers/clk/samsung/clk-pll.c | 9 +- drivers/clk/samsung/clk-pll.h | 3 + .../pinctrl/samsung/pinctrl-exynos-arm64.c | 163 ++ drivers/pinctrl/samsung/pinctrl-exynos.c | 68 +- drivers/pinctrl/samsung/pinctrl-exynos.h | 44 + drivers/pinctrl/samsung/pinctrl-samsung.c | 4 + drivers/pinctrl/samsung/pinctrl-samsung.h | 24 + drivers/watchdog/s3c2410_wdt.c | 116 +- include/dt-bindings/clock/gs101.h | 232 ++ .../dt-bindings/interrupt-controller/gs101.h | 758 ++++++ 30 files changed, 5533 insertions(+), 16 deletions(-) create mode 100644 Documentation/devicetree/bindings/arm/google.yaml create mode 100644 Documentation/devicetree/bindings/clock/google,gs101-clock.yaml create mode 100644 arch/arm64/boot/dts/google/Makefile create mode 100644 arch/arm64/boot/dts/google/gs101-oriole.dts create mode 100644 arch/arm64/boot/dts/google/gs101-oriole.dtso create mode 100644 arch/arm64/boot/dts/google/gs101-pinctrl.dtsi create mode 100644 arch/arm64/boot/dts/google/gs101-pinctrl.h create mode 100644 arch/arm64/boot/dts/google/gs101.dtsi create mode 100644 drivers/clk/samsung/clk-gs101.c create mode 100644 include/dt-bindings/clock/gs101.h create mode 100644 include/dt-bindings/interrupt-controller/gs101.h