| Message ID | 20240605161851.13911-1-kabel@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Turris Omnia MCU driver | expand |
On Wed, Jun 5, 2024 at 7:19 PM Marek Behún <kabel@kernel.org> wrote: > > Hello Andy, Hans, Ilpo, Arnd, Gregory, and others, > > this is v11 of the series adding Turris Omnia MCU driver. Thank you! There are a few small issues here and there, but overall LGTM. The only one main question is what to do with gpiochip_get_desc(). I Cc'ed Bart for this.
On Wed, 5 Jun 2024 22:05:37 +0300 Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > On Wed, Jun 5, 2024 at 7:19 PM Marek Behún <kabel@kernel.org> wrote: > > > > Hello Andy, Hans, Ilpo, Arnd, Gregory, and others, > > > > this is v11 of the series adding Turris Omnia MCU driver. > > Thank you! > There are a few small issues here and there, but overall LGTM. The > only one main question is what to do with gpiochip_get_desc(). I Cc'ed > Bart for this. Thank you for the review, I am going to apply the changes you requested and wait for Bart, and we'll see what to do with the gpiochip_get_desc(). Marek
Hello Andy, Hans, Ilpo, Arnd, Gregory, and others, this is v11 of the series adding Turris Omnia MCU driver. Changes since v10: - dropped patch 7 from v10 ("Add support for digital message signing via debugfs"). This must be done via different kernel API (should be doable via keyctl), but this requires more work which I currently don't have, unfortunately - in patch 3 where I introduce support for MCU connected GPIOs changed u32 types to unsigned long where it made sense, in order to be able to use __assign_bit(), __set_bit(), test_bit(). This was suggested by Andy. - in patch 3 deduplicated code in omnia_gpio_get_multiple() - moved the "fixing" in patch 3 of functions introduced in patch 2 to patch 2, this was a rebasing error in v10 - changed date to September 2024 and KernelVersion to 6.11 in Documentation/ABI/testing/sysfs-bus-i2c-devices-turris-omnia-mcu Links to previous cover letters (v1 to v10): https://patchwork.kernel.org/project/linux-soc/cover/20230823161012.6986-1-kabel@kernel.org/ https://patchwork.kernel.org/project/linux-soc/cover/20230919103815.16818-1-kabel@kernel.org/ https://patchwork.kernel.org/project/linux-soc/cover/20231023143130.11602-1-kabel@kernel.org/ https://patchwork.kernel.org/project/linux-soc/cover/20231026161803.16750-1-kabel@kernel.org/ https://patchwork.kernel.org/project/linux-soc/cover/20240323164359.21642-1-kabel@kernel.org/ https://patchwork.kernel.org/project/linux-soc/cover/20240418121116.22184-1-kabel@kernel.org/ https://patchwork.kernel.org/project/linux-soc/cover/20240424173809.7214-1-kabel@kernel.org/ https://patchwork.kernel.org/project/linux-soc/cover/20240430115111.3453-1-kabel@kernel.org/ https://patchwork.kernel.org/project/linux-soc/cover/20240508103118.23345-1-kabel@kernel.org/ https://patchwork.kernel.org/project/linux-soc/cover/20240510101819.13551-1-kabel@kernel.org/ Marek Behún (8): dt-bindings: firmware: add cznic,turris-omnia-mcu binding platform: cznic: Add preliminary support for Turris Omnia MCU platform: cznic: turris-omnia-mcu: Add support for MCU connected GPIOs platform: cznic: turris-omnia-mcu: Add support for poweroff and wakeup platform: cznic: turris-omnia-mcu: Add support for MCU watchdog platform: cznic: turris-omnia-mcu: Add support for MCU provided TRNG ARM: dts: turris-omnia: Add MCU system-controller node ARM: dts: turris-omnia: Add GPIO key node for front button .../sysfs-bus-i2c-devices-turris-omnia-mcu | 113 ++ .../firmware/cznic,turris-omnia-mcu.yaml | 86 ++ MAINTAINERS | 4 + .../dts/marvell/armada-385-turris-omnia.dts | 35 +- drivers/platform/Kconfig | 2 + drivers/platform/Makefile | 1 + drivers/platform/cznic/Kconfig | 48 + drivers/platform/cznic/Makefile | 8 + .../platform/cznic/turris-omnia-mcu-base.c | 407 +++++++ .../platform/cznic/turris-omnia-mcu-gpio.c | 1071 +++++++++++++++++ .../cznic/turris-omnia-mcu-sys-off-wakeup.c | 257 ++++ .../platform/cznic/turris-omnia-mcu-trng.c | 103 ++ .../cznic/turris-omnia-mcu-watchdog.c | 128 ++ drivers/platform/cznic/turris-omnia-mcu.h | 194 +++ include/linux/turris-omnia-mcu-interface.h | 249 ++++ 15 files changed, 2705 insertions(+), 1 deletion(-) create mode 100644 Documentation/ABI/testing/sysfs-bus-i2c-devices-turris-omnia-mcu create mode 100644 Documentation/devicetree/bindings/firmware/cznic,turris-omnia-mcu.yaml create mode 100644 drivers/platform/cznic/Kconfig create mode 100644 drivers/platform/cznic/Makefile create mode 100644 drivers/platform/cznic/turris-omnia-mcu-base.c create mode 100644 drivers/platform/cznic/turris-omnia-mcu-gpio.c create mode 100644 drivers/platform/cznic/turris-omnia-mcu-sys-off-wakeup.c create mode 100644 drivers/platform/cznic/turris-omnia-mcu-trng.c create mode 100644 drivers/platform/cznic/turris-omnia-mcu-watchdog.c create mode 100644 drivers/platform/cznic/turris-omnia-mcu.h create mode 100644 include/linux/turris-omnia-mcu-interface.h