mbox series

[v4,0/9] Add support to configure CPG block for watchdog on RZ/V2H(P) and RZ/G3E SoCs

Message ID 20250210184910.161780-1-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive)
Headers show
Series Add support to configure CPG block for watchdog on RZ/V2H(P) and RZ/G3E SoCs | expand

Message

Lad, Prabhakar Feb. 10, 2025, 6:49 p.m. UTC
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Hi All,

This patch series adds SYSCON support to configure and retrieve boot
status information from the CPG block for the RZ/V2H(P) and RZ/G3E SoCs.
Summary of Changes,

    Clock:
        Add syscon compatible support to the CPG block in bindings and
        device trees.

    Watchdog:
        Document the renesas,r9a09g057-syscon-wdt-errorrst property.
        Update the watchdog driver to fetch and report boot status via
        Error Reset Registers (CPG_ERROR_RSTm) and configure the
        CPG_ERRORRST_SEL2 register.

    Device Tree:
        -Add the syscon property to CPG nodes in R9A09G057 and R9A09G047
         SoC DTSI.
        -Add the renesas,syscon-cpg-error-rst property to WDT nodes in
         R9A09G057 and R9A09G047 SoC DTSI.

v3->v4
- Added support to configure CPG_ERRORRST_SEL2 register
- Updated commit messages

v2->v3
- Updated comment section to mention there aren't any ABI breakages with
  this patch series.

Cheers,
Prabhakar

Lad Prabhakar (9):
  dt-bindings: clock: rzv2h-cpg: Add syscon compatible for CPG
  clk: renesas: Kconfig: Select MFD_SYSCON for RZ/V2H(P) family driver
  arm64: dts: renesas: r9a09g047: Add `syscon` compatible for CPG node
  arm64: dts: renesas: r9a09g057: Add `syscon` compatible for CPG node
  dt-bindings: watchdog: renesas: Document
    `renesas,syscon-cpg-error-rst` property
  watchdog: rzv2h_wdt: Add support to retrieve the bootstatus
    information
  watchdog: rzv2h_wdt: Configure CPG_ERRORRST_SEL2 register
  arm64: dts: renesas: r9a09g057: Add `renesas,syscon-cpg-error-rst`
    property to WDT node
  arm64: dts: renesas: r9a09g047: Add `renesas,syscon-cpg-error-rst`
    property to WDT node

 .../bindings/clock/renesas,rzv2h-cpg.yaml     | 10 ++--
 .../bindings/watchdog/renesas,wdt.yaml        | 17 ++++++
 arch/arm64/boot/dts/renesas/r9a09g047.dtsi    |  5 +-
 arch/arm64/boot/dts/renesas/r9a09g057.dtsi    |  6 ++-
 drivers/clk/renesas/Kconfig                   |  1 +
 drivers/watchdog/rzv2h_wdt.c                  | 54 +++++++++++++++++++
 6 files changed, 87 insertions(+), 6 deletions(-)

Comments

Lad, Prabhakar Feb. 18, 2025, 10:26 a.m. UTC | #1
Hi All,

On Mon, Feb 10, 2025 at 6:49 PM Prabhakar <prabhakar.csengg@gmail.com> wrote:
>
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Hi All,
>
> This patch series adds SYSCON support to configure and retrieve boot
> status information from the CPG block for the RZ/V2H(P) and RZ/G3E SoCs.
> Summary of Changes,
>
>     Clock:
>         Add syscon compatible support to the CPG block in bindings and
>         device trees.
>
>     Watchdog:
>         Document the renesas,r9a09g057-syscon-wdt-errorrst property.
>         Update the watchdog driver to fetch and report boot status via
>         Error Reset Registers (CPG_ERROR_RSTm) and configure the
>         CPG_ERRORRST_SEL2 register.
>
>     Device Tree:
>         -Add the syscon property to CPG nodes in R9A09G057 and R9A09G047
>          SoC DTSI.
>         -Add the renesas,syscon-cpg-error-rst property to WDT nodes in
>          R9A09G057 and R9A09G047 SoC DTSI.
>
> v3->v4
> - Added support to configure CPG_ERRORRST_SEL2 register
> - Updated commit messages
>
> v2->v3
> - Updated comment section to mention there aren't any ABI breakages with
>   this patch series.
>
> Cheers,
> Prabhakar
>
> Lad Prabhakar (9):
>   dt-bindings: clock: rzv2h-cpg: Add syscon compatible for CPG
>   clk: renesas: Kconfig: Select MFD_SYSCON for RZ/V2H(P) family driver
>   arm64: dts: renesas: r9a09g047: Add `syscon` compatible for CPG node
>   arm64: dts: renesas: r9a09g057: Add `syscon` compatible for CPG node
>   dt-bindings: watchdog: renesas: Document
>     `renesas,syscon-cpg-error-rst` property
>   watchdog: rzv2h_wdt: Add support to retrieve the bootstatus
>     information
>   watchdog: rzv2h_wdt: Configure CPG_ERRORRST_SEL2 register
>   arm64: dts: renesas: r9a09g057: Add `renesas,syscon-cpg-error-rst`
>     property to WDT node
>   arm64: dts: renesas: r9a09g047: Add `renesas,syscon-cpg-error-rst`
>     property to WDT node
>
Gentle ping.


Cheers,
Prabhakar
Geert Uytterhoeven Feb. 20, 2025, 10:12 a.m. UTC | #2
Hi Prabhakar,

On Mon, 10 Feb 2025 at 19:49, Prabhakar <prabhakar.csengg@gmail.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> This patch series adds SYSCON support to configure and retrieve boot
> status information from the CPG block for the RZ/V2H(P) and RZ/G3E SoCs.
> Summary of Changes,

Wasn't the plan to use a DT property under /chosen instead?
(Yes, I go to great lengths to avoid reviewing and accepting patches
 adding syscon compatible values anywhere ;-)

> v3->v4
> - Added support to configure CPG_ERRORRST_SEL2 register

Oh, I  guess that's the reason why you changed your mind.
I will reply to that patch...

Gr{oetje,eeting}s,

                        Geert