| Message ID | cover.1608141131.git.vijayakannan.ayyathurai@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add drivers for Intel Keem Bay SoC watchdog | expand |
Hi, Kindly help to review this updated(v4) patch set. > From: Vijayakannan Ayyathurai <vijayakannan.ayyathurai@intel.com> > > Hi, > > This patch set adds the watchdog timer driver support for Intel Keem Bay Soc. > > Patch 2 holds the driver and Patch 1 holds the Device Tree > binding documentation. > > This driver was tested on the Keem Bay evaluation module board. > > Thank you, > Vijay > > Changes since v3: > - Fix pretimeout clear, when user attempt in the below sequence. > - set pretimeout > - clear pretimeout > - set timeout to some other value > - Cleanup the ping variable usage in the driver. > - Add keembay_wdt_set_timeout_reg function. > - Cleanup the keembay_wdt_th_isr function. > - Rebase the driver with 5.10-rc7 tag. > > Changes since v2: > - Remove reduntant write to TIM_WATCHDOG as per Guenter. > - Rebase the driver with 5.10-rc5 tag. > > Changes since v1: > - Fix indentation error in the dt-bindings file. > - Use true/false in the second arg of keembay_wdt_set_timeout_reg(). > - Fix the watchdog start sequence. > - Avoid reduntant timeout register setting. > - Remove min usage to find actual time at keembay_wdt_set_timeout(). > - Remove timeout configuration boundary check at > keembay_wdt_set_pretimeout(). > - Use devm_watchdog_register_device() for wdt registration, which > eventually supports driver unload functionality as well. > > Vijayakannan Ayyathurai (2): > dt-bindings: watchdog: Add bindings for Intel Keem Bay SoC > watchdog: Add watchdog driver for Intel Keembay Soc > > .../bindings/watchdog/intel,keembay-wdt.yaml | 57 ++++ > drivers/watchdog/Kconfig | 13 + > drivers/watchdog/Makefile | 1 + > drivers/watchdog/keembay_wdt.c | 286 ++++++++++++++++++ > 4 files changed, 357 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/watchdog/intel,keembay-wdt.yaml > create mode 100644 drivers/watchdog/keembay_wdt.c > > > base-commit: 0477e92881850d44910a7e94fc2c46f96faa131f > prerequisite-patch-id: 822987dcf4c969ef6ac70359b088af06ba39042b > prerequisite-patch-id: 0a348762b660d0d817b8e70cc71647e83173c78c > prerequisite-patch-id: 54c661a006c7362053cb7602448d6c77419d5cf9 > prerequisite-patch-id: d140d8534fb828778e0652fe5fcf6282e027f985 > -- > 2.17.1 Thanks, Vijay
Hi, > From: Vijayakannan Ayyathurai <vijayakannan.ayyathurai@intel.com> > > Changes since v3: > - Fix pretimeout clear, when user attempt in the below sequence. > - set pretimeout > - clear pretimeout > - set timeout to some other value > - Cleanup the ping variable usage in the driver. > - Add keembay_wdt_set_timeout_reg function. > - Cleanup the keembay_wdt_th_isr function. > - Rebase the driver with 5.10-rc7 tag. > Kindly help us to review this updated patch(v4) set. Thanks, Vijay > Changes since v2: > - Remove reduntant write to TIM_WATCHDOG as per Guenter. > - Rebase the driver with 5.10-rc5 tag. > > Changes since v1: > - Fix indentation error in the dt-bindings file. > - Use true/false in the second arg of keembay_wdt_set_timeout_reg(). > - Fix the watchdog start sequence. > - Avoid reduntant timeout register setting. > - Remove min usage to find actual time at keembay_wdt_set_timeout(). > - Remove timeout configuration boundary check at > keembay_wdt_set_pretimeout(). > - Use devm_watchdog_register_device() for wdt registration, which > eventually supports driver unload functionality as well. >
From: Vijayakannan Ayyathurai <vijayakannan.ayyathurai@intel.com> Hi, This patch set adds the watchdog timer driver support for Intel Keem Bay Soc. Patch 2 holds the driver and Patch 1 holds the Device Tree binding documentation. This driver was tested on the Keem Bay evaluation module board. Thank you, Vijay Changes since v3: - Fix pretimeout clear, when user attempt in the below sequence. - set pretimeout - clear pretimeout - set timeout to some other value - Cleanup the ping variable usage in the driver. - Add keembay_wdt_set_timeout_reg function. - Cleanup the keembay_wdt_th_isr function. - Rebase the driver with 5.10-rc7 tag. Changes since v2: - Remove reduntant write to TIM_WATCHDOG as per Guenter. - Rebase the driver with 5.10-rc5 tag. Changes since v1: - Fix indentation error in the dt-bindings file. - Use true/false in the second arg of keembay_wdt_set_timeout_reg(). - Fix the watchdog start sequence. - Avoid reduntant timeout register setting. - Remove min usage to find actual time at keembay_wdt_set_timeout(). - Remove timeout configuration boundary check at keembay_wdt_set_pretimeout(). - Use devm_watchdog_register_device() for wdt registration, which eventually supports driver unload functionality as well. Vijayakannan Ayyathurai (2): dt-bindings: watchdog: Add bindings for Intel Keem Bay SoC watchdog: Add watchdog driver for Intel Keembay Soc .../bindings/watchdog/intel,keembay-wdt.yaml | 57 ++++ drivers/watchdog/Kconfig | 13 + drivers/watchdog/Makefile | 1 + drivers/watchdog/keembay_wdt.c | 286 ++++++++++++++++++ 4 files changed, 357 insertions(+) create mode 100644 Documentation/devicetree/bindings/watchdog/intel,keembay-wdt.yaml create mode 100644 drivers/watchdog/keembay_wdt.c base-commit: 0477e92881850d44910a7e94fc2c46f96faa131f prerequisite-patch-id: 822987dcf4c969ef6ac70359b088af06ba39042b prerequisite-patch-id: 0a348762b660d0d817b8e70cc71647e83173c78c prerequisite-patch-id: 54c661a006c7362053cb7602448d6c77419d5cf9 prerequisite-patch-id: d140d8534fb828778e0652fe5fcf6282e027f985