| Message ID | 1611128890-79204-1-git-send-email-abaci-bugfix@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | watchdog/hpwdt: Assign boolean values to a bool variable | expand |
On Wed, Jan 20, 2021 at 03:48:10PM +0800, Jiapeng Zhong wrote: > Fix the following coccicheck warnings: > > ./drivers/watchdog/hpwdt.c:345:2-12: WARNING: Assignment of > 0/1 to bool variable. > > ./drivers/watchdog/hpwdt.c:126:2-12: WARNING: Assignment of > 0/1 to bool variable. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com> > --- > drivers/watchdog/hpwdt.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Jerry Hoemann <jerry.hoemann@hpe.com> > > diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c > index cbd1498..22ddba3 100644 > --- a/drivers/watchdog/hpwdt.c > +++ b/drivers/watchdog/hpwdt.c > @@ -123,7 +123,7 @@ static int hpwdt_settimeout(struct watchdog_device *wdd, unsigned int val) > if (val <= wdd->pretimeout) { > dev_dbg(wdd->parent, "pretimeout < timeout. Setting to zero\n"); > wdd->pretimeout = 0; > - pretimeout = 0; > + pretimeout = false; > if (watchdog_active(wdd)) > hpwdt_start(wdd); > } > @@ -336,13 +336,13 @@ static int hpwdt_init_one(struct pci_dev *dev, > watchdog_init_timeout(&hpwdt_dev, soft_margin, NULL); > > if (is_kdump_kernel()) { > - pretimeout = 0; > + pretimeout = false; > kdumptimeout = 0; > } > > if (pretimeout && hpwdt_dev.timeout <= PRETIMEOUT_SEC) { > dev_warn(&dev->dev, "timeout <= pretimeout. Setting pretimeout to zero\n"); > - pretimeout = 0; > + pretimeout = false; > } > hpwdt_dev.pretimeout = pretimeout ? PRETIMEOUT_SEC : 0; > kdumptimeout = min(kdumptimeout, HPWDT_MAX_TIMER); > -- > 1.8.3.1
On Wed, Jan 20, 2021 at 03:48:10PM +0800, Jiapeng Zhong wrote: > Fix the following coccicheck warnings: > > ./drivers/watchdog/hpwdt.c:345:2-12: WARNING: Assignment of > 0/1 to bool variable. > > ./drivers/watchdog/hpwdt.c:126:2-12: WARNING: Assignment of > 0/1 to bool variable. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net> > --- > drivers/watchdog/hpwdt.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c > index cbd1498..22ddba3 100644 > --- a/drivers/watchdog/hpwdt.c > +++ b/drivers/watchdog/hpwdt.c > @@ -123,7 +123,7 @@ static int hpwdt_settimeout(struct watchdog_device *wdd, unsigned int val) > if (val <= wdd->pretimeout) { > dev_dbg(wdd->parent, "pretimeout < timeout. Setting to zero\n"); > wdd->pretimeout = 0; > - pretimeout = 0; > + pretimeout = false; > if (watchdog_active(wdd)) > hpwdt_start(wdd); > } > @@ -336,13 +336,13 @@ static int hpwdt_init_one(struct pci_dev *dev, > watchdog_init_timeout(&hpwdt_dev, soft_margin, NULL); > > if (is_kdump_kernel()) { > - pretimeout = 0; > + pretimeout = false; > kdumptimeout = 0; > } > > if (pretimeout && hpwdt_dev.timeout <= PRETIMEOUT_SEC) { > dev_warn(&dev->dev, "timeout <= pretimeout. Setting pretimeout to zero\n"); > - pretimeout = 0; > + pretimeout = false; > } > hpwdt_dev.pretimeout = pretimeout ? PRETIMEOUT_SEC : 0; > kdumptimeout = min(kdumptimeout, HPWDT_MAX_TIMER); > -- > 1.8.3.1 >
On Wed, Jan 20, 2021 at 03:48:10PM +0800, Jiapeng Zhong wrote: > Fix the following coccicheck warnings: > > ./drivers/watchdog/hpwdt.c:345:2-12: WARNING: Assignment of > 0/1 to bool variable. > > ./drivers/watchdog/hpwdt.c:126:2-12: WARNING: Assignment of > 0/1 to bool variable. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com> > Reviewed-by: Jerry Hoemann <jerry.hoemann@hpe.com> > Reviewed-by: Guenter Roeck <linux@roeck-us.net> Reviewed-by: Guenter Roeck <linux@roeck-us.net> > --- > drivers/watchdog/hpwdt.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c > index cbd1498..22ddba3 100644 > --- a/drivers/watchdog/hpwdt.c > +++ b/drivers/watchdog/hpwdt.c > @@ -123,7 +123,7 @@ static int hpwdt_settimeout(struct watchdog_device *wdd, unsigned int val) > if (val <= wdd->pretimeout) { > dev_dbg(wdd->parent, "pretimeout < timeout. Setting to zero\n"); > wdd->pretimeout = 0; > - pretimeout = 0; > + pretimeout = false; > if (watchdog_active(wdd)) > hpwdt_start(wdd); > } > @@ -336,13 +336,13 @@ static int hpwdt_init_one(struct pci_dev *dev, > watchdog_init_timeout(&hpwdt_dev, soft_margin, NULL); > > if (is_kdump_kernel()) { > - pretimeout = 0; > + pretimeout = false; > kdumptimeout = 0; > } > > if (pretimeout && hpwdt_dev.timeout <= PRETIMEOUT_SEC) { > dev_warn(&dev->dev, "timeout <= pretimeout. Setting pretimeout to zero\n"); > - pretimeout = 0; > + pretimeout = false; > } > hpwdt_dev.pretimeout = pretimeout ? PRETIMEOUT_SEC : 0; > kdumptimeout = min(kdumptimeout, HPWDT_MAX_TIMER);
diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c index cbd1498..22ddba3 100644 --- a/drivers/watchdog/hpwdt.c +++ b/drivers/watchdog/hpwdt.c @@ -123,7 +123,7 @@ static int hpwdt_settimeout(struct watchdog_device *wdd, unsigned int val) if (val <= wdd->pretimeout) { dev_dbg(wdd->parent, "pretimeout < timeout. Setting to zero\n"); wdd->pretimeout = 0; - pretimeout = 0; + pretimeout = false; if (watchdog_active(wdd)) hpwdt_start(wdd); } @@ -336,13 +336,13 @@ static int hpwdt_init_one(struct pci_dev *dev, watchdog_init_timeout(&hpwdt_dev, soft_margin, NULL); if (is_kdump_kernel()) { - pretimeout = 0; + pretimeout = false; kdumptimeout = 0; } if (pretimeout && hpwdt_dev.timeout <= PRETIMEOUT_SEC) { dev_warn(&dev->dev, "timeout <= pretimeout. Setting pretimeout to zero\n"); - pretimeout = 0; + pretimeout = false; } hpwdt_dev.pretimeout = pretimeout ? PRETIMEOUT_SEC : 0; kdumptimeout = min(kdumptimeout, HPWDT_MAX_TIMER);
Fix the following coccicheck warnings: ./drivers/watchdog/hpwdt.c:345:2-12: WARNING: Assignment of 0/1 to bool variable. ./drivers/watchdog/hpwdt.c:126:2-12: WARNING: Assignment of 0/1 to bool variable. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com> --- drivers/watchdog/hpwdt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)