| Message ID | 20190518152355.11134-3-peron.clem@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Allwinner H6 watchdog support | expand |
On Sat, May 18, 2019 at 05:23:53PM +0200, Clément Péron wrote: > Allwinner H6 has a watchog node which seems broken > on some boards. > > Test has been performed on several boards. > > Chen-Yu Tsai boards: > Pine H64 - H6448BA 7782 => OK > OrangePi Lite 2 - H8068BA 61C2 => KO > > Martin Ayotte boards: > Pine H64 - H8069BA 6892 => OK > OrangePi 3 - HA047BA 69W2 => KO > OrangePi One Plus - H7310BA 6842 => KO > OrangePi Lite2 - H6448BA 6662 => KO > > Clément Péron board: > Beelink GS1 - H7309BA 6842 => KO > > As it seems not fixable for now, declare the node > but leave it disable with a comment. > > Signed-off-by: Clément Péron <peron.clem@gmail.com> If it doesn't work most boards, then why do we need to merge that patch in the first place? Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Hi, On Mon, 20 May 2019 at 09:36, Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > On Sat, May 18, 2019 at 05:23:53PM +0200, Clément Péron wrote: > > Allwinner H6 has a watchog node which seems broken > > on some boards. > > > > Test has been performed on several boards. > > > > Chen-Yu Tsai boards: > > Pine H64 - H6448BA 7782 => OK > > OrangePi Lite 2 - H8068BA 61C2 => KO > > > > Martin Ayotte boards: > > Pine H64 - H8069BA 6892 => OK > > OrangePi 3 - HA047BA 69W2 => KO > > OrangePi One Plus - H7310BA 6842 => KO > > OrangePi Lite2 - H6448BA 6662 => KO > > > > Clément Péron board: > > Beelink GS1 - H7309BA 6842 => KO > > > > As it seems not fixable for now, declare the node > > but leave it disable with a comment. > > > > Signed-off-by: Clément Péron <peron.clem@gmail.com> > > If it doesn't work most boards, then why do we need to merge that > patch in the first place? My personnal opinion, is that having the IP declared and disabled with a comment saying "it's broken on some boards" in the device-tree is better than not having at all. This will explicit say "the IP exist but don't use it!". Maybe some people with a functionnal board would like to explicitly use it on their dts. Again just my personnal opinion, Thanks for the review, Clément > > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com
On Mon, May 20, 2019 at 10:21:40AM +0200, Clément Péron wrote: > Hi, > > On Mon, 20 May 2019 at 09:36, Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > > > On Sat, May 18, 2019 at 05:23:53PM +0200, Clément Péron wrote: > > > Allwinner H6 has a watchog node which seems broken > > > on some boards. > > > > > > Test has been performed on several boards. > > > > > > Chen-Yu Tsai boards: > > > Pine H64 - H6448BA 7782 => OK > > > OrangePi Lite 2 - H8068BA 61C2 => KO > > > > > > Martin Ayotte boards: > > > Pine H64 - H8069BA 6892 => OK > > > OrangePi 3 - HA047BA 69W2 => KO > > > OrangePi One Plus - H7310BA 6842 => KO > > > OrangePi Lite2 - H6448BA 6662 => KO > > > > > > Clément Péron board: > > > Beelink GS1 - H7309BA 6842 => KO > > > > > > As it seems not fixable for now, declare the node > > > but leave it disable with a comment. > > > > > > Signed-off-by: Clément Péron <peron.clem@gmail.com> > > > > If it doesn't work most boards, then why do we need to merge that > > patch in the first place? > > My personnal opinion, is that having the IP declared and disabled with > a comment saying "it's broken on some boards" in the device-tree is > better than not having at all. > > This will explicit say "the IP exist but don't use it!". > Maybe some people with a functionnal board would like to explicitly > use it on their dts. Yeah, that makes sense. Chen-Yu, any opinion on the matter? Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
On Mon, May 20, 2019 at 10:44 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > On Mon, May 20, 2019 at 10:21:40AM +0200, Clément Péron wrote: > > Hi, > > > > On Mon, 20 May 2019 at 09:36, Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > > > > > On Sat, May 18, 2019 at 05:23:53PM +0200, Clément Péron wrote: > > > > Allwinner H6 has a watchog node which seems broken > > > > on some boards. > > > > > > > > Test has been performed on several boards. > > > > > > > > Chen-Yu Tsai boards: > > > > Pine H64 - H6448BA 7782 => OK > > > > OrangePi Lite 2 - H8068BA 61C2 => KO > > > > > > > > Martin Ayotte boards: > > > > Pine H64 - H8069BA 6892 => OK > > > > OrangePi 3 - HA047BA 69W2 => KO > > > > OrangePi One Plus - H7310BA 6842 => KO > > > > OrangePi Lite2 - H6448BA 6662 => KO > > > > > > > > Clément Péron board: > > > > Beelink GS1 - H7309BA 6842 => KO > > > > > > > > As it seems not fixable for now, declare the node > > > > but leave it disable with a comment. > > > > > > > > Signed-off-by: Clément Péron <peron.clem@gmail.com> > > > > > > If it doesn't work most boards, then why do we need to merge that > > > patch in the first place? > > > > My personnal opinion, is that having the IP declared and disabled with > > a comment saying "it's broken on some boards" in the device-tree is > > better than not having at all. > > > > This will explicit say "the IP exist but don't use it!". > > Maybe some people with a functionnal board would like to explicitly > > use it on their dts. > > Yeah, that makes sense. Chen-Yu, any opinion on the matter? Works for me.
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi index 16c5c3d0fd81..60b47f23b2f5 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi @@ -208,6 +208,16 @@ reg = <0x03006000 0x400>; }; + watchdog: watchdog@30090a0 { + compatible = "allwinner,sun50i-h6-wdt", + "allwinner,sun50i-a64-wdt", + "allwinner,sun6i-a31-wdt"; + reg = <0x030090a0 0x20>; + interrupts = <GIC_SPI 50 IRQ_TYPE_LEVEL_HIGH>; + /* Broken on some H6 boards */ + status = "disabled"; + }; + pio: pinctrl@300b000 { compatible = "allwinner,sun50i-h6-pinctrl"; reg = <0x0300b000 0x400>;
Allwinner H6 has a watchog node which seems broken on some boards. Test has been performed on several boards. Chen-Yu Tsai boards: Pine H64 - H6448BA 7782 => OK OrangePi Lite 2 - H8068BA 61C2 => KO Martin Ayotte boards: Pine H64 - H8069BA 6892 => OK OrangePi 3 - HA047BA 69W2 => KO OrangePi One Plus - H7310BA 6842 => KO OrangePi Lite2 - H6448BA 6662 => KO Clément Péron board: Beelink GS1 - H7309BA 6842 => KO As it seems not fixable for now, declare the node but leave it disable with a comment. Signed-off-by: Clément Péron <peron.clem@gmail.com> --- arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)