| Message ID | 20190518212801.31010-14-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | watchdog: move 'registration failed' messages into core | expand |
On Sat, May 18, 2019 at 11:27:28PM +0200, Wolfram Sang wrote: > The core will print out details now. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > drivers/watchdog/hpwdt.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > Reviewed-by: Jerry Hoemann <jerry.hoemann@hpe.com> > diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c > index db1bf6f546ae..e0ebfba50aab 100644 > --- a/drivers/watchdog/hpwdt.c > +++ b/drivers/watchdog/hpwdt.c > @@ -321,10 +321,8 @@ static int hpwdt_init_one(struct pci_dev *dev, > > hpwdt_dev.parent = &dev->dev; > retval = watchdog_register_device(&hpwdt_dev); > - if (retval < 0) { > - dev_err(&dev->dev, "watchdog register failed: %d.\n", retval); > + if (retval < 0) > goto error_wd_register; > - } > > dev_info(&dev->dev, "HPE Watchdog Timer Driver: Version: %s\n", > HPWDT_VERSION); > -- > 2.19.1
diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c index db1bf6f546ae..e0ebfba50aab 100644 --- a/drivers/watchdog/hpwdt.c +++ b/drivers/watchdog/hpwdt.c @@ -321,10 +321,8 @@ static int hpwdt_init_one(struct pci_dev *dev, hpwdt_dev.parent = &dev->dev; retval = watchdog_register_device(&hpwdt_dev); - if (retval < 0) { - dev_err(&dev->dev, "watchdog register failed: %d.\n", retval); + if (retval < 0) goto error_wd_register; - } dev_info(&dev->dev, "HPE Watchdog Timer Driver: Version: %s\n", HPWDT_VERSION);
The core will print out details now. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- drivers/watchdog/hpwdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)