| Message ID | 20190821143835.7294-1-mripard@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [RESEND,v2,1/6] dt-bindings: watchdog: Add YAML schemas for the generic watchdog bindings | expand |
On Wed, Aug 21, 2019 at 04:38:30PM +0200, Maxime Ripard wrote: > From: Maxime Ripard <maxime.ripard@bootlin.com> > > The watchdogs have a bunch of generic properties that are needed in a > device tree. Add a YAML schemas for those. > > Reviewed-by: Rob Herring <robh@kernel.org> > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com> Ping? Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
On Wed, Aug 21, 2019 at 04:38:30PM +0200, Maxime Ripard wrote: > From: Maxime Ripard <maxime.ripard@bootlin.com> > > The watchdogs have a bunch of generic properties that are needed in a > device tree. Add a YAML schemas for those. > > Reviewed-by: Rob Herring <robh@kernel.org> > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net> > > --- > > Changes from v1: > - New patch > --- > .../bindings/watchdog/watchdog.yaml | 26 +++++++++++++++++++ > 1 file changed, 26 insertions(+) > create mode 100644 Documentation/devicetree/bindings/watchdog/watchdog.yaml > > diff --git a/Documentation/devicetree/bindings/watchdog/watchdog.yaml b/Documentation/devicetree/bindings/watchdog/watchdog.yaml > new file mode 100644 > index 000000000000..187bf6cb62bf > --- /dev/null > +++ b/Documentation/devicetree/bindings/watchdog/watchdog.yaml > @@ -0,0 +1,26 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/watchdog/watchdog.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Watchdog Generic Bindings > + > +maintainers: > + - Guenter Roeck <linux@roeck-us.net> > + - Wim Van Sebroeck <wim@linux-watchdog.org> > + > +description: | > + This document describes generic bindings which can be used to > + describe watchdog devices in a device tree. > + > +properties: > + $nodename: > + pattern: "^watchdog(@.*|-[0-9a-f])?$" > + > + timeout-sec: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Contains the watchdog timeout in seconds. > + > +... > -- > 2.21.0 >
Hi Guenther, On Fri, Aug 30, 2019 at 09:48:11AM -0700, Guenter Roeck wrote: > On Wed, Aug 21, 2019 at 04:38:30PM +0200, Maxime Ripard wrote: > > From: Maxime Ripard <maxime.ripard@bootlin.com> > > > > The watchdogs have a bunch of generic properties that are needed in a > > device tree. Add a YAML schemas for those. > > > > Reviewed-by: Rob Herring <robh@kernel.org> > > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com> > > Reviewed-by: Guenter Roeck <linux@roeck-us.net> Thanks for reviewing this, which tree should this go through? Yours or Rob's? Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
On 9/2/19 4:46 AM, Maxime Ripard wrote: > Hi Guenther, > > On Fri, Aug 30, 2019 at 09:48:11AM -0700, Guenter Roeck wrote: >> On Wed, Aug 21, 2019 at 04:38:30PM +0200, Maxime Ripard wrote: >>> From: Maxime Ripard <maxime.ripard@bootlin.com> >>> >>> The watchdogs have a bunch of generic properties that are needed in a >>> device tree. Add a YAML schemas for those. >>> >>> Reviewed-by: Rob Herring <robh@kernel.org> >>> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com> >> >> Reviewed-by: Guenter Roeck <linux@roeck-us.net> > > Thanks for reviewing this, which tree should this go through? Yours or Rob's? > I added the watchdog patches to my watchdog-next tree, where Wim usually pick them up. I would be ok with Rob picking them up too if he wants to. Guenter
diff --git a/Documentation/devicetree/bindings/watchdog/watchdog.yaml b/Documentation/devicetree/bindings/watchdog/watchdog.yaml new file mode 100644 index 000000000000..187bf6cb62bf --- /dev/null +++ b/Documentation/devicetree/bindings/watchdog/watchdog.yaml @@ -0,0 +1,26 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/watchdog/watchdog.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Watchdog Generic Bindings + +maintainers: + - Guenter Roeck <linux@roeck-us.net> + - Wim Van Sebroeck <wim@linux-watchdog.org> + +description: | + This document describes generic bindings which can be used to + describe watchdog devices in a device tree. + +properties: + $nodename: + pattern: "^watchdog(@.*|-[0-9a-f])?$" + + timeout-sec: + $ref: /schemas/types.yaml#/definitions/uint32 + description: + Contains the watchdog timeout in seconds. + +...