diff mbox series

drivers: watchdog: ts72xx_wdt: fix build error

Message ID 20200406215008.30468-1-shyam.saini@savoirfairelinux.com (mailing list archive)
State Accepted
Headers show
Series drivers: watchdog: ts72xx_wdt: fix build error | expand

Commit Message

Shyam Saini April 6, 2020, 9:50 p.m. UTC
If TS72XX_WATCHDOG is y and WATCHDOG_CORE is not enabled or its m,
then building fails:

drivers/watchdog/ts72xx_wdt.o: in function `ts72xx_wdt_probe':
	ts72xx_wdt.c:(.text+0x14c): undefined reference to \
	`watchdog_init_timeout'
	ts72xx_wdt.c:(.text+0x15c): undefined reference to \
	`devm_watchdog_register_device'

Select WATCHDOG_CORE to fix this.

Signed-off-by: Shyam Saini <shyam.saini@savoirfairelinux.com>
---
 drivers/watchdog/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Guenter Roeck April 6, 2020, 10:42 p.m. UTC | #1
On 4/6/20 2:50 PM, Shyam Saini wrote:
> If TS72XX_WATCHDOG is y and WATCHDOG_CORE is not enabled or its m,
> then building fails:
> 
> drivers/watchdog/ts72xx_wdt.o: in function `ts72xx_wdt_probe':
> 	ts72xx_wdt.c:(.text+0x14c): undefined reference to \
> 	`watchdog_init_timeout'
> 	ts72xx_wdt.c:(.text+0x15c): undefined reference to \
> 	`devm_watchdog_register_device'
> 
> Select WATCHDOG_CORE to fix this.
> 
> Signed-off-by: Shyam Saini <shyam.saini@savoirfairelinux.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  drivers/watchdog/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index cec868f8db3f..62da6e903336 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -669,6 +669,7 @@ config TS4800_WATCHDOG
>  config TS72XX_WATCHDOG
>  	tristate "TS-72XX SBC Watchdog"
>  	depends on MACH_TS72XX || COMPILE_TEST
> +	select WATCHDOG_CORE
>  	help
>  	  Technologic Systems TS-7200, TS-7250 and TS-7260 boards have
>  	  watchdog timer implemented in a external CPLD chip. Say Y here
>
diff mbox series

Patch

diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
index cec868f8db3f..62da6e903336 100644
--- a/drivers/watchdog/Kconfig
+++ b/drivers/watchdog/Kconfig
@@ -669,6 +669,7 @@  config TS4800_WATCHDOG
 config TS72XX_WATCHDOG
 	tristate "TS-72XX SBC Watchdog"
 	depends on MACH_TS72XX || COMPILE_TEST
+	select WATCHDOG_CORE
 	help
 	  Technologic Systems TS-7200, TS-7250 and TS-7260 boards have
 	  watchdog timer implemented in a external CPLD chip. Say Y here