diff mbox series

watchdog: mlx-wdt: Use regmap_write_bits()

Message ID 20210907092732.31815-1-p.zabel@pengutronix.de (mailing list archive)
State Accepted
Headers show
Series watchdog: mlx-wdt: Use regmap_write_bits() | expand

Commit Message

Philipp Zabel Sept. 7, 2021, 9:27 a.m. UTC
Use the regmap_write_bits() macro instead of regmap_update_bits_base().
No functional change.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
 drivers/watchdog/mlx_wdt.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Guenter Roeck Sept. 7, 2021, 12:40 p.m. UTC | #1
On Tue, Sep 07, 2021 at 11:27:32AM +0200, Philipp Zabel wrote:
> Use the regmap_write_bits() macro instead of regmap_update_bits_base().
> No functional change.
> 
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  drivers/watchdog/mlx_wdt.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/watchdog/mlx_wdt.c b/drivers/watchdog/mlx_wdt.c
> index 54193369e85c..9c5b6616fc87 100644
> --- a/drivers/watchdog/mlx_wdt.c
> +++ b/drivers/watchdog/mlx_wdt.c
> @@ -100,9 +100,8 @@ static int mlxreg_wdt_ping(struct watchdog_device *wdd)
>  	struct mlxreg_wdt *wdt = watchdog_get_drvdata(wdd);
>  	struct mlxreg_core_data *reg_data = &wdt->pdata->data[wdt->ping_idx];
>  
> -	return regmap_update_bits_base(wdt->regmap, reg_data->reg,
> -				       ~reg_data->mask, BIT(reg_data->bit),
> -				       NULL, false, true);
> +	return regmap_write_bits(wdt->regmap, reg_data->reg, ~reg_data->mask,
> +				 BIT(reg_data->bit));
>  }
>  
>  static int mlxreg_wdt_set_timeout(struct watchdog_device *wdd,
> -- 
> 2.30.2
>
diff mbox series

Patch

diff --git a/drivers/watchdog/mlx_wdt.c b/drivers/watchdog/mlx_wdt.c
index 54193369e85c..9c5b6616fc87 100644
--- a/drivers/watchdog/mlx_wdt.c
+++ b/drivers/watchdog/mlx_wdt.c
@@ -100,9 +100,8 @@  static int mlxreg_wdt_ping(struct watchdog_device *wdd)
 	struct mlxreg_wdt *wdt = watchdog_get_drvdata(wdd);
 	struct mlxreg_core_data *reg_data = &wdt->pdata->data[wdt->ping_idx];
 
-	return regmap_update_bits_base(wdt->regmap, reg_data->reg,
-				       ~reg_data->mask, BIT(reg_data->bit),
-				       NULL, false, true);
+	return regmap_write_bits(wdt->regmap, reg_data->reg, ~reg_data->mask,
+				 BIT(reg_data->bit));
 }
 
 static int mlxreg_wdt_set_timeout(struct watchdog_device *wdd,