| Message ID | 20211104160858.15550-3-biju.das.jz@bp.renesas.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add WDT driver for RZ/G2L | expand |
Hi Biju, On Thu, Nov 4, 2021 at 5:09 PM Biju Das <biju.das.jz@bp.renesas.com> wrote: > Describe the WDT hardware in the RZ/G2L series. > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Thanks for your patch! > --- a/Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml > +++ b/Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml > @@ -75,17 +79,49 @@ required: > - reg > - clocks > > -if: > - not: > - properties: > - compatible: > - contains: > - enum: > - - renesas,rza-wdt > -then: > - required: > - - power-domains > - - resets > +allOf: > + - $ref: "watchdog.yaml#" > + > + - if: > + not: > + properties: > + compatible: > + contains: > + enum: > + - renesas,rza-wdt > + then: > + required: > + - power-domains > + - resets > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - renesas,rzg2l-wdt > + then: > + properties: > + interrupts: > + maxItems: 2 > + interrupt-names: > + items: > + - const: wdt > + - const: perrout > + clocks: > + items: > + - description: Main clock > + - description: Register access clock > + clock-names: > + items: > + - const: oscclk > + - const: pclk Usually we put the internal module clock first. Please add (at least the first one): required: - clock-names - interrupt-names > + else: > + properties: > + interrupts: > + maxItems: 1 > + clocks: > + maxItems: 1 > > additionalProperties: false Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert, Thanks for the feedback. > Subject: Re: [RFC 2/4] dt-bindings: watchdog: renesas,wdt: Add support for > RZ/G2L > > Hi Biju, > > On Thu, Nov 4, 2021 at 5:09 PM Biju Das <biju.das.jz@bp.renesas.com> > wrote: > > Describe the WDT hardware in the RZ/G2L series. > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > Thanks for your patch! > > > --- a/Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml > > +++ b/Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml > > > @@ -75,17 +79,49 @@ required: > > - reg > > - clocks > > > > -if: > > - not: > > - properties: > > - compatible: > > - contains: > > - enum: > > - - renesas,rza-wdt > > -then: > > - required: > > - - power-domains > > - - resets > > +allOf: > > + - $ref: "watchdog.yaml#" > > + > > + - if: > > + not: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - renesas,rza-wdt > > + then: > > + required: > > + - power-domains > > + - resets > > + > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - renesas,rzg2l-wdt > > + then: > > + properties: > > + interrupts: > > + maxItems: 2 > > + interrupt-names: > > + items: > > + - const: wdt > > + - const: perrout > > + clocks: > > + items: > > + - description: Main clock > > + - description: Register access clock > > + clock-names: > > + items: > > + - const: oscclk > > + - const: pclk > > Usually we put the internal module clock first. OK. Will put internal module clock first. > > Please add (at least the first one): > > required: > - clock-names > - interrupt-names Ok, will add the same. Regards, Biju > > > + else: > > + properties: > > + interrupts: > > + maxItems: 1 > > + clocks: > > + maxItems: 1 > > > > additionalProperties: false > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux- > m68k.org > > In personal conversations with technical people, I call myself a hacker. > But when I'm talking to journalists I just say "programmer" or something > like that. > -- Linus Torvalds
diff --git a/Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml b/Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml index ab66d3f0c476..f9f7f7207d6d 100644 --- a/Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml +++ b/Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml @@ -10,9 +10,6 @@ maintainers: - Wolfram Sang <wsa+renesas@sang-engineering.com> - Geert Uytterhoeven <geert+renesas@glider.be> -allOf: - - $ref: "watchdog.yaml#" - properties: compatible: oneOf: @@ -22,6 +19,11 @@ properties: - renesas,r7s9210-wdt # RZ/A2 - const: renesas,rza-wdt # RZ/A + - items: + - enum: + - renesas,r9a07g044-wdt # RZ/G2{L,LC} + - const: renesas,rzg2l-wdt # RZ/G2L + - items: - enum: - renesas,r8a7742-wdt # RZ/G1H @@ -56,11 +58,13 @@ properties: reg: maxItems: 1 - interrupts: - maxItems: 1 + interrupts: true - clocks: - maxItems: 1 + interrupt-names: true + + clocks: true + + clock-names: true power-domains: maxItems: 1 @@ -75,17 +79,49 @@ required: - reg - clocks -if: - not: - properties: - compatible: - contains: - enum: - - renesas,rza-wdt -then: - required: - - power-domains - - resets +allOf: + - $ref: "watchdog.yaml#" + + - if: + not: + properties: + compatible: + contains: + enum: + - renesas,rza-wdt + then: + required: + - power-domains + - resets + + - if: + properties: + compatible: + contains: + enum: + - renesas,rzg2l-wdt + then: + properties: + interrupts: + maxItems: 2 + interrupt-names: + items: + - const: wdt + - const: perrout + clocks: + items: + - description: Main clock + - description: Register access clock + clock-names: + items: + - const: oscclk + - const: pclk + else: + properties: + interrupts: + maxItems: 1 + clocks: + maxItems: 1 additionalProperties: false
Describe the WDT hardware in the RZ/G2L series. Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> --- .../bindings/watchdog/renesas,wdt.yaml | 72 ++++++++++++++----- 1 file changed, 54 insertions(+), 18 deletions(-)