diff mbox series

[3/4] dt-bindings: reset: mt8186: add DSI reset bit for MMSYS

Message ID 20220216014505.28428-4-rex-bc.chen@mediatek.com (mailing list archive)
State Superseded
Headers show
Series [1/4] dt-bindings: watchdog: Add compatible for MediaTek MT8186 | expand

Commit Message

Rex-BC Chen (陳柏辰) Feb. 16, 2022, 1:45 a.m. UTC 
Add DSI software reset bit which is controlled by MMSYS for MT8186.

Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
---
 include/dt-bindings/reset/mt8186-resets.h | 3 +++
 1 file changed, 3 insertions(+)

Comments

Rob Herring (Arm) Feb. 25, 2022, 4:26 p.m. UTC | #1 
On Wed, Feb 16, 2022 at 09:45:04AM +0800, Rex-BC Chen wrote:
> Add DSI software reset bit which is controlled by MMSYS for MT8186.
> 
> Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> ---
>  include/dt-bindings/reset/mt8186-resets.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/dt-bindings/reset/mt8186-resets.h b/include/dt-bindings/reset/mt8186-resets.h
> index 36e5764e2e6c..5f850370c42c 100644
> --- a/include/dt-bindings/reset/mt8186-resets.h
> +++ b/include/dt-bindings/reset/mt8186-resets.h
> @@ -30,4 +30,7 @@
>  #define MT8186_TOPRGU_IMG2_SW_RST				22
>  #define MT8186_TOPRGU_SW_RST_NUM				23
>  
> +/* MMSYS resets */
> +#define MT8186_MMSYS_SW0_RST_B_DISP_DSI0			19

This can just be squashed into the previous patch.

> +
>  #endif  /* _DT_BINDINGS_RESET_CONTROLLER_MT8186 */
> -- 
> 2.18.0
> 
>
Rex-BC Chen (陳柏辰) March 1, 2022, 2:54 a.m. UTC | #2 
Hello Rob,

Thanks for your review.
I will do this in next version.

BRs,
Rex

On Fri, 2022-02-25 at 10:26 -0600, Rob Herring wrote:
> On Wed, Feb 16, 2022 at 09:45:04AM +0800, Rex-BC Chen wrote:
> > Add DSI software reset bit which is controlled by MMSYS for MT8186.
> > 
> > Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> > ---
> >  include/dt-bindings/reset/mt8186-resets.h | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/include/dt-bindings/reset/mt8186-resets.h
> > b/include/dt-bindings/reset/mt8186-resets.h
> > index 36e5764e2e6c..5f850370c42c 100644
> > --- a/include/dt-bindings/reset/mt8186-resets.h
> > +++ b/include/dt-bindings/reset/mt8186-resets.h
> > @@ -30,4 +30,7 @@
> >  #define MT8186_TOPRGU_IMG2_SW_RST				22
> >  #define MT8186_TOPRGU_SW_RST_NUM				23
> >  
> > +/* MMSYS resets */
> > +#define MT8186_MMSYS_SW0_RST_B_DISP_DSI0			19
> 
> This can just be squashed into the previous patch.
> 
> > +
> >  #endif  /* _DT_BINDINGS_RESET_CONTROLLER_MT8186 */
> > -- 
> > 2.18.0
> > 
> >
diff mbox series

Patch

diff --git a/include/dt-bindings/reset/mt8186-resets.h b/include/dt-bindings/reset/mt8186-resets.h
index 36e5764e2e6c..5f850370c42c 100644
--- a/include/dt-bindings/reset/mt8186-resets.h
+++ b/include/dt-bindings/reset/mt8186-resets.h
@@ -30,4 +30,7 @@ 
 #define MT8186_TOPRGU_IMG2_SW_RST				22
 #define MT8186_TOPRGU_SW_RST_NUM				23
 
+/* MMSYS resets */
+#define MT8186_MMSYS_SW0_RST_B_DISP_DSI0			19
+
 #endif  /* _DT_BINDINGS_RESET_CONTROLLER_MT8186 */