diff mbox series

[v3] dt-bindings: watchdog: toshiba,visconti-wdt: Update the common clock properties

Message ID 20220525004605.2128727-1-nobuhiro1.iwamatsu@toshiba.co.jp (mailing list archive)
State Accepted
Headers show
Series [v3] dt-bindings: watchdog: toshiba,visconti-wdt: Update the common clock properties | expand

Commit Message

Nobuhiro Iwamatsu May 25, 2022, 12:46 a.m. UTC
The clock for this driver switched to the common clock controller driver.
Therefore, update common clock properties for watchdog in the binding document.
And this matched this example with the actual dts.

Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
Acked-by: Rob Herring <robh@kernel.org>
---

 v3: doesn't remove timeout-sec.
 v2: send to linux-watchdog.

 .../bindings/watchdog/toshiba,visconti-wdt.yaml      | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

Comments

Guenter Roeck Sept. 25, 2022, 2:29 p.m. UTC | #1
On Wed, May 25, 2022 at 09:46:05AM +0900, Nobuhiro Iwamatsu wrote:
> The clock for this driver switched to the common clock controller driver.
> Therefore, update common clock properties for watchdog in the binding document.
> And this matched this example with the actual dts.
> 
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
> Acked-by: Rob Herring <robh@kernel.org>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
> 
>  v3: doesn't remove timeout-sec.
>  v2: send to linux-watchdog.
> 
>  .../bindings/watchdog/toshiba,visconti-wdt.yaml      | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml b/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml
> index 690e19ce4b87..eba083822d1f 100644
> --- a/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml
> @@ -35,20 +35,16 @@ additionalProperties: false
>  
>  examples:
>    - |
> +    #include <dt-bindings/clock/toshiba,tmpv770x.h>
> +
>      soc {
>          #address-cells = <2>;
>          #size-cells = <2>;
>  
> -        wdt_clk: wdt-clk {
> -            compatible = "fixed-clock";
> -            clock-frequency = <150000000>;
> -            #clock-cells = <0>;
> -        };
> -
> -        watchdog@28330000 {
> +        wdt: watchdog@28330000 {
>              compatible = "toshiba,visconti-wdt";
>              reg = <0 0x28330000 0 0x1000>;
> -            clocks = <&wdt_clk>;
>              timeout-sec = <20>;
> +            clocks = <&pismu TMPV770X_CLK_WDTCLK>;
>          };
>      };
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml b/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml
index 690e19ce4b87..eba083822d1f 100644
--- a/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml
@@ -35,20 +35,16 @@  additionalProperties: false
 
 examples:
   - |
+    #include <dt-bindings/clock/toshiba,tmpv770x.h>
+
     soc {
         #address-cells = <2>;
         #size-cells = <2>;
 
-        wdt_clk: wdt-clk {
-            compatible = "fixed-clock";
-            clock-frequency = <150000000>;
-            #clock-cells = <0>;
-        };
-
-        watchdog@28330000 {
+        wdt: watchdog@28330000 {
             compatible = "toshiba,visconti-wdt";
             reg = <0 0x28330000 0 0x1000>;
-            clocks = <&wdt_clk>;
             timeout-sec = <20>;
+            clocks = <&pismu TMPV770X_CLK_WDTCLK>;
         };
     };