| Message ID | 20220926162549.805108-1-sergio.paracuellos@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [RESEND,v2] dt-bindings: watchdog: migrate mt7621 text bindings to YAML | expand |
On Mon, Sep 26, 2022 at 06:25:49PM +0200, Sergio Paracuellos wrote: > Soc Mt7621 Watchdog bindings used text format, so migrate them to YAML. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net> > --- > Changes in v2 RESEND: > - Resent sending also to watchdog maintainers. > > Changes in v2: > - Rebase onto last kernel version. > - Add Krzysztof Reviewed-by tag.º > > .../watchdog/mediatek,mt7621-wdt.yaml | 33 +++++++++++++++++++ > .../bindings/watchdog/mt7621-wdt.txt | 12 ------- > 2 files changed, 33 insertions(+), 12 deletions(-) > create mode 100644 Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml > delete mode 100644 Documentation/devicetree/bindings/watchdog/mt7621-wdt.txt > > diff --git a/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml b/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml > new file mode 100644 > index 000000000000..b2b17fdf4e39 > --- /dev/null > +++ b/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml > @@ -0,0 +1,33 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/watchdog/mediatek,mt7621-wdt.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Ralink Watchdog Timers > + > +maintainers: > + - Sergio Paracuellos <sergio.paracuellos@gmail.com> > + > +allOf: > + - $ref: watchdog.yaml# > + > +properties: > + compatible: > + const: mediatek,mt7621-wdt > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + watchdog@100 { > + compatible = "mediatek,mt7621-wdt"; > + reg = <0x100 0x100>; > + }; > diff --git a/Documentation/devicetree/bindings/watchdog/mt7621-wdt.txt b/Documentation/devicetree/bindings/watchdog/mt7621-wdt.txt > deleted file mode 100644 > index c15ef0ef609f..000000000000 > --- a/Documentation/devicetree/bindings/watchdog/mt7621-wdt.txt > +++ /dev/null > @@ -1,12 +0,0 @@ > -Ralink Watchdog Timers > - > -Required properties: > -- compatible: must be "mediatek,mt7621-wdt" > -- reg: physical base address of the controller and length of the register range > - > -Example: > - > - watchdog@100 { > - compatible = "mediatek,mt7621-wdt"; > - reg = <0x100 0x10>; > - };
On Mon, Sep 26, 2022 at 11:16 PM Guenter Roeck <linux@roeck-us.net> wrote: > > On Mon, Sep 26, 2022 at 06:25:49PM +0200, Sergio Paracuellos wrote: > > Soc Mt7621 Watchdog bindings used text format, so migrate them to YAML. > > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> > > Reviewed-by: Guenter Roeck <linux@roeck-us.net> Thanks, Guenter! Rob, I don't know why this patch is not in devicetree patchwork list... Please let me know if you want me to resend this again. Thanks, Sergio Paracuellos > > > --- > > Changes in v2 RESEND: > > - Resent sending also to watchdog maintainers. > > > > Changes in v2: > > - Rebase onto last kernel version. > > - Add Krzysztof Reviewed-by tag.º > > > > .../watchdog/mediatek,mt7621-wdt.yaml | 33 +++++++++++++++++++ > > .../bindings/watchdog/mt7621-wdt.txt | 12 ------- > > 2 files changed, 33 insertions(+), 12 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml > > delete mode 100644 Documentation/devicetree/bindings/watchdog/mt7621-wdt.txt > > > > diff --git a/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml b/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml > > new file mode 100644 > > index 000000000000..b2b17fdf4e39 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml > > @@ -0,0 +1,33 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/watchdog/mediatek,mt7621-wdt.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Ralink Watchdog Timers > > + > > +maintainers: > > + - Sergio Paracuellos <sergio.paracuellos@gmail.com> > > + > > +allOf: > > + - $ref: watchdog.yaml# > > + > > +properties: > > + compatible: > > + const: mediatek,mt7621-wdt > > + > > + reg: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + watchdog@100 { > > + compatible = "mediatek,mt7621-wdt"; > > + reg = <0x100 0x100>; > > + }; > > diff --git a/Documentation/devicetree/bindings/watchdog/mt7621-wdt.txt b/Documentation/devicetree/bindings/watchdog/mt7621-wdt.txt > > deleted file mode 100644 > > index c15ef0ef609f..000000000000 > > --- a/Documentation/devicetree/bindings/watchdog/mt7621-wdt.txt > > +++ /dev/null > > @@ -1,12 +0,0 @@ > > -Ralink Watchdog Timers > > - > > -Required properties: > > -- compatible: must be "mediatek,mt7621-wdt" > > -- reg: physical base address of the controller and length of the register range > > - > > -Example: > > - > > - watchdog@100 { > > - compatible = "mediatek,mt7621-wdt"; > > - reg = <0x100 0x10>; > > - };
On Tue, Sep 27, 2022 at 10:24 AM Sergio Paracuellos <sergio.paracuellos@gmail.com> wrote: > > On Mon, Sep 26, 2022 at 11:16 PM Guenter Roeck <linux@roeck-us.net> wrote: > > > > On Mon, Sep 26, 2022 at 06:25:49PM +0200, Sergio Paracuellos wrote: > > > Soc Mt7621 Watchdog bindings used text format, so migrate them to YAML. > > > > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> > > > > Reviewed-by: Guenter Roeck <linux@roeck-us.net> > > Thanks, Guenter! > > Rob, I don't know why this patch is not in devicetree patchwork list... > > Please let me know if you want me to resend this again. > > Thanks, > Sergio Paracuellos I guess this patch is supposed to go through the watchdog tree?? Thanks in advance for clarification. Best regards, Sergio Paracuellos > > > > > > --- > > > Changes in v2 RESEND: > > > - Resent sending also to watchdog maintainers. > > > > > > Changes in v2: > > > - Rebase onto last kernel version. > > > - Add Krzysztof Reviewed-by tag.º > > > > > > .../watchdog/mediatek,mt7621-wdt.yaml | 33 +++++++++++++++++++ > > > .../bindings/watchdog/mt7621-wdt.txt | 12 ------- > > > 2 files changed, 33 insertions(+), 12 deletions(-) > > > create mode 100644 Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml > > > delete mode 100644 Documentation/devicetree/bindings/watchdog/mt7621-wdt.txt > > > > > > diff --git a/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml b/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml > > > new file mode 100644 > > > index 000000000000..b2b17fdf4e39 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml > > > @@ -0,0 +1,33 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/watchdog/mediatek,mt7621-wdt.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Ralink Watchdog Timers > > > + > > > +maintainers: > > > + - Sergio Paracuellos <sergio.paracuellos@gmail.com> > > > + > > > +allOf: > > > + - $ref: watchdog.yaml# > > > + > > > +properties: > > > + compatible: > > > + const: mediatek,mt7621-wdt > > > + > > > + reg: > > > + maxItems: 1 > > > + > > > +required: > > > + - compatible > > > + - reg > > > + > > > +additionalProperties: false > > > + > > > +examples: > > > + - | > > > + watchdog@100 { > > > + compatible = "mediatek,mt7621-wdt"; > > > + reg = <0x100 0x100>; > > > + }; > > > diff --git a/Documentation/devicetree/bindings/watchdog/mt7621-wdt.txt b/Documentation/devicetree/bindings/watchdog/mt7621-wdt.txt > > > deleted file mode 100644 > > > index c15ef0ef609f..000000000000 > > > --- a/Documentation/devicetree/bindings/watchdog/mt7621-wdt.txt > > > +++ /dev/null > > > @@ -1,12 +0,0 @@ > > > -Ralink Watchdog Timers > > > - > > > -Required properties: > > > -- compatible: must be "mediatek,mt7621-wdt" > > > -- reg: physical base address of the controller and length of the register range > > > - > > > -Example: > > > - > > > - watchdog@100 { > > > - compatible = "mediatek,mt7621-wdt"; > > > - reg = <0x100 0x10>; > > > - };
On 9/29/22 10:26, Sergio Paracuellos wrote: > On Tue, Sep 27, 2022 at 10:24 AM Sergio Paracuellos > <sergio.paracuellos@gmail.com> wrote: >> >> On Mon, Sep 26, 2022 at 11:16 PM Guenter Roeck <linux@roeck-us.net> wrote: >>> >>> On Mon, Sep 26, 2022 at 06:25:49PM +0200, Sergio Paracuellos wrote: >>>> Soc Mt7621 Watchdog bindings used text format, so migrate them to YAML. >>>> >>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> >>> >>> Reviewed-by: Guenter Roeck <linux@roeck-us.net> >> >> Thanks, Guenter! >> >> Rob, I don't know why this patch is not in devicetree patchwork list... >> >> Please let me know if you want me to resend this again. >> >> Thanks, >> Sergio Paracuellos > > I guess this patch is supposed to go through the watchdog tree?? > > Thanks in advance for clarification. > Normally patches like this would be pushed through the watchdog tree. I added it to my watchdog-next branch, and usually Wim would pick it up from there. Note that I don't really care; either way is fine with me. Guenter
On Sun, Oct 2, 2022 at 6:35 PM Guenter Roeck <linux@roeck-us.net> wrote: > > On 9/29/22 10:26, Sergio Paracuellos wrote: > > On Tue, Sep 27, 2022 at 10:24 AM Sergio Paracuellos > > <sergio.paracuellos@gmail.com> wrote: > >> > >> On Mon, Sep 26, 2022 at 11:16 PM Guenter Roeck <linux@roeck-us.net> wrote: > >>> > >>> On Mon, Sep 26, 2022 at 06:25:49PM +0200, Sergio Paracuellos wrote: > >>>> Soc Mt7621 Watchdog bindings used text format, so migrate them to YAML. > >>>> > >>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >>>> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> > >>> > >>> Reviewed-by: Guenter Roeck <linux@roeck-us.net> > >> > >> Thanks, Guenter! > >> > >> Rob, I don't know why this patch is not in devicetree patchwork list... > >> > >> Please let me know if you want me to resend this again. > >> > >> Thanks, > >> Sergio Paracuellos > > > > I guess this patch is supposed to go through the watchdog tree?? > > > > Thanks in advance for clarification. > > > > Normally patches like this would be pushed through the watchdog tree. > I added it to my watchdog-next branch, and usually Wim would > pick it up from there. Note that I don't really care; either way > is fine with me. Thanks, for letting me know, Guenter. Best regards, Sergio Paracuellos > > Guenter
diff --git a/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml b/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml new file mode 100644 index 000000000000..b2b17fdf4e39 --- /dev/null +++ b/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml @@ -0,0 +1,33 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/watchdog/mediatek,mt7621-wdt.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Ralink Watchdog Timers + +maintainers: + - Sergio Paracuellos <sergio.paracuellos@gmail.com> + +allOf: + - $ref: watchdog.yaml# + +properties: + compatible: + const: mediatek,mt7621-wdt + + reg: + maxItems: 1 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + watchdog@100 { + compatible = "mediatek,mt7621-wdt"; + reg = <0x100 0x100>; + }; diff --git a/Documentation/devicetree/bindings/watchdog/mt7621-wdt.txt b/Documentation/devicetree/bindings/watchdog/mt7621-wdt.txt deleted file mode 100644 index c15ef0ef609f..000000000000 --- a/Documentation/devicetree/bindings/watchdog/mt7621-wdt.txt +++ /dev/null @@ -1,12 +0,0 @@ -Ralink Watchdog Timers - -Required properties: -- compatible: must be "mediatek,mt7621-wdt" -- reg: physical base address of the controller and length of the register range - -Example: - - watchdog@100 { - compatible = "mediatek,mt7621-wdt"; - reg = <0x100 0x10>; - };