| Message ID | 20220927052217.2784593-4-dmitry.torokhov@gmail.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | [1/4] Input: twl4030-pwrbutton - add missing of.h include | expand |
On Mon, Sep 26, 2022 at 10:22:16PM -0700, Dmitry Torokhov wrote: > The driver is using of_device_id and therefore needs to include > of.h header. As per patch 2 comment, mod_devicetable.h is needed for that. > We used to get this definition indirectly via inclusion > of matrix_keypad.h from twl.h, but we are cleaning up matrix_keypad.h > from unnecessary includes.
On Tue, Sep 27, 2022 at 03:24:25PM +0300, Andy Shevchenko wrote: > On Mon, Sep 26, 2022 at 10:22:16PM -0700, Dmitry Torokhov wrote: > > The driver is using of_device_id and therefore needs to include > > of.h header. > > As per patch 2 comment, mod_devicetable.h is needed for that. It also uses of_match_ptr(), so of.h is the one that is needed. I'll adjust the patch description. Thanks.
On Tue, Sep 27, 2022 at 08:36:22AM -0700, Dmitry Torokhov wrote: > On Tue, Sep 27, 2022 at 03:24:25PM +0300, Andy Shevchenko wrote: > > On Mon, Sep 26, 2022 at 10:22:16PM -0700, Dmitry Torokhov wrote: > > > The driver is using of_device_id and therefore needs to include > > > of.h header. > > > > As per patch 2 comment, mod_devicetable.h is needed for that. > > It also uses of_match_ptr(), so of.h is the one that is needed. I'll > adjust the patch description. Thank you! In such case feel free to add my tag.
diff --git a/drivers/iio/adc/twl4030-madc.c b/drivers/iio/adc/twl4030-madc.c index f8f8aea15612..c279c4f2c9b7 100644 --- a/drivers/iio/adc/twl4030-madc.c +++ b/drivers/iio/adc/twl4030-madc.c @@ -30,6 +30,7 @@ #include <linux/types.h> #include <linux/gfp.h> #include <linux/err.h> +#include <linux/of.h> #include <linux/regulator/consumer.h> #include <linux/iio/iio.h>
The driver is using of_device_id and therefore needs to include of.h header. We used to get this definition indirectly via inclusion of matrix_keypad.h from twl.h, but we are cleaning up matrix_keypad.h from unnecessary includes. Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> --- drivers/iio/adc/twl4030-madc.c | 1 + 1 file changed, 1 insertion(+)