diff mbox series

[v4,4/7] arm64: dts: mediatek: mt8516: Fix the watchdog node name

Message ID 20221104020701.24134-5-allen-kh.cheng@mediatek.com (mailing list archive)
State Superseded
Headers show
Series MediaTek watchdog: Convert mtk-wdt.txt to dt-schema | expand

Commit Message

Allen-KH Cheng Nov. 4, 2022, 2:06 a.m. UTC
The proper name is 'watchdog', not 'toprgu'.

Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
---
 arch/arm64/boot/dts/mediatek/mt8516.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Nícolas F. R. A. Prado Nov. 4, 2022, 2:32 p.m. UTC | #1
On Fri, Nov 04, 2022 at 10:06:58AM +0800, Allen-KH Cheng wrote:
> The proper name is 'watchdog', not 'toprgu'.
> 
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> ---
>  arch/arm64/boot/dts/mediatek/mt8516.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8516.dtsi b/arch/arm64/boot/dts/mediatek/mt8516.dtsi
> index d1b67c82d761..fff59dc1b4d7 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8516.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8516.dtsi
> @@ -202,7 +202,7 @@
>  			#clock-cells = <1>;
>  		};
>  
> -		toprgu: toprgu@10007000 {
> +		toprgu: watchdog@10007000 {

I think you missed my comment about renaming the label as well on the previous
version.

>  			compatible = "mediatek,mt8516-wdt",
>  				     "mediatek,mt6589-wdt";
>  			reg = <0 0x10007000 0 0x1000>;
> -- 
> 2.18.0
>
Allen-KH Cheng Nov. 7, 2022, 1:39 a.m. UTC | #2
Hi Nícolas,

On Fri, 2022-11-04 at 10:32 -0400, Nícolas F. R. A. Prado wrote:
> On Fri, Nov 04, 2022 at 10:06:58AM +0800, Allen-KH Cheng wrote:
> > The proper name is 'watchdog', not 'toprgu'.
> > 
> > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> > Reviewed-by: AngeloGioacchino Del Regno <
> > angelogioacchino.delregno@collabora.com>
> > Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> > ---
> >  arch/arm64/boot/dts/mediatek/mt8516.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8516.dtsi
> > b/arch/arm64/boot/dts/mediatek/mt8516.dtsi
> > index d1b67c82d761..fff59dc1b4d7 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8516.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8516.dtsi
> > @@ -202,7 +202,7 @@
> >  			#clock-cells = <1>;
> >  		};
> >  
> > -		toprgu: toprgu@10007000 {
> > +		toprgu: watchdog@10007000 {
> 
> I think you missed my comment about renaming the label as well on the
> previous
> version.
> 

Yep, I may have misunderstood.

I will remove the label.

Thanks,
Allen

> >  			compatible = "mediatek,mt8516-wdt",
> >  				     "mediatek,mt6589-wdt";
> >  			reg = <0 0x10007000 0 0x1000>;
> > -- 
> > 2.18.0
> >
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/mediatek/mt8516.dtsi b/arch/arm64/boot/dts/mediatek/mt8516.dtsi
index d1b67c82d761..fff59dc1b4d7 100644
--- a/arch/arm64/boot/dts/mediatek/mt8516.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8516.dtsi
@@ -202,7 +202,7 @@ 
 			#clock-cells = <1>;
 		};
 
-		toprgu: toprgu@10007000 {
+		toprgu: watchdog@10007000 {
 			compatible = "mediatek,mt8516-wdt",
 				     "mediatek,mt6589-wdt";
 			reg = <0 0x10007000 0 0x1000>;