| Message ID | 20230106115326.15374-2-allen-kh.cheng@mediatek.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | mtk-wdt: Add reset-by-toprgu support | expand |
On 06/01/2023 12:53, Allen-KH Cheng wrote: > In some applications, the mtk-wdt requires the toprgu (TOP Reset > Generation Unit) to reset counter after wdt resets. Add optional > mediatek,reset-by-toprgu property to enable it. > > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com> > --- > .../devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml b/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml > index b3605608410c..bf06dcd0c12c 100644 > --- a/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml > +++ b/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml > @@ -52,6 +52,10 @@ properties: > description: Disable sending output reset signal > type: boolean > > + mediatek,reset-by-toprgu: > + description: Reset counter by toprgu Do not copy the property name in description but actually describe it. Also "toprgu" is a bit cryptic. Best regards, Krzysztof
Hi Krzysztof, On Fri, 2023-01-06 at 13:30 +0100, Krzysztof Kozlowski wrote: > On 06/01/2023 12:53, Allen-KH Cheng wrote: > > In some applications, the mtk-wdt requires the toprgu (TOP Reset > > Generation Unit) to reset counter after wdt resets. Add optional > > mediatek,reset-by-toprgu property to enable it. > > > > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com> > > --- > > .../devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml | 4 > > ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml > > b/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml > > index b3605608410c..bf06dcd0c12c 100644 > > --- a/Documentation/devicetree/bindings/watchdog/mediatek,mtk- > > wdt.yaml > > +++ b/Documentation/devicetree/bindings/watchdog/mediatek,mtk- > > wdt.yaml > > @@ -52,6 +52,10 @@ properties: > > description: Disable sending output reset signal > > type: boolean > > > > + mediatek,reset-by-toprgu: > > + description: Reset counter by toprgu > > Do not copy the property name in description but actually describe > it. > > Also "toprgu" is a bit cryptic. > > Best regards, > Krzysztof > Sorry for being unclear. We name toprgu for "TOP Reset Generation Unit" in the mtk SoC, which is used to reset the system. mediatek,reset-by-toprgu: description: If present, means the watchdog timer will reset by toprgu after system resets. What do you think? Thanks, Allen
diff --git a/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml b/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml index b3605608410c..bf06dcd0c12c 100644 --- a/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml +++ b/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml @@ -52,6 +52,10 @@ properties: description: Disable sending output reset signal type: boolean + mediatek,reset-by-toprgu: + description: Reset counter by toprgu + type: boolean + '#reset-cells': const: 1
In some applications, the mtk-wdt requires the toprgu (TOP Reset Generation Unit) to reset counter after wdt resets. Add optional mediatek,reset-by-toprgu property to enable it. Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com> --- .../devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml | 4 ++++ 1 file changed, 4 insertions(+)