| Message ID | 20230113103346.29381-2-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | watchdog: dt-bindings: rework/fix qcom-wdt | expand |
On Fri, Jan 13, 2023 at 11:33:40AM +0100, Krzysztof Kozlowski wrote: > The device specific compatibles ("qcom,kpss-wdt-ipq4019") should be > follwed by fallback "qcom,kpss-wdt", which is actually used by Linux > driver for binding. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Acked-by: Rob Herring <robh@kernel.org> Reviewed-by: Guenter Roeck <linux@roeck-us.net> > > --- > > Changes since v1: > 1. Add tag. > --- > Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml > index a1f17c9e02db..e76364c52fc7 100644 > --- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml > +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml > @@ -17,6 +17,7 @@ properties: > oneOf: > - items: > - enum: > + - qcom,kpss-wdt-ipq4019 > - qcom,apss-wdt-msm8994 > - qcom,apss-wdt-qcs404 > - qcom,apss-wdt-sc7180 > @@ -35,7 +36,6 @@ properties: > - qcom,kpss-wdt > - qcom,kpss-timer > - qcom,kpss-wdt-apq8064 > - - qcom,kpss-wdt-ipq4019 > - qcom,kpss-wdt-ipq8064 > - qcom,kpss-wdt-msm8960 > - qcom,scss-timer > -- > 2.34.1 >
On 13/01/2023 15:02, Guenter Roeck wrote: > On Fri, Jan 13, 2023 at 11:33:40AM +0100, Krzysztof Kozlowski wrote: >> The device specific compatibles ("qcom,kpss-wdt-ipq4019") should be >> follwed by fallback "qcom,kpss-wdt", which is actually used by Linux >> driver for binding. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Acked-by: Rob Herring <robh@kernel.org> > > Reviewed-by: Guenter Roeck <linux@roeck-us.net> The patchset was acked and reviewed, so are there any other comments? Guenter/Will - are you planning to pick it up? Best regards, Krzysztof
On 2/7/23 01:17, Krzysztof Kozlowski wrote: > On 13/01/2023 15:02, Guenter Roeck wrote: >> On Fri, Jan 13, 2023 at 11:33:40AM +0100, Krzysztof Kozlowski wrote: >>> The device specific compatibles ("qcom,kpss-wdt-ipq4019") should be >>> follwed by fallback "qcom,kpss-wdt", which is actually used by Linux >>> driver for binding. >>> >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> Acked-by: Rob Herring <robh@kernel.org> >> >> Reviewed-by: Guenter Roeck <linux@roeck-us.net> > > The patchset was acked and reviewed, so are there any other comments? > Guenter/Will - are you planning to pick it up? > The series is in my watchdog-next branch. Wim usually picks patches up from there. Guenter
diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml index a1f17c9e02db..e76364c52fc7 100644 --- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml @@ -17,6 +17,7 @@ properties: oneOf: - items: - enum: + - qcom,kpss-wdt-ipq4019 - qcom,apss-wdt-msm8994 - qcom,apss-wdt-qcs404 - qcom,apss-wdt-sc7180 @@ -35,7 +36,6 @@ properties: - qcom,kpss-wdt - qcom,kpss-timer - qcom,kpss-wdt-apq8064 - - qcom,kpss-wdt-ipq4019 - qcom,kpss-wdt-ipq8064 - qcom,kpss-wdt-msm8960 - qcom,scss-timer
The device specific compatibles ("qcom,kpss-wdt-ipq4019") should be follwed by fallback "qcom,kpss-wdt", which is actually used by Linux driver for binding. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Acked-by: Rob Herring <robh@kernel.org> --- Changes since v1: 1. Add tag. --- Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)