| Message ID | 20231005155618.700312-5-peter.griffin@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add minimal Tensor/GS101 SoC support and Oriole/Pixel6 board | expand |
On 05/10/2023 17:56, Peter Griffin wrote: > GS101 has three different SYSREG controllers, add dedicated > compatibles for them to the documentation. > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > --- > .../bindings/soc/samsung/samsung,exynos-sysreg.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml > index 163e912e9cad..02f580d6489b 100644 > --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml > +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml > @@ -50,6 +50,13 @@ properties: > - samsung,exynosautov9-peric1-sysreg > - const: samsung,exynosautov9-sysreg > - const: syscon > + - items: > + - enum: > + - google,gs101-peric0-sysreg > + - google,gs101-peric1-sysreg > + - google,gs101-apm-sysreg > + - const: google,gs101-sysreg Please drop this one compatible. Exynos has it only for backwards compatibility. Also, please put entire list ("items") before such entry for samsung,exynos5433-sysreg, so everything is more-or-less ordered alphabetically, by the fallback compatible. > + - const: syscon > > reg: > maxItems: 1 Best regards, Krzysztof
Hi Krzysztof, Many thanks for reviewing the series :) On Thu, 5 Oct 2023 at 17:07, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 05/10/2023 17:56, Peter Griffin wrote: > > GS101 has three different SYSREG controllers, add dedicated > > compatibles for them to the documentation. > > > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > > --- > > .../bindings/soc/samsung/samsung,exynos-sysreg.yaml | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml > > index 163e912e9cad..02f580d6489b 100644 > > --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml > > +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml > > @@ -50,6 +50,13 @@ properties: > > - samsung,exynosautov9-peric1-sysreg > > - const: samsung,exynosautov9-sysreg > > - const: syscon > > + - items: > > + - enum: > > + - google,gs101-peric0-sysreg > > + - google,gs101-peric1-sysreg > > + - google,gs101-apm-sysreg > > + - const: google,gs101-sysreg > > Please drop this one compatible. Exynos has it only for backwards > compatibility. Just double checking, you mean I should drop this one compatible? + - const: google,gs101-sysreg > > Also, please put entire list ("items") before such entry for > samsung,exynos5433-sysreg, so everything is more-or-less ordered > alphabetically, by the fallback compatible. Will do! regards, Peter
On 06/10/2023 14:41, Peter Griffin wrote: >>> + - enum: >>> + - google,gs101-peric0-sysreg >>> + - google,gs101-peric1-sysreg >>> + - google,gs101-apm-sysreg >>> + - const: google,gs101-sysreg >> >> Please drop this one compatible. Exynos has it only for backwards >> compatibility. > > Just double checking, you mean I should drop this one compatible? > + - const: google,gs101-sysreg Yes. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml index 163e912e9cad..02f580d6489b 100644 --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml @@ -50,6 +50,13 @@ properties: - samsung,exynosautov9-peric1-sysreg - const: samsung,exynosautov9-sysreg - const: syscon + - items: + - enum: + - google,gs101-peric0-sysreg + - google,gs101-peric1-sysreg + - google,gs101-apm-sysreg + - const: google,gs101-sysreg + - const: syscon reg: maxItems: 1
GS101 has three different SYSREG controllers, add dedicated compatibles for them to the documentation. Signed-off-by: Peter Griffin <peter.griffin@linaro.org> --- .../bindings/soc/samsung/samsung,exynos-sysreg.yaml | 7 +++++++ 1 file changed, 7 insertions(+)