diff mbox series

[2/2] drivers: watchdog: marvell_gti: Program the max_hw_heartbeat_ms

Message ID 20231009044037.514570-2-bbhushan2@marvell.com (mailing list archive)
State New
Headers show
Series [1/2] drivers: watchdog: marvell_gti: fix zero pretimeout handling | expand

Commit Message

Bharat Bhushan Oct. 9, 2023, 4:40 a.m. UTC
From: George Cherian <george.cherian@marvell.com>

Program the max_hw_heartbeat_ms value so that the watchdog_pretimeout
worker is activated. This kernel worker thread makes sure to ping the
watchdog in case the userspace is unable to do so. This kernel worker
ping will be done only till the full watchdog timeout there by
maintaining the watchdog functionality in case of a real hang.

Signed-off-by: George Cherian <george.cherian@marvell.com>
Signed-off-by: Bharat Bhushan <bbhushan2@marvell.com>
---
 drivers/watchdog/marvell_gti_wdt.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Guenter Roeck Oct. 11, 2023, 2:51 p.m. UTC | #1
On Mon, Oct 09, 2023 at 10:10:37AM +0530, Bharat Bhushan wrote:
> From: George Cherian <george.cherian@marvell.com>
> 
> Program the max_hw_heartbeat_ms value so that the watchdog_pretimeout
> worker is activated. This kernel worker thread makes sure to ping the
> watchdog in case the userspace is unable to do so. This kernel worker
> ping will be done only till the full watchdog timeout there by
> maintaining the watchdog functionality in case of a real hang.
> 
> Signed-off-by: George Cherian <george.cherian@marvell.com>
> Signed-off-by: Bharat Bhushan <bbhushan2@marvell.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  drivers/watchdog/marvell_gti_wdt.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/watchdog/marvell_gti_wdt.c b/drivers/watchdog/marvell_gti_wdt.c
> index 25b7ce0f0738..bfe0c819248c 100644
> --- a/drivers/watchdog/marvell_gti_wdt.c
> +++ b/drivers/watchdog/marvell_gti_wdt.c
> @@ -299,6 +299,7 @@ static int gti_wdt_probe(struct platform_device *pdev)
>  
>  	/* Maximum timeout is 3 times the pretimeout */
>  	wdog_dev->max_timeout = max_pretimeout * 3;
> +	wdog_dev->max_hw_heartbeat_ms = max_pretimeout * 1000;
>  	/* Minimum first timeout (pretimeout) is 1, so min_timeout as 3 */
>  	wdog_dev->min_timeout = 3;
>  	wdog_dev->timeout = wdog_dev->pretimeout;
> -- 
> 2.34.1
>
diff mbox series

Patch

diff --git a/drivers/watchdog/marvell_gti_wdt.c b/drivers/watchdog/marvell_gti_wdt.c
index 25b7ce0f0738..bfe0c819248c 100644
--- a/drivers/watchdog/marvell_gti_wdt.c
+++ b/drivers/watchdog/marvell_gti_wdt.c
@@ -299,6 +299,7 @@  static int gti_wdt_probe(struct platform_device *pdev)
 
 	/* Maximum timeout is 3 times the pretimeout */
 	wdog_dev->max_timeout = max_pretimeout * 3;
+	wdog_dev->max_hw_heartbeat_ms = max_pretimeout * 1000;
 	/* Minimum first timeout (pretimeout) is 1, so min_timeout as 3 */
 	wdog_dev->min_timeout = 3;
 	wdog_dev->timeout = wdog_dev->pretimeout;