diff mbox series

[v4,07/19] dt-bindings: pinctrl: samsung: add gs101-wakeup-eint compatible

Message ID 20231120212037.911774-8-peter.griffin@linaro.org (mailing list archive)
State New
Headers show
Series Add minimal Tensor/GS101 SoC support and Oriole/Pixel6 board | expand

Commit Message

Peter Griffin Nov. 20, 2023, 9:20 p.m. UTC
gs101 is similar to newer Exynos SoCs like Exynos850 and ExynosAutov9
where more than one pin controller can do external wake-up interrupt.
So add a dedicated compatible for it.

Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
 .../bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml      | 2 ++
 1 file changed, 2 insertions(+)

Comments

Krzysztof Kozlowski Nov. 22, 2023, 7:11 p.m. UTC | #1
On 20/11/2023 22:20, Peter Griffin wrote:
> gs101 is similar to newer Exynos SoCs like Exynos850 and ExynosAutov9
> where more than one pin controller can do external wake-up interrupt.
> So add a dedicated compatible for it.
> 
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> ---
>  .../bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml      | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
> index 1b75abebb953..41f3a2f2992e 100644
> --- a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
> @@ -30,6 +30,7 @@ properties:
>    compatible:
>      oneOf:
>        - enum:
> +          - google,gs101-wakeup-eint
>            - samsung,s3c2410-wakeup-eint
>            - samsung,s3c2412-wakeup-eint
>            - samsung,s3c64xx-wakeup-eint

This looks compatible with Exynos7. If true, then please add it to
proper items few lines below. This part changed ~2 weeks ago.

Best regards,
Krzysztof
Krzysztof Kozlowski Nov. 22, 2023, 7:15 p.m. UTC | #2
On 22/11/2023 20:11, Krzysztof Kozlowski wrote:
> On 20/11/2023 22:20, Peter Griffin wrote:
>> gs101 is similar to newer Exynos SoCs like Exynos850 and ExynosAutov9
>> where more than one pin controller can do external wake-up interrupt.
>> So add a dedicated compatible for it.
>>
>> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
>> ---
>>  .../bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml      | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
>> index 1b75abebb953..41f3a2f2992e 100644
>> --- a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
>> +++ b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
>> @@ -30,6 +30,7 @@ properties:
>>    compatible:
>>      oneOf:
>>        - enum:
>> +          - google,gs101-wakeup-eint
>>            - samsung,s3c2410-wakeup-eint
>>            - samsung,s3c2412-wakeup-eint
>>            - samsung,s3c64xx-wakeup-eint
> 
> This looks compatible with Exynos7. If true, then please add it to
> proper items few lines below. This part changed ~2 weeks ago.

Ah, not entirely. Exynos7 still has multiplexed interrupts, but GS,
Exynos850 and autov9 do not have, so the compatibility is a bit
different. I'll send an idea.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
index 1b75abebb953..41f3a2f2992e 100644
--- a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
@@ -30,6 +30,7 @@  properties:
   compatible:
     oneOf:
       - enum:
+          - google,gs101-wakeup-eint
           - samsung,s3c2410-wakeup-eint
           - samsung,s3c2412-wakeup-eint
           - samsung,s3c64xx-wakeup-eint
@@ -104,6 +105,7 @@  allOf:
         compatible:
           contains:
             enum:
+              - google,gs101-wakeup-eint
               - samsung,exynos850-wakeup-eint
               - samsung,exynosautov9-wakeup-eint
               - samsung,exynosautov920-wakeup-eint