| Message ID | 20240902081051.3824822-1-nichen@iscas.ac.cn (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | watchdog: iTCO_wdt: Convert comma to semicolon | expand |
On Mon, Sep 2, 2024 at 11:11 AM Chen Ni <nichen@iscas.ac.cn> wrote: > > Replace a comma between expression statements by a semicolon. > > Fixes: ce1b95ca23c1 ("watchdog: iTCO_wdt: Use allocated data structures") Dunno if it deserves Fixes tag, otherwise Reviewed-by: Andy Shevchenko <andy@kernel.org> > Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
On 9/2/24 01:10, Chen Ni wrote: > Replace a comma between expression statements by a semicolon. > > Fixes: ce1b95ca23c1 ("watchdog: iTCO_wdt: Use allocated data structures") > Signed-off-by: Chen Ni <nichen@iscas.ac.cn> > --- The patch is ok, but it doesn't _fix_ anything. The fixes tag should be dropped when applying. Reviewed-by: Guenter Roeck <linux@roeck-us.net> Guenter > drivers/watchdog/iTCO_wdt.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/watchdog/iTCO_wdt.c b/drivers/watchdog/iTCO_wdt.c > index 264857d314da..35b358bcf94c 100644 > --- a/drivers/watchdog/iTCO_wdt.c > +++ b/drivers/watchdog/iTCO_wdt.c > @@ -563,8 +563,8 @@ static int iTCO_wdt_probe(struct platform_device *pdev) > } > > ident.firmware_version = p->iTCO_version; > - p->wddev.info = &ident, > - p->wddev.ops = &iTCO_wdt_ops, > + p->wddev.info = &ident; > + p->wddev.ops = &iTCO_wdt_ops; > p->wddev.bootstatus = 0; > p->wddev.timeout = WATCHDOG_TIMEOUT; > watchdog_set_nowayout(&p->wddev, nowayout);
diff --git a/drivers/watchdog/iTCO_wdt.c b/drivers/watchdog/iTCO_wdt.c index 264857d314da..35b358bcf94c 100644 --- a/drivers/watchdog/iTCO_wdt.c +++ b/drivers/watchdog/iTCO_wdt.c @@ -563,8 +563,8 @@ static int iTCO_wdt_probe(struct platform_device *pdev) } ident.firmware_version = p->iTCO_version; - p->wddev.info = &ident, - p->wddev.ops = &iTCO_wdt_ops, + p->wddev.info = &ident; + p->wddev.ops = &iTCO_wdt_ops; p->wddev.bootstatus = 0; p->wddev.timeout = WATCHDOG_TIMEOUT; watchdog_set_nowayout(&p->wddev, nowayout);
Replace a comma between expression statements by a semicolon. Fixes: ce1b95ca23c1 ("watchdog: iTCO_wdt: Use allocated data structures") Signed-off-by: Chen Ni <nichen@iscas.ac.cn> --- drivers/watchdog/iTCO_wdt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)