| Message ID | 20250218031709.103823-2-guoheyi@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] driver/aspeed-wdt: fix pretimeout for counting down logic | expand |
On 18/02/2025 04:16, Heyi Guo wrote: > To finally enable watchdog pretimeout function. > > Signed-off-by: Heyi Guo <guoheyi@linux.alibaba.com> > There is never blank line between tags. > Cc: Rob Herring <robh@kernel.org> > Cc: Krzysztof Kozlowski <krzk+dt@kernel.org> Please drop the autogenerated scripts/get_maintainer.pl CC-entries from commit msg. There is no single need to store automated output of get_maintainers.pl in the git log. It can be easily re-created at any given time, thus its presence in the git history is redundant and obfuscates the log. If you need it for your own patch management purposes, keep it under the --- separator. > Cc: Conor Dooley <conor+dt@kernel.org> > Cc: Joel Stanley <joel@jms.id.au> > Cc: Andrew Jeffery <andrew@codeconstruct.com.au> Missing Sob as last entry. Best regards, Krzysztof
Hi Heyi, On Tue, 2025-02-18 at 11:16 +0800, Heyi Guo wrote: > To finally enable watchdog pretimeout function. > > Signed-off-by: Heyi Guo <guoheyi@linux.alibaba.com> > > Cc: Rob Herring <robh@kernel.org> > Cc: Krzysztof Kozlowski <krzk+dt@kernel.org> > Cc: Conor Dooley <conor+dt@kernel.org> > Cc: Joel Stanley <joel@jms.id.au> > Cc: Andrew Jeffery <andrew@codeconstruct.com.au> > --- > arch/arm/boot/dts/aspeed/aspeed-g6.dtsi | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi > b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi > index 8ed715bd53aa..ef7ced285c44 100644 > --- a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi > +++ b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi > @@ -538,23 +538,27 @@ uart5: serial@1e784000 { > wdt1: watchdog@1e785000 { > compatible = "aspeed,ast2600-wdt"; > reg = <0x1e785000 0x40>; > + interrupts = <GIC_SPI 24 > IRQ_TYPE_LEVEL_HIGH>; The binding will need an update to allow 'interrupts' as an optional property. Andrew
diff --git a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi index 8ed715bd53aa..ef7ced285c44 100644 --- a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi +++ b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi @@ -538,23 +538,27 @@ uart5: serial@1e784000 { wdt1: watchdog@1e785000 { compatible = "aspeed,ast2600-wdt"; reg = <0x1e785000 0x40>; + interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>; }; wdt2: watchdog@1e785040 { compatible = "aspeed,ast2600-wdt"; reg = <0x1e785040 0x40>; + interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>; status = "disabled"; }; wdt3: watchdog@1e785080 { compatible = "aspeed,ast2600-wdt"; reg = <0x1e785080 0x40>; + interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>; status = "disabled"; }; wdt4: watchdog@1e7850c0 { compatible = "aspeed,ast2600-wdt"; reg = <0x1e7850C0 0x40>; + interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>; status = "disabled"; };
To finally enable watchdog pretimeout function. Signed-off-by: Heyi Guo <guoheyi@linux.alibaba.com> Cc: Rob Herring <robh@kernel.org> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org> Cc: Conor Dooley <conor+dt@kernel.org> Cc: Joel Stanley <joel@jms.id.au> Cc: Andrew Jeffery <andrew@codeconstruct.com.au> --- arch/arm/boot/dts/aspeed/aspeed-g6.dtsi | 4 ++++ 1 file changed, 4 insertions(+)