diff mbox series

[v2,3/4] watchdog: da9052_wdt: do not disable wdt during probe

Message ID 20250325-da9052-fixes-v2-3-bfac3f07b4a4@gmail.com (mailing list archive)
State New
Headers show
Series Various fixes for the da9052 watchdog | expand

Commit Message

Marcus Folkesson March 25, 2025, 7:27 a.m. UTC 
If the watchog is started by the bootloader, we do not want the watchdog
to be disabled.

Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
---
 drivers/watchdog/da9052_wdt.c | 8 --------
 1 file changed, 8 deletions(-)

Comments

Guenter Roeck March 25, 2025, 1:05 p.m. UTC | #1 
On Tue, Mar 25, 2025 at 08:27:14AM +0100, Marcus Folkesson wrote:
> If the watchog is started by the bootloader, we do not want the watchdog
> to be disabled.
> 

If the watchdog is left running, the watchdog core should be notified
by setting WDOG_HW_RUNNING. Please see other drivers for examples.

Thanks,
Guenter
diff mbox series

Patch

diff --git a/drivers/watchdog/da9052_wdt.c b/drivers/watchdog/da9052_wdt.c
index fa9078d4c136a52f1193768fe93dc04189519679..b821006fca70480bf3b23a62bded4e66851a537e 100644
--- a/drivers/watchdog/da9052_wdt.c
+++ b/drivers/watchdog/da9052_wdt.c
@@ -170,7 +170,6 @@  static int da9052_wdt_probe(struct platform_device *pdev)
 	struct da9052 *da9052 = dev_get_drvdata(dev->parent);
 	struct da9052_wdt_data *driver_data;
 	struct watchdog_device *da9052_wdt;
-	int ret;
 
 	driver_data = devm_kzalloc(dev, sizeof(*driver_data), GFP_KERNEL);
 	if (!driver_data)
@@ -194,13 +193,6 @@  static int da9052_wdt_probe(struct platform_device *pdev)
 	if (da9052->fault_log & DA9052_FAULTLOG_VDDFAULT)
 		da9052_wdt->bootstatus |= WDIOF_POWERUNDER;
 
-	ret = da9052_reg_update(da9052, DA9052_CONTROL_D_REG,
-				DA9052_CONTROLD_TWDSCALE, 0);
-	if (ret < 0) {
-		dev_err(dev, "Failed to disable watchdog bits, %d\n", ret);
-		return ret;
-	}
-
 	return devm_watchdog_register_device(dev, &driver_data->wdt);
 }