| Message ID | CH2PR19MB359059AA5C8917D8D24633FF9D690@CH2PR19MB3590.namprd19.prod.outlook.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [v3,1/1] watchdog: Add common nowayout parameter to booke_wdt driver | expand |
On 7/6/20 9:33 AM, Timothy Myers wrote: > Add the common "nowayout" parameter to booke_wdt to make this behavior > selectable at runtime and to make the implementation more consistent with > many other watchdog drivers. > > Signed-off-by: Timothy Myers <timothy.myers@adtran.com> > Reviewed-by: Guenter Roeck <linux@roeck-us.net> > > Changes in: > v2: > Added Guenter Roeck's reviewed-by tag at his request > v3: > Fix whitespace formatting in message. > --- Change log goes here. I applied your patch to watchdog-next, but there is still something in it which prevents it from showing up at https://patchwork.kernel.org/project/linux-watchdog/list/, even though I do see it at https://lore.kernel.org/linux-watchdog/. Looking into the e-mail source, I think the problem may be due to some Outlook specific formatting in the raw message: Add the common "nowayout" parameter to booke_wdt to make this behavior=0A= selectable at runtime and to make the implementation more consistent with= =0A= many other watchdog drivers.=0A= =0A= and so on. If that is persistent, it may make sense to fix it, or you might wonder why some of your patches are being ignored. Thanks, Guenter
From: linux-watchdog-owner@vger.kernel.org <linux-watchdog-owner@vger.kernel.org> on behalf of Guenter Roeck <linux@roeck-us.net> Sent: Monday, July 6, 2020 5:18 PM To: Timothy Myers <timothy.myers@adtran.com>; Wim Van Sebroeck <wim@linux-watchdog.org>; linux-watchdog@vger.kernel.org <linux-watchdog@vger.kernel.org> Cc: linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>; David Boike <david.boike@adtran.com> Subject: Re: [PATCH v3 1/1] watchdog: Add common nowayout parameter to booke_wdt driver On 7/6/20 9:33 AM, Timothy Myers wrote: >> Add the common "nowayout" parameter to booke_wdt to make this behavior >> selectable at runtime and to make the implementation more consistent with >> many other watchdog drivers. >> >> Signed-off-by: Timothy Myers <timothy.myers@adtran.com> >> Reviewed-by: Guenter Roeck <linux@roeck-us.net> >> >> Changes in: >> v2: >> Added Guenter Roeck's reviewed-by tag at his request >> v3: >> Fix whitespace formatting in message. >> --- > >Change log goes here. > >I applied your patch to watchdog-next, but there is still something >in it which prevents it from showing up at >https://patchwork.kernel.org/project/linux-watchdog/list/, even though >I do see it at https://lore.kernel.org/linux-watchdog/. > >Looking into the e-mail source, I think the problem may be due >to some Outlook specific formatting in the raw message: > >Add the common "nowayout" parameter to booke_wdt to make this behavior=0A= >selectable at runtime and to make the implementation more consistent with= >=0A= >many other watchdog drivers.=0A= >=0A= > >and so on. If that is persistent, it may make sense to fix it, or >you might wonder why some of your patches are being ignored. > >Thanks, >Guenter Thank you for applying the patch, and thank you again for your help with my mail. I'll look into the formatting.
diff --git a/drivers/watchdog/booke_wdt.c b/drivers/watchdog/booke_wdt.c index 9d09bbfdef20..7817fb976f9c 100644 --- a/drivers/watchdog/booke_wdt.c +++ b/drivers/watchdog/booke_wdt.c @@ -39,6 +39,11 @@ static bool booke_wdt_enabled; module_param(booke_wdt_enabled, bool, 0); static int booke_wdt_period = CONFIG_BOOKE_WDT_DEFAULT_TIMEOUT; module_param(booke_wdt_period, int, 0); +static bool nowayout = WATCHDOG_NOWAYOUT; +module_param(nowayout, bool, 0); +MODULE_PARM_DESC(nowayout, + "Watchdog cannot be stopped once started (default=" + __MODULE_STRING(WATCHDOG_NOWAYOUT) ")"); #ifdef CONFIG_PPC_FSL_BOOK3E @@ -215,7 +220,6 @@ static void __exit booke_wdt_exit(void) static int __init booke_wdt_init(void) { int ret = 0; - bool nowayout = WATCHDOG_NOWAYOUT; pr_info("powerpc book-e watchdog driver loaded\n"); booke_wdt_info.firmware_version = cur_cpu_spec->pvr_value;