| Message ID | ZdDUlGdqH7Qv3SDu@standask-GA-A55M-S2HP (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | dt-bindings: watchdog: sprd,sp9860-wdt: convert to YAML | expand |
On Sat, 17 Feb 2024 at 23:45, Stanislav Jakubek <stano.jakubek@gmail.com> wrote: > > Convert Spreadtrum SP9860 watchdog timer bindings to DT schema. > Adjust file name to match compatible. > > Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com> Thanks for the patch. Acked-by: Chunyan Zhang <zhang.lyra@gmail.com> > --- > .../bindings/watchdog/sprd,sp9860-wdt.yaml | 64 +++++++++++++++++++ > .../devicetree/bindings/watchdog/sprd-wdt.txt | 19 ------ > 2 files changed, 64 insertions(+), 19 deletions(-) > create mode 100644 Documentation/devicetree/bindings/watchdog/sprd,sp9860-wdt.yaml > delete mode 100644 Documentation/devicetree/bindings/watchdog/sprd-wdt.txt > > diff --git a/Documentation/devicetree/bindings/watchdog/sprd,sp9860-wdt.yaml b/Documentation/devicetree/bindings/watchdog/sprd,sp9860-wdt.yaml > new file mode 100644 > index 000000000000..730d9a3a3cc5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/watchdog/sprd,sp9860-wdt.yaml > @@ -0,0 +1,64 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/watchdog/sprd,sp9860-wdt.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Spreadtrum SP9860 watchdog timer > + > +maintainers: > + - Orson Zhai <orsonzhai@gmail.com> > + - Baolin Wang <baolin.wang7@gmail.com> > + - Chunyan Zhang <zhang.lyra@gmail.com> > + > +allOf: > + - $ref: watchdog.yaml# > + > +properties: > + compatible: > + const: sprd,sp9860-wdt > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 2 > + > + clock-names: > + items: > + - const: enable > + - const: rtc_enable > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - timeout-sec > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/sprd,sc9860-clk.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/interrupt-controller/irq.h> > + > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + watchdog@40310000 { > + compatible = "sprd,sp9860-wdt"; > + reg = <0 0x40310000 0 0x1000>; > + interrupts = <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&aon_gate CLK_APCPU_WDG_EB>, <&aon_gate CLK_AP_WDG_RTC_EB>; > + clock-names = "enable", "rtc_enable"; > + timeout-sec = <12>; > + }; > + }; > +... > diff --git a/Documentation/devicetree/bindings/watchdog/sprd-wdt.txt b/Documentation/devicetree/bindings/watchdog/sprd-wdt.txt > deleted file mode 100644 > index aeaf3e0caf47..000000000000 > --- a/Documentation/devicetree/bindings/watchdog/sprd-wdt.txt > +++ /dev/null > @@ -1,19 +0,0 @@ > -Spreadtrum SoCs Watchdog timer > - > -Required properties: > -- compatible : Should be "sprd,sp9860-wdt". > -- reg : Specifies base physical address and size of the registers. > -- interrupts : Exactly one interrupt specifier. > -- timeout-sec : Contain the default watchdog timeout in seconds. > -- clock-names : Contain the input clock names. > -- clocks : Phandles to input clocks. > - > -Example: > - watchdog: watchdog@40310000 { > - compatible = "sprd,sp9860-wdt"; > - reg = <0 0x40310000 0 0x1000>; > - interrupts = <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>; > - timeout-sec = <12>; > - clock-names = "enable", "rtc_enable"; > - clocks = <&clk_aon_apb_gates1 8>, <&clk_aon_apb_rtc_gates 9>; > - }; > -- > 2.34.1 >
On 17/02/2024 16:45, Stanislav Jakubek wrote: > Convert Spreadtrum SP9860 watchdog timer bindings to DT schema. > Adjust file name to match compatible. > > Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Hi all, I was about to remind people that this patch exists, but apparently it already got applied without notice? Seems like it's in linux-next already. Stanislav
On 11/03/2024 09:54, Stanislav Jakubek wrote: > Hi all, > > I was about to remind people that this patch exists, but apparently it > already got applied without notice? Seems like it's in linux-next already. You are not the first one surprised... I think I could count on fingers of one hand the times I received any notification/confirmation from watchdog that my patch was applied. That made me waste some time in the past for unneeded checks and resends. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/watchdog/sprd,sp9860-wdt.yaml b/Documentation/devicetree/bindings/watchdog/sprd,sp9860-wdt.yaml new file mode 100644 index 000000000000..730d9a3a3cc5 --- /dev/null +++ b/Documentation/devicetree/bindings/watchdog/sprd,sp9860-wdt.yaml @@ -0,0 +1,64 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/watchdog/sprd,sp9860-wdt.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Spreadtrum SP9860 watchdog timer + +maintainers: + - Orson Zhai <orsonzhai@gmail.com> + - Baolin Wang <baolin.wang7@gmail.com> + - Chunyan Zhang <zhang.lyra@gmail.com> + +allOf: + - $ref: watchdog.yaml# + +properties: + compatible: + const: sprd,sp9860-wdt + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + maxItems: 2 + + clock-names: + items: + - const: enable + - const: rtc_enable + +required: + - compatible + - reg + - interrupts + - clocks + - clock-names + - timeout-sec + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/clock/sprd,sc9860-clk.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/interrupt-controller/irq.h> + + soc { + #address-cells = <2>; + #size-cells = <2>; + + watchdog@40310000 { + compatible = "sprd,sp9860-wdt"; + reg = <0 0x40310000 0 0x1000>; + interrupts = <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&aon_gate CLK_APCPU_WDG_EB>, <&aon_gate CLK_AP_WDG_RTC_EB>; + clock-names = "enable", "rtc_enable"; + timeout-sec = <12>; + }; + }; +... diff --git a/Documentation/devicetree/bindings/watchdog/sprd-wdt.txt b/Documentation/devicetree/bindings/watchdog/sprd-wdt.txt deleted file mode 100644 index aeaf3e0caf47..000000000000 --- a/Documentation/devicetree/bindings/watchdog/sprd-wdt.txt +++ /dev/null @@ -1,19 +0,0 @@ -Spreadtrum SoCs Watchdog timer - -Required properties: -- compatible : Should be "sprd,sp9860-wdt". -- reg : Specifies base physical address and size of the registers. -- interrupts : Exactly one interrupt specifier. -- timeout-sec : Contain the default watchdog timeout in seconds. -- clock-names : Contain the input clock names. -- clocks : Phandles to input clocks. - -Example: - watchdog: watchdog@40310000 { - compatible = "sprd,sp9860-wdt"; - reg = <0 0x40310000 0 0x1000>; - interrupts = <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>; - timeout-sec = <12>; - clock-names = "enable", "rtc_enable"; - clocks = <&clk_aon_apb_gates1 8>, <&clk_aon_apb_rtc_gates 9>; - };
Convert Spreadtrum SP9860 watchdog timer bindings to DT schema. Adjust file name to match compatible. Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com> --- .../bindings/watchdog/sprd,sp9860-wdt.yaml | 64 +++++++++++++++++++ .../devicetree/bindings/watchdog/sprd-wdt.txt | 19 ------ 2 files changed, 64 insertions(+), 19 deletions(-) create mode 100644 Documentation/devicetree/bindings/watchdog/sprd,sp9860-wdt.yaml delete mode 100644 Documentation/devicetree/bindings/watchdog/sprd-wdt.txt