diff mbox series

[v2] watchdog: rza_wdt: Use semicolons instead of commas

Message ID dc4e3692480a136f5c2efdd38862ff2c8741f93c.1635338097.git.geert+renesas@glider.be (mailing list archive)
State Accepted
Headers show
Series [v2] watchdog: rza_wdt: Use semicolons instead of commas | expand

Commit Message

Geert Uytterhoeven Oct. 27, 2021, 12:36 p.m. UTC 
This code works, but it is cleaner to use semicolons at the end of
statements instead of commas.

Extracted from a big anonymous patch by Julia Lawall
<julia.lawall@inria.fr>.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
---
v2:
  - Add Reviewed-by.
---
 drivers/watchdog/rza_wdt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Kieran Bingham Oct. 27, 2021, 1:09 p.m. UTC | #1 
Quoting Geert Uytterhoeven (2021-10-27 13:36:03)
> This code works, but it is cleaner to use semicolons at the end of
> statements instead of commas.
> 
> Extracted from a big anonymous patch by Julia Lawall
> <julia.lawall@inria.fr>.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>

Yikes, that's subtle, the fun you can have with valid C code ;-)

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

> ---
> v2:
>   - Add Reviewed-by.
> ---
>  drivers/watchdog/rza_wdt.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/watchdog/rza_wdt.c b/drivers/watchdog/rza_wdt.c
> index 7b6c365f7cd36297..fe6c2ed35e04cc4b 100644
> --- a/drivers/watchdog/rza_wdt.c
> +++ b/drivers/watchdog/rza_wdt.c
> @@ -189,8 +189,8 @@ static int rza_wdt_probe(struct platform_device *pdev)
>                 return -ENOENT;
>         }
>  
> -       priv->wdev.info = &rza_wdt_ident,
> -       priv->wdev.ops = &rza_wdt_ops,
> +       priv->wdev.info = &rza_wdt_ident;
> +       priv->wdev.ops = &rza_wdt_ops;
>         priv->wdev.parent = dev;
>  
>         priv->cks = (u8)(uintptr_t) of_device_get_match_data(dev);
> -- 
> 2.25.1
>
diff mbox series

Patch

diff --git a/drivers/watchdog/rza_wdt.c b/drivers/watchdog/rza_wdt.c
index 7b6c365f7cd36297..fe6c2ed35e04cc4b 100644
--- a/drivers/watchdog/rza_wdt.c
+++ b/drivers/watchdog/rza_wdt.c
@@ -189,8 +189,8 @@  static int rza_wdt_probe(struct platform_device *pdev)
 		return -ENOENT;
 	}
 
-	priv->wdev.info = &rza_wdt_ident,
-	priv->wdev.ops = &rza_wdt_ops,
+	priv->wdev.info = &rza_wdt_ident;
+	priv->wdev.ops = &rza_wdt_ops;
 	priv->wdev.parent = dev;
 
 	priv->cks = (u8)(uintptr_t) of_device_get_match_data(dev);