From patchwork Mon Mar 4 09:48:05 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stanislaw Gruszka X-Patchwork-Id: 10837487 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DE40C1390 for ; Mon, 4 Mar 2019 09:48:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CA3F029D4C for ; Mon, 4 Mar 2019 09:48:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BD36429DD6; Mon, 4 Mar 2019 09:48:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5A90929D4C for ; Mon, 4 Mar 2019 09:48:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726100AbfCDJsY (ORCPT ); Mon, 4 Mar 2019 04:48:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42488 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726054AbfCDJsY (ORCPT ); Mon, 4 Mar 2019 04:48:24 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 20ABB356EA; Mon, 4 Mar 2019 09:48:24 +0000 (UTC) Received: from localhost (unknown [10.40.205.1]) by smtp.corp.redhat.com (Postfix) with ESMTP id C42EC1001DCA; Mon, 4 Mar 2019 09:48:17 +0000 (UTC) From: Stanislaw Gruszka Cc: Felix Fietkau , linux-wireless@vger.kernel.org, Lorenzo Bianconi Subject: [PATCH 00/11] mt76x02: AP support for USB with PS Date: Mon, 4 Mar 2019 10:48:05 +0100 Message-Id: <1551692896-7062-1-git-send-email-sgruszka@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 04 Mar 2019 09:48:24 +0000 (UTC) To: unlisted-recipients:; (no To-header on input) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On USB we do not have available PSD queue. Using standard AC queues is unreliable for sending PS buffered frames, stations can go sleep again before frames are sent. Only reliable way I could find to sent broadcast PS buffered frames is put them into beacon data registers, then frames are sent just after proper beacon. HW do the work when we encrypt the frames in software. I tested functionality used arping to iwlwifi station that do aggressive PS, it works like this: # arping -c 1 -I wlan0 192.168.9.110 ARPING 192.168.9.110 from 192.168.9.1 wlan0 Unicast reply from 192.168.9.110 [4C:34:88:5E:76:D5] 324.885ms Sent 1 probes (1 broadcast(s)) Otherwise arping fails: # arping -c 1 -I wlan0 192.168.9.110 ARPING 192.168.9.110 from 192.168.1.148 wlan0 Sent 1 probes (1 broadcast(s)) Received 0 response(s) I'm not sure how to test mt76_release_buffered_frames functionality. Also I have not tested on MMIO hardware, but for this only code movement was done so things should not break. RFC -> v1: - do no remove set_tim - add tbtt_start/stop for mt76x2u - rebase on top of: [PATCH 0/5] introduce mt76_sw_queue data structure https://lore.kernel.org/linux-wireless/cover.1551533068.git.lorenzo@kernel.org/ Stanislaw Gruszka (11): mt76x02: introduce mt76x02_beacon.c mt76x02: add hrtimer for pre TBTT for USB mt76x02: introduce beacon_ops mt76x02u: implement beacon_ops mt76x02: generalize some mmio beaconing functions mt76x02u: add sta_ps mt76x02: disable HW encryption for group frames mt76x02u: implement pre TBTT work for USB mt76x02u: add mt76_release_buffered_frames mt76: unify set_tim mt76x02: enable AP mode for USB drivers/net/wireless/mediatek/mt76/Makefile | 2 +- drivers/net/wireless/mediatek/mt76/mac80211.c | 7 + drivers/net/wireless/mediatek/mt76/mt76.h | 2 + .../net/wireless/mediatek/mt76/mt7603/main.c | 8 +- .../net/wireless/mediatek/mt76/mt76x0/init.c | 1 - .../net/wireless/mediatek/mt76/mt76x0/main.c | 8 +- .../net/wireless/mediatek/mt76/mt76x0/pci.c | 11 +- .../net/wireless/mediatek/mt76/mt76x0/usb.c | 10 +- drivers/net/wireless/mediatek/mt76/mt76x02.h | 22 ++ .../wireless/mediatek/mt76/mt76x02_beacon.c | 308 ++++++++++++++++++ .../net/wireless/mediatek/mt76/mt76x02_mac.c | 138 -------- .../net/wireless/mediatek/mt76/mt76x02_mmio.c | 131 +++----- .../net/wireless/mediatek/mt76/mt76x02_regs.h | 5 +- .../net/wireless/mediatek/mt76/mt76x02_usb.h | 2 + .../wireless/mediatek/mt76/mt76x02_usb_core.c | 153 +++++++++ .../net/wireless/mediatek/mt76/mt76x02_util.c | 77 +---- .../wireless/mediatek/mt76/mt76x2/pci_init.c | 2 +- .../wireless/mediatek/mt76/mt76x2/pci_main.c | 8 +- .../net/wireless/mediatek/mt76/mt76x2/usb.c | 1 + .../wireless/mediatek/mt76/mt76x2/usb_init.c | 2 +- .../wireless/mediatek/mt76/mt76x2/usb_main.c | 6 + drivers/net/wireless/mediatek/mt76/usb.c | 7 +- 22 files changed, 582 insertions(+), 329 deletions(-) create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x02_beacon.c