| Message ID | 20191011022413.176208-1-kyan@google.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Implement Airtime-based Queue Limit (AQL) | expand |
Kan Yan <kyan@google.com> writes: > This patch series implements Airtime-based Queue Limit (AQL) in the mac80211 and Ath10k driver. It is based on an earlier version from the ChromiumOS tree[0]. > > This version has been tested with QCA9884 platform with 4.14 kernel. Tests show AQL is able to reduce latency by an order of magnitude in a congested environment without negative impact on the throughput. > > [0] https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1703105/7 > > Kan Yan (2): > mac80211: Implement Airtime-based Queue Limit (AQL) > ath10k: Enable Airtime-based Queue Limit (AQL) Please always include a change log so that people know what has changed since the previous version: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#changelog_missing
Kalle Valo <kvalo@codeaurora.org> writes: > Kan Yan <kyan@google.com> writes: > >> This patch series implements Airtime-based Queue Limit (AQL) in the >> mac80211 and Ath10k driver. It is based on an earlier version from >> the ChromiumOS tree[0]. >> >> This version has been tested with QCA9884 platform with 4.14 kernel. >> Tests show AQL is able to reduce latency by an order of magnitude in >> a congested environment without negative impact on the throughput. >> >> [0] >> https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1703105/7 >> >> Kan Yan (2): >> mac80211: Implement Airtime-based Queue Limit (AQL) >> ath10k: Enable Airtime-based Queue Limit (AQL) > > Please always include a change log so that people know what has changed > since the previous version: > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#changelog_missing Never mind, you actually had the changelog after the signature separator ("-- \n" line) and I automatically skip the signature :) So instead I recommend moving the change log up and above the signature separator.
Hi Kalle, Thanks for the help and tips. Will do that if I need to submit again. I believe Toke will integrate this with his version and move the estimating pending airtime part to mac80211, so maybe in the next version, ath10k change is no longer required. Thanks, Kan On Mon, Oct 14, 2019 at 2:18 AM Kalle Valo <kvalo@codeaurora.org> wrote: > > Kalle Valo <kvalo@codeaurora.org> writes: > > > Kan Yan <kyan@google.com> writes: > > > >> This patch series implements Airtime-based Queue Limit (AQL) in the > >> mac80211 and Ath10k driver. It is based on an earlier version from > >> the ChromiumOS tree[0]. > >> > >> This version has been tested with QCA9884 platform with 4.14 kernel. > >> Tests show AQL is able to reduce latency by an order of magnitude in > >> a congested environment without negative impact on the throughput. > >> > >> [0] > >> https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1703105/7 > >> > >> Kan Yan (2): > >> mac80211: Implement Airtime-based Queue Limit (AQL) > >> ath10k: Enable Airtime-based Queue Limit (AQL) > > > > Please always include a change log so that people know what has changed > > since the previous version: > > > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#changelog_missing > > Never mind, you actually had the changelog after the signature separator > ("-- \n" line) and I automatically skip the signature :) So instead I > recommend moving the change log up and above the signature separator. > > -- > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
(please don't top post) Kan Yan <kyan@google.com> writes: > I believe Toke will integrate this with his version and move the > estimating pending airtime part to mac80211, so maybe in the next > version, ath10k change is no longer required. What do you mean? Are you saying that I can drop this patch: [v4,2/2] ath10k: Enable Airtime-based Queue Limit (AQL) https://patchwork.kernel.org/patch/11184783/
Kalle Valo <kvalo@codeaurora.org> writes: > (please don't top post) > > Kan Yan <kyan@google.com> writes: > >> I believe Toke will integrate this with his version and move the >> estimating pending airtime part to mac80211, so maybe in the next >> version, ath10k change is no longer required. > > What do you mean? Are you saying that I can drop this patch: > > [v4,2/2] ath10k: Enable Airtime-based Queue Limit (AQL) > > https://patchwork.kernel.org/patch/11184783/ Yes, we're trying to do it all in mac80211. See https://patchwork.kernel.org/project/linux-wireless/list/?series=190333 -Toke
Toke Høiland-Jørgensen <toke@redhat.com> writes: > Kalle Valo <kvalo@codeaurora.org> writes: > >> (please don't top post) >> >> Kan Yan <kyan@google.com> writes: >> >>> I believe Toke will integrate this with his version and move the >>> estimating pending airtime part to mac80211, so maybe in the next >>> version, ath10k change is no longer required. >> >> What do you mean? Are you saying that I can drop this patch: >> >> [v4,2/2] ath10k: Enable Airtime-based Queue Limit (AQL) >> >> https://patchwork.kernel.org/patch/11184783/ > > Yes, we're trying to do it all in mac80211. See > https://patchwork.kernel.org/project/linux-wireless/list/?series=190333 Thanks, I dropped this patch now.