From patchwork Fri Feb 10 11:16:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sascha Hauer X-Patchwork-Id: 13135707 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A096CC05027 for ; Fri, 10 Feb 2023 11:16:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232270AbjBJLQ6 (ORCPT ); Fri, 10 Feb 2023 06:16:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232065AbjBJLQt (ORCPT ); Fri, 10 Feb 2023 06:16:49 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09D2772DD6 for ; Fri, 10 Feb 2023 03:16:39 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pQROO-0003KV-Ot; Fri, 10 Feb 2023 12:16:36 +0100 Received: from [2a0a:edc0:0:1101:1d::28] (helo=dude02.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pQROM-003xEW-CS; Fri, 10 Feb 2023 12:16:35 +0100 Received: from sha by dude02.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pQROM-008k9X-Mu; Fri, 10 Feb 2023 12:16:34 +0100 From: Sascha Hauer To: linux-wireless@vger.kernel.org Cc: Neo Jou , Hans Ulli Kroll , Ping-Ke Shih , Yan-Hsuan Chuang , Kalle Valo , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Martin Blumenstingl , kernel@pengutronix.de, Alexander Hochbaum , Da Xue , Po-Hao Huang , Andreas Henriksson , Viktor Petrenko , Sascha Hauer Subject: [PATCH v2 0/3] wifi: rtw88: USB fixes Date: Fri, 10 Feb 2023 12:16:29 +0100 Message-Id: <20230210111632.1985205-1-s.hauer@pengutronix.de> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-wireless@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org This series addresses issues for the recently added RTW88 USB support reported by Andreas Henriksson and also our customer. The hardware can't handle urbs that have a size of multiple of the bulkout_size (usually 512 bytes). The symptom is that the hardware stalls completely. The issue can be reproduced by sending a suitably sized ping packet from the device: ping -s 394 (It's 394 bytes here on a RTL8822CU and RTL8821CU, the actual size may differ on other chips, it was 402 bytes on a RTL8723DU) Other than that qsel was not set correctly. The sympton here is that only one of multiple bulk endpoints was used to send data. Changes since v1: - Use URB_ZERO_PACKET to let the USB host controller handle it automatically rather than working around the issue. Sascha Hauer (3): wifi: rtw88: usb: Set qsel correctly wifi: rtw88: usb: send Zero length packets if necessary wifi: rtw88: usb: drop now unnecessary URB size check drivers/net/wireless/realtek/rtw88/usb.c | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) Reported-by: Andreas Henriksson Tested-by: Andreas Henriksson