mbox series

[0/4] wireless: Use common cordic algorithm for b43 driver

Message ID cover.87f16ede7954f8d9cde4ecae5f050bf8f4008dd8.1542649316.git-series.plaes@plaes.org (mailing list archive)
Headers show
Series wireless: Use common cordic algorithm for b43 driver | expand

Message

Priit Laes Nov. 19, 2018, 6:01 p.m. UTC
b43 wireless driver includes an internal implementation of
cordic algorithm, although there's a common cordic library
which was split out from brcmsmac driver. Use that and drop
internal implementation.

During the process, cordic-algorithm related macros in
brcmfmac driver were also removed and use general macros.

Please note that this series is only compile-tested, as I
do not have access to the hardware.

--

Changes since v3:
- Added ACKed-By bits for patches 1, 4
- Added new patch for stable by Larry as patch 3
- Fixed argument scaling for b43 driver in patch 4

Changes since v2:
- Improvements to commit messages. No functional changes.
- Collect reviewed-by bits.

Changes since v1:
- Merged brcmsmac driver patches into single patch
- Merged b43 driver patches into single patch

Larry Finger (1):
  b43: Fix error in cordic routine

Priit Laes (3):
  lib: cordic: Move cordic macros and defines to header file
  brcmsmac: Use cordic-related macros from common cordic library
  b43: Use cordic algorithm from kernel library

 drivers/net/wireless/broadcom/b43/Kconfig                      |  1 +-
 drivers/net/wireless/broadcom/b43/phy_common.c                 | 47 +-------
 drivers/net/wireless/broadcom/b43/phy_common.h                 |  9 +-
 drivers/net/wireless/broadcom/b43/phy_lp.c                     | 13 +-
 drivers/net/wireless/broadcom/b43/phy_n.c                      | 13 +-
 drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_int.h |  7 +-
 drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c |  4 +-
 drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c   |  4 +-
 include/linux/cordic.h                                         |  9 +-
 lib/cordic.c                                                   | 23 +---
 10 files changed, 35 insertions(+), 95 deletions(-)

base-commit: 9ff01193a20d391e8dbce4403dd5ef87c7eaaca6

Comments

Priit Laes Nov. 19, 2018, 6:10 p.m. UTC | #1
On Mon, Nov 19, 2018 at 08:01:21PM +0200, Priit Laes wrote:
> b43 wireless driver includes an internal implementation of
> cordic algorithm, although there's a common cordic library
> which was split out from brcmsmac driver. Use that and drop
> internal implementation.
> 
> During the process, cordic-algorithm related macros in
> brcmfmac driver were also removed and use general macros.
> 
> Please note that this series is only compile-tested, as I
> do not have access to the hardware.


Gah.. I missed the series version in subject. Shall I resend?

> 
> --
> 
> Changes since v3:
> - Added ACKed-By bits for patches 1, 4
> - Added new patch for stable by Larry as patch 3
> - Fixed argument scaling for b43 driver in patch 4
> 
> Changes since v2:
> - Improvements to commit messages. No functional changes.
> - Collect reviewed-by bits.
> 
> Changes since v1:
> - Merged brcmsmac driver patches into single patch
> - Merged b43 driver patches into single patch
> 
> Larry Finger (1):
>   b43: Fix error in cordic routine
> 
> Priit Laes (3):
>   lib: cordic: Move cordic macros and defines to header file
>   brcmsmac: Use cordic-related macros from common cordic library
>   b43: Use cordic algorithm from kernel library
> 
>  drivers/net/wireless/broadcom/b43/Kconfig                      |  1 +-
>  drivers/net/wireless/broadcom/b43/phy_common.c                 | 47 +-------
>  drivers/net/wireless/broadcom/b43/phy_common.h                 |  9 +-
>  drivers/net/wireless/broadcom/b43/phy_lp.c                     | 13 +-
>  drivers/net/wireless/broadcom/b43/phy_n.c                      | 13 +-
>  drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_int.h |  7 +-
>  drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c |  4 +-
>  drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c   |  4 +-
>  include/linux/cordic.h                                         |  9 +-
>  lib/cordic.c                                                   | 23 +---
>  10 files changed, 35 insertions(+), 95 deletions(-)
> 
> base-commit: 9ff01193a20d391e8dbce4403dd5ef87c7eaaca6
> -- 
> git-series 0.9.1
Kalle Valo Nov. 20, 2018, 1:22 p.m. UTC | #2
Priit Laes <plaes@plaes.org> writes:

> On Mon, Nov 19, 2018 at 08:01:21PM +0200, Priit Laes wrote:
>> b43 wireless driver includes an internal implementation of
>> cordic algorithm, although there's a common cordic library
>> which was split out from brcmsmac driver. Use that and drop
>> internal implementation.
>> 
>> During the process, cordic-algorithm related macros in
>> brcmfmac driver were also removed and use general macros.
>> 
>> Please note that this series is only compile-tested, as I
>> do not have access to the hardware.
>
>
> Gah.. I missed the series version in subject. Shall I resend?

No need, I'll remember now that this is v4.