| Message ID | 1248533676.19945.2.camel@johannes.local (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
On Sat, 2009-07-25 at 16:54 +0200, Johannes Berg wrote: > Jouni and Maxim reported an oops when using wpa_supplicant -Dnl80211, > which seems to be due to random data being contained in the crypto > settings for the assoc() command. This seems to be due to the missing > memset here, so add it -- it's certainly missing but I'm not 100% > certain that it will fix the problem. Indeed this fixes it. Although the NM still reports zero as signal level, and I see [ 417.210115] No probe response from AP 00:1b:9e:d8:77:02 after 200ms, disconnecting. [ 419.363655] wlan0: direct probe to AP 00:1b:9e:d8:77:02 (try 1) [ 419.369285] wlan0 direct probe responded [ 419.369292] wlan0: authenticate with AP 00:1b:9e:d8:77:02 (try 1) [ 419.371189] wlan0: authenticated [ 419.371513] wlan0: associate with AP 00:1b:9e:d8:77:02 (try 1) [ 419.374094] wlan0: RX AssocResp from 00:1b:9e:d8:77:02 (capab=0x411 status=0 aid=3) Although it isn't visible any more. Did wext compatibility layer got partially removed? iwconfig does show now much The last use of it, is to set tx power and bitrate, as this doesn't seem to be implemented in iw. Also NM applet doesn't show my network as connected. When I attempted to connect it freezed the system. Best regards, Maxim Levitsky > > Signed-off-by: Johannes Berg <johannes@sipsolutions.net> > --- > net/wireless/nl80211.c | 2 ++ > 1 file changed, 2 insertions(+) > > --- wireless-testing.orig/net/wireless/nl80211.c 2009-07-25 16:50:39.000000000 +0200 > +++ wireless-testing/net/wireless/nl80211.c 2009-07-25 16:51:00.000000000 +0200 > @@ -3385,6 +3385,8 @@ static int nl80211_crypto_settings(struc > struct cfg80211_crypto_settings *settings, > int cipher_limit) > { > + memset(settings, 0, sizeof(*settings)); > + > settings->control_port = info->attrs[NL80211_ATTR_CONTROL_PORT]; > > if (info->attrs[NL80211_ATTR_CIPHER_SUITES_PAIRWISE]) { > > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- wireless-testing.orig/net/wireless/nl80211.c 2009-07-25 16:50:39.000000000 +0200 +++ wireless-testing/net/wireless/nl80211.c 2009-07-25 16:51:00.000000000 +0200 @@ -3385,6 +3385,8 @@ static int nl80211_crypto_settings(struc struct cfg80211_crypto_settings *settings, int cipher_limit) { + memset(settings, 0, sizeof(*settings)); + settings->control_port = info->attrs[NL80211_ATTR_CONTROL_PORT]; if (info->attrs[NL80211_ATTR_CIPHER_SUITES_PAIRWISE]) {
Jouni and Maxim reported an oops when using wpa_supplicant -Dnl80211, which seems to be due to random data being contained in the crypto settings for the assoc() command. This seems to be due to the missing memset here, so add it -- it's certainly missing but I'm not 100% certain that it will fix the problem. Signed-off-by: Johannes Berg <johannes@sipsolutions.net> --- net/wireless/nl80211.c | 2 ++ 1 file changed, 2 insertions(+) -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html