From patchwork Fri Jul 31 21:28:06 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Reinette Chatre X-Patchwork-Id: 38591 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n6VLSF0P015456 for ; Fri, 31 Jul 2009 21:28:15 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752947AbZGaV2L (ORCPT ); Fri, 31 Jul 2009 17:28:11 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752937AbZGaV2K (ORCPT ); Fri, 31 Jul 2009 17:28:10 -0400 Received: from mga11.intel.com ([192.55.52.93]:24719 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752644AbZGaV2J (ORCPT ); Fri, 31 Jul 2009 17:28:09 -0400 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 31 Jul 2009 14:18:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.43,304,1246863600"; d="scan'208";a="479734354" Received: from rc-desk.jf.intel.com (HELO localhost.localdomain) ([134.134.15.187]) by fmsmga002.fm.intel.com with ESMTP; 31 Jul 2009 14:21:13 -0700 From: Reinette Chatre To: linville@tuxdriver.com Cc: linux-wireless@vger.kernel.org, ipw3945-devel@lists.sourceforge.net, Daniel C Halperin , Reinette Chatre Subject: [PATCH 1/4] iwlwifi: clear iwl_cmd_meta structure before use Date: Fri, 31 Jul 2009 14:28:06 -0700 Message-Id: <1249075689-8973-2-git-send-email-reinette.chatre@intel.com> X-Mailer: git-send-email 1.5.6.3 In-Reply-To: <1249075689-8973-1-git-send-email-reinette.chatre@intel.com> References: <1249075689-8973-1-git-send-email-reinette.chatre@intel.com> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Daniel C Halperin Resolve an issue in which out-dated fields in iwl_cmd_meta could be used for later hardware commands. Signed-off-by: Daniel C Halperin Signed-off-by: Reinette Chatre --- drivers/net/wireless/iwlwifi/iwl-tx.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/wireless/iwlwifi/iwl-tx.c b/drivers/net/wireless/iwlwifi/iwl-tx.c index 6bb9602..288b871 100644 --- a/drivers/net/wireless/iwlwifi/iwl-tx.c +++ b/drivers/net/wireless/iwlwifi/iwl-tx.c @@ -970,6 +970,7 @@ int iwl_enqueue_hcmd(struct iwl_priv *priv, struct iwl_host_cmd *cmd) out_cmd = txq->cmd[idx]; out_meta = &txq->meta[idx]; + memset(out_meta, 0, sizeof(*out_meta)); /* re-initialize to NULL */ out_meta->flags = cmd->flags; if (cmd->flags & CMD_WANT_SKB) out_meta->source = cmd;